From nobody Tue Sep 9 23:39:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1748517540252354.27142523458747; Thu, 29 May 2025 04:19:00 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3EF6B13CB; Thu, 29 May 2025 07:18:59 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id E59601826; Thu, 29 May 2025 07:17:21 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A2011135D; Thu, 29 May 2025 07:17:13 -0400 (EDT) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id EAC811362 for ; Thu, 29 May 2025 07:17:12 -0400 (EDT) Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-604533a2f62so1368252a12.3 for ; Thu, 29 May 2025 04:17:12 -0700 (PDT) Received: from tulp.my.domain (80-115-115-199.cable.dynamic.v4.ziggo.nl. [80.115.115.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ada6ad394dasm122537666b.130.2025.05.29.04.17.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 04:17:10 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748517431; x=1749122231; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3vVY/QB/s0640hlqw1zv0mNOWTuqvncI+zb5zV2OdIw=; b=UQcYcCmdOn8n4sHryLQmtJOm4GiyctUVRm5xlAVUMoz9kCsKW8a1cG1ynL6SJbImf0 zLsSE1oKZSvOucb//fPpHCCp3ZTjSSSujdj5J2+hEiavqPEMZVXimMyBYcJZ+Qez+qnO FmPfph7wZCVaYueqmBjGprExbTRNCxAegmqTWhI8TsDcfYk3ObXuuUUJjrnorV3a3hKj 4AoHu8fNL7pqANyIMhbbO5dgZ28WJnhHWofUy/bP8t7dhx5o/6xhPXMeHd+PmbcgXD2I EckbcV4/EPAaFFXoCO00ogjBZ3FDZdDmB/BtgelwgKIkhxx7xYLssd7MfhdrvBzmfdBr 1Ssg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748517431; x=1749122231; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3vVY/QB/s0640hlqw1zv0mNOWTuqvncI+zb5zV2OdIw=; b=FuqIhmXaWWrG6JoTgUlzUnVMnSGBMy4ygBzJim5UfSi6HiS8krzhF2/u32QM3Fo8WT +grC1laQOdsRNrtZrjTS5TkMzEBjxc/ddG4EuY0UBlSWhzC+4rNzsujgsO+HEfLq7nzs KbQeOQ8o9QYuXdQiHOm/1dAM++GkHjDgRKPaLiMgneScgSJWfgSWwfBho8L6+AQ2q9yo oKvCTeLrWC0bvSCCo9NflTgqqTjnN2NFPE1fr2se69ekiS1uq3OZt0u8aAlV87Z7wo3W FgQM9XxUqU6mZ1cj9W8HWMdNwkR8KM4Vgh27mcXUouTYWtQWsQk7QGq0PCmyCxHVsGvs 3OeA== X-Gm-Message-State: AOJu0Yw2DISHRkuVJQGhHsUk0n9DFKKWUnMyxSOUNS4nrG2GE/VNXjB/ yO/PHJeZM5zEhVq1o8qafLOGfhIuYtKUFeowQSTEyd0IwdB7CZUJP87FIsckwo7xXa2xNg== X-Gm-Gg: ASbGncsdbMe2UMmdiW/gRZBqQruA3epp4/EBmCD7NM90xcVHsusAmBcGw8+zSwyBZie +bezKs+I+A5vBx9nLa9yR+YOix3LnWgAxwqEw56wFjlPPoNszbdDwm7EPOqW3rqsBgEc0ZENPEL yodmhr3Qx/Dj8D0sUczrZajEfHkYC5IWA6q9NwNh41fbofylaxoT8HaS5gq2r0iluZMHXBgQQi3 x2jOi7t8JXsAs4cHecTyAWuZ7iD1SUAgQnfahjbG4RrWhphI3P0V2OT1CZqSb9yKqoOx1O0CPVg abGXj8/I+FDc1e5k4hdPdAIBYQvr0s47E8Ufq2Wyn5LIEHCfG33VCT+hwpnJ5wEunnOsHY4bD6H Gg4idzIMOnnjQcq1RvATAHhpf X-Google-Smtp-Source: AGHT+IE3bdru1+np/BTRtlAfOA2cAIFyLBfbYu8y2jaMBnl6EEefxi074/XskL9nwp0WXwlLdiZuTw== X-Received: by 2002:a17:906:4698:b0:ad8:9b5d:2c2f with SMTP id a640c23a62f3a-ad89b5d2ee4mr518118266b.4.1748517431162; Thu, 29 May 2025 04:17:11 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 3/3] bhyve: implement domainMemoryStats Date: Thu, 29 May 2025 13:15:51 +0200 Message-ID: <20250529111551.43347-4-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250529111551.43347-1-bogorodskiy@gmail.com> References: <20250529111551.43347-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BZO3CDW7ZI7LOXS4W67ZHF6U72CYV7WQ X-Message-ID-Hash: BZO3CDW7ZI7LOXS4W67ZHF6U72CYV7WQ X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748517541113116600 Content-Type: text/plain; charset="utf-8" Currently, bhyve does not support neither memory ballooning nor reporting guest memory usage. So the following information can be obtained: - RSS of the running process - Memory available to the guest (that is, guest total memory) Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_driver.c | 50 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index e4698b71bf..70e28c7e0b 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -3,6 +3,7 @@ * * Copyright (C) 2014 Roman Bogorodskiy * Copyright (C) 2014-2015 Red Hat, Inc. + * Copyright (C) 2025 The FreeBSD Foundation * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -1658,6 +1659,54 @@ bhyveDomainInterfaceStats(virDomainPtr domain, return ret; } =20 +#define BHYVE_SET_MEMSTAT(TAG, VAL) \ + if (i < nr_stats) { \ + stats[i].tag =3D TAG; \ + stats[i].val =3D VAL; \ + i++; \ + } + +static int +bhyveDomainMemoryStats(virDomainPtr domain, + virDomainMemoryStatPtr stats, + unsigned int nr_stats, + unsigned int flags) +{ + virDomainObj *vm; + unsigned maxmem; + unsigned long long rss; + size_t i =3D 0; + int ret =3D -1; + + virCheckFlags(0, -1); + + if (!(vm =3D bhyveDomObjFromDomain(domain))) + goto cleanup; + + if (virDomainObjCheckActive(vm) < 0) + goto cleanup; + + if (virDomainMemoryStatsEnsureACL(domain->conn, vm->def) < 0) + goto cleanup; + + if (virProcessGetStatInfo(NULL, NULL, NULL, NULL, &rss, vm->pid, 0) < = 0) + virReportError(VIR_ERR_OPERATION_FAILED, "%s", + _("cannot get RSS for domain")); + else + BHYVE_SET_MEMSTAT(VIR_DOMAIN_MEMORY_STAT_RSS, rss); + + maxmem =3D virDomainDefGetMemoryTotal(vm->def); + BHYVE_SET_MEMSTAT(VIR_DOMAIN_MEMORY_STAT_AVAILABLE, maxmem); + + ret =3D i; + + cleanup: + virDomainObjEndAPI(&vm); + return ret; +} + +#undef BHYVE_SET_MEMSTAT + static virHypervisorDriver bhyveHypervisorDriver =3D { .name =3D "bhyve", .connectURIProbe =3D bhyveConnectURIProbe, @@ -1719,6 +1768,7 @@ static virHypervisorDriver bhyveHypervisorDriver =3D { .connectDomainXMLFromNative =3D bhyveConnectDomainXMLFromNative, /* 2.= 1.0 */ .connectGetDomainCapabilities =3D bhyveConnectGetDomainCapabilities, /= * 2.1.0 */ .domainInterfaceStats =3D bhyveDomainInterfaceStats, /* 11.5.0 */ + .domainMemoryStats =3D bhyveDomainMemoryStats, /* 11.5.0 */ }; =20 =20 --=20 2.49.0