From nobody Tue Sep 9 23:39:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1748517506041669.6140854852341; Thu, 29 May 2025 04:18:26 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 133FE18D1; Thu, 29 May 2025 07:18:25 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id B9D6313C4; Thu, 29 May 2025 07:17:18 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id F17811224; Thu, 29 May 2025 07:17:12 -0400 (EDT) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 408231224 for ; Thu, 29 May 2025 07:17:12 -0400 (EDT) Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-adb2bd27c7bso34317466b.2 for ; Thu, 29 May 2025 04:17:12 -0700 (PDT) Received: from tulp.my.domain (80-115-115-199.cable.dynamic.v4.ziggo.nl. [80.115.115.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ada6ad394dasm122537666b.130.2025.05.29.04.17.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 04:17:09 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748517430; x=1749122230; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nBxpdXkDxPeM5AeA/n7ILT9lQg+ISgquul0qtl1WpYw=; b=S+jntoH9kRRJ4XO6LjEnG1O9+ShvSMnzC14wrxiojwFuobwZl9khKRnZpyMwVF9GUk yQQt9jjXzEgK0GqrtkpTquYp4WYGfdg9ZQDMUr5sWed+yuLBPJk+ukO2LyXPyQ/9Sofg M6xTw17Z0bMUcjnFs7MiOQlhwNrMQ1xUs5ce2iWpXz1Z/+OoiCIOArC4NwmM6U//cIFR CwpQeS8AL2mbXVdnVkdamO12NP7LmfQfIhj8bdyXEcWGyxgN9jRW7VOebAt4L9gGF6mz fA1qeOEf4qC5+A6Dw0yItZk46fR1xBUmAYZm+PiI9xSfyE7TeqqP+Je543q+nkjm8cVY o1EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748517430; x=1749122230; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nBxpdXkDxPeM5AeA/n7ILT9lQg+ISgquul0qtl1WpYw=; b=WzgVnYosCo8rtwfktP3lZMkuwXuG1Uov0yyvMLnOygfoIEzdI1SiOSOX7mVKW5NDAi SyEWVEGnBUrjWT1Z2wkxM9Jh6HCOFdUhISa3mgHmOSrjHzohZmP79w84zMJp2UkPZl4E gY3uRFZ9XQc0yeOsnbpc4hucWH+e5WCm2WvE7N55DvEAVZCTybZlgS3KgRRS1IWG3+xI 54BDHhg5FuHL/9dbndhxRBShH+JJPH2VUoEwe1G6iqLd4so/25ZD9RDRL0kT1VGxcGBC TbbG32/GF7wVqC2o+cKsfeCAlio22ij0aFvCpUgDvXeb81bqSL1PUcVLxnUQqAtNahC6 M7SA== X-Gm-Message-State: AOJu0Yz6tZX92+F6UzaQqmNaZQIRiyJUZTmeeexew6p+II9NjahNSLTg 4/P4UDyxbI3k8M6hsnQ48mJR4Lx5vW4xxg48lVbtkHen4sqspzwIzeZ+5JaeYcOgteCOmA== X-Gm-Gg: ASbGncvcBMH4VTZE5X3BuDXx8zqq9XJagjHyOojZ9TZBAdcyBrmAYitoDX5l43a8psB NG0jDKCjiE1kowV1btwjry89luH4bCWpkat24xvK+iqsVPFVOlexJAX/j1UNjlNFlLQndKAVgHZ Nd5/A6Ni0lWuSf4Lr555pI80aXKIY45oc0Iyk73gaWtfr5vdH5V6AHFKmSUXeYbRbdZ4o3pEAiB BDPPErCbl+EdOL8aJYwW6QCz4y1T3DDA31kTsVCSG583Efw6nccbfViLGW0rws5zh8O2TgEbLy5 qJV34dhwwHuE9foFNYdPwRGZvjj2tO7to12/6PVDN+jtchlNVItci9YhIurdnFyahOXFAZg7fCv Acnp18d6RJ+j2gaE7t6U1dmHDjS3nCiZPhHU= X-Google-Smtp-Source: AGHT+IEZDatnvdQQBHyNoWvNdquSOJoDeM2jnEblHma9JFjsjhQ5WoAlsSdsON9NiQbJMPVErf5z3g== X-Received: by 2002:a17:907:7247:b0:ad8:a2a8:23d1 with SMTP id a640c23a62f3a-ad8a2a826admr489118866b.49.1748517429985; Thu, 29 May 2025 04:17:09 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 2/3] virprocess: implement virProcessGetStatInfo() for FreeBSD Date: Thu, 29 May 2025 13:15:50 +0200 Message-ID: <20250529111551.43347-3-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250529111551.43347-1-bogorodskiy@gmail.com> References: <20250529111551.43347-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7ZG3JWKHLW5I2JTUTGW3HEV4LTRURXUO X-Message-ID-Hash: 7ZG3JWKHLW5I2JTUTGW3HEV4LTRURXUO X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748517506565116600 Content-Type: text/plain; charset="utf-8" Use the "kern.proc.pid" sysctl and retrieve information from the kinfo_proc struct. Signed-off-by: Roman Bogorodskiy --- src/util/virprocess.c | 104 +++++++++++++++++++++++++++++++----------- 1 file changed, 78 insertions(+), 26 deletions(-) diff --git a/src/util/virprocess.c b/src/util/virprocess.c index 05db76d834..3889ba90f9 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -1812,7 +1812,85 @@ virProcessGetStatInfo(unsigned long long *cpuTime, =20 return 0; } +#elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) +int +virProcessGetStatInfo(unsigned long long *cpuTime, + unsigned long long *userTime, + unsigned long long *sysTime, + int *lastCpu, + unsigned long long *vm_rss, + pid_t pid, + pid_t tid) +{ + struct kinfo_proc p; + int mib[4]; + size_t len =3D 4; + unsigned long long utime =3D 0; + unsigned long long stime =3D 0; + unsigned long long rss =3D 0; + int cpu =3D 0; + const long pagesize =3D virGetSystemPageSizeKB(); + + sysctlnametomib("kern.proc.pid", mib, &len); + + len =3D sizeof(struct kinfo_proc); + mib[3] =3D pid; + + if (sysctl(mib, 4, &p, &len, NULL, 0) < 0) { + virReportSystemError(errno, "%s", + _("Unable to query process stats")); + return -1; + } + + utime =3D p.ki_rusage.ru_utime.tv_sec; + stime =3D p.ki_rusage.ru_stime.tv_sec; + rss =3D p.ki_rssize * pagesize; + cpu =3D p.ki_lastcpu_old; + + if (cpuTime) + *cpuTime =3D utime + stime; + if (userTime) + *userTime =3D utime; + if (sysTime) + *sysTime =3D stime; + if (lastCpu) + *lastCpu =3D cpu; + if (vm_rss) + *vm_rss =3D rss; + + VIR_DEBUG("Got status for %d/%d user=3D%llu sys=3D%llu cpu=3D%d rss=3D= %lld", + (int) pid, tid, utime, stime, cpu, rss); + + return 0; +} +#else +int +virProcessGetStatInfo(unsigned long long *cpuTime, + unsigned long long *userTime, + unsigned long long *sysTime, + int *lastCpu, + unsigned long long *vm_rss, + pid_t pid G_GNUC_UNUSED, + pid_t tid G_GNUC_UNUSED) +{ + /* We don't have a way to collect this information on non-Linux + * platforms, so just report neutral values */ + if (cpuTime) + *cpuTime =3D 0; + if (userTime) + *userTime =3D 0; + if (sysTime) + *sysTime =3D 0; + if (lastCpu) + *lastCpu =3D 0; + if (vm_rss) + *vm_rss =3D 0; + + return 0; +} +#endif =20 +#ifdef __linux__ int virProcessGetSchedInfo(unsigned long long *cpuWait, pid_t pid, @@ -1879,33 +1957,7 @@ virProcessGetSchedInfo(unsigned long long *cpuWait, =20 return 0; } - #else -int -virProcessGetStatInfo(unsigned long long *cpuTime, - unsigned long long *userTime, - unsigned long long *sysTime, - int *lastCpu, - unsigned long long *vm_rss, - pid_t pid G_GNUC_UNUSED, - pid_t tid G_GNUC_UNUSED) -{ - /* We don't have a way to collect this information on non-Linux - * platforms, so just report neutral values */ - if (cpuTime) - *cpuTime =3D 0; - if (userTime) - *userTime =3D 0; - if (sysTime) - *sysTime =3D 0; - if (lastCpu) - *lastCpu =3D 0; - if (vm_rss) - *vm_rss =3D 0; - - return 0; -} - int virProcessGetSchedInfo(unsigned long long *cpuWait, pid_t pid G_GNUC_UNUSED, --=20 2.49.0