From nobody Tue Sep 9 19:00:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1748517476914785.2599758476321; Thu, 29 May 2025 04:17:56 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 0248718C9; Thu, 29 May 2025 07:17:55 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id BC04C1441; Thu, 29 May 2025 07:17:15 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id D7D881224; Thu, 29 May 2025 07:17:11 -0400 (EDT) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 16E171362 for ; Thu, 29 May 2025 07:17:11 -0400 (EDT) Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-ad1b94382b8so130401166b.0 for ; Thu, 29 May 2025 04:17:11 -0700 (PDT) Received: from tulp.my.domain (80-115-115-199.cable.dynamic.v4.ziggo.nl. [80.115.115.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ada6ad394dasm122537666b.130.2025.05.29.04.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 04:17:08 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748517429; x=1749122229; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tmeN9qZM+TR8Cj3yHEUiUu8g9XGu6BiYFUYYXw100Xs=; b=OuvOpYf0y4Wqht2MUJIsMocvkY0eF+IJnoS4tuVPsP6bZC7PRYgLkK1q2BF9iABj0E V/1oC9Y/Ckw0ANSxblDbgTsdK7NCZYl/IldwAD1FBrDGGxpyaoZmDZGn+lAZNLxb0HER 9wyzTgw7tT4Kos3jj7odlNPYAM3whsN7VeOMsxzsMJNfkeOD8nfGl3U6p85fdtE6T0NB RZh9BlDcWjZLi1woEgvOc390B5KFYMyxvLe8fdUCaRFzpHbgKIcNEiumRHv3xMO7kGkd S1uXzReICeUUWMTbgkwU3/DK8Vg0+geCxt8Tb/Q8H9jewx2wZtvx+X0lNhKr+Lbb/FHX tKRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748517429; x=1749122229; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tmeN9qZM+TR8Cj3yHEUiUu8g9XGu6BiYFUYYXw100Xs=; b=mGyfOveaAnpuNFNBb0Sdca0tbmV48IQ0kI6+6KZnYZRsSKmCEhjeLpJs0Im6NJVdWB gdADwybnLnzxV5gDB/5+V6BhH1wzItU7V9nDvCzoUuagAlP4qmWZ2x0HbvUAKm8bFs1P QS5LwsgqAgGNZzWAJaXgfcA++XX/6jRI/2Ag1Yg0GeTbaNKRmbInvVYf8PGei+Qub9b1 J7g1DRXd3umLO/Xqlrp4O8+WHW6wQQnd0zR1zkmyf3D0C1CuU8jnZtXjCZX2YR/Bkr1X MvoBJdVCnJqEVbMD0bc2Dy3ypOs/toDzIk020Twcg4gKOQotIUvqVzuU+4UN3m0ynBoX gBcA== X-Gm-Message-State: AOJu0YzRcaaAjJgs84mm35Eak4CJyZ1Z+ccs8PPWCpJsfMjKWtcGaNvd eKTMCuz93E2M+B6E3YaEdHoAaJut4+HB5x22BVg2dwImhe5xaIoMYx0wa9VgKodG1JJlSQ== X-Gm-Gg: ASbGncupI2YeXbqepiGCTBXnOO2v2ywW+6ReDsyLV25ko+9SfoqQN8IhjkFipsulgFq JCog4/H1cwhtmu42VVUVvu2N/oKzc0zoHpH/GhrLni37miIgTlN9fDLvfUdll2sDoIddlA6+3cZ bMNHHtbtdX5LOOXHqGINOQDF7J6LvYVWrDO0NzHqOEp9WFIaayVMJCNQonAMBnkJlgw4iw/Jwyh aWSTybs+mjm2Eh2sNK0C3wxRSyHZJx6Wo+fIHRjnaft2AZ+4EnzsrCA22Ddy7iha1AxR0bev8Gd 1n+BnNgy0z0kIZaE+XGOxHVjqHW74sSUh5Z6aZNSOshjMFgrgzhNzg6kpk+CChTor0S9RVJQhzz nXaYoGKwppU35/Kot2/VgLB47 X-Google-Smtp-Source: AGHT+IEibHkvdv7GGMka/W2VZIlFm2dPIvYY4eqr4Lpiw35B6MefIInAYgLb1QXr1z4yqY5Pq1MHGw== X-Received: by 2002:a17:906:6a18:b0:ad8:83da:f862 with SMTP id a640c23a62f3a-adabf417c96mr161781166b.0.1748517429155; Thu, 29 May 2025 04:17:09 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 1/3] bhyve: implement domainInterfaceStats Date: Thu, 29 May 2025 13:15:49 +0200 Message-ID: <20250529111551.43347-2-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250529111551.43347-1-bogorodskiy@gmail.com> References: <20250529111551.43347-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: LIIYNGAWE6CDOQXUFMEQMK6K4VP5ZJFH X-Message-ID-Hash: LIIYNGAWE6CDOQXUFMEQMK6K4VP5ZJFH X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748517478310116600 Content-Type: text/plain; charset="utf-8" The virNetDevTapInterfaceStats() function already works on FreeBSD, so it's just a matter of wrapping that for domainInterfaceStats. Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_driver.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index db7d440a97..e4698b71bf 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -55,6 +55,7 @@ #include "conf/domain_capabilities.h" #include "virutil.h" #include "domain_driver.h" +#include "virnetdevtap.h" =20 #include "bhyve_conf.h" #include "bhyve_device.h" @@ -1625,6 +1626,38 @@ bhyveConnectGetDomainCapabilities(virConnectPtr conn, return ret; } =20 +static int +bhyveDomainInterfaceStats(virDomainPtr domain, + const char *device, + virDomainInterfaceStatsPtr stats) +{ + virDomainObj *vm; + int ret =3D -1; + virDomainNetDef *net =3D NULL; + + if (!(vm =3D bhyveDomObjFromDomain(domain))) + goto cleanup; + + if (virDomainInterfaceStatsEnsureACL(domain->conn, vm->def) < 0) + goto cleanup; + + if (virDomainObjCheckActive(vm) < 0) + goto cleanup; + + if (!(net =3D virDomainNetFind(vm->def, device))) + goto cleanup; + + if (virNetDevTapInterfaceStats(net->ifname, stats, + !virDomainNetTypeSharesHostView(net)) <= 0) + goto cleanup; + + ret =3D 0; + + cleanup: + virDomainObjEndAPI(&vm); + return ret; +} + static virHypervisorDriver bhyveHypervisorDriver =3D { .name =3D "bhyve", .connectURIProbe =3D bhyveConnectURIProbe, @@ -1685,6 +1718,7 @@ static virHypervisorDriver bhyveHypervisorDriver =3D { .connectIsEncrypted =3D bhyveConnectIsEncrypted, /* 1.3.5 */ .connectDomainXMLFromNative =3D bhyveConnectDomainXMLFromNative, /* 2.= 1.0 */ .connectGetDomainCapabilities =3D bhyveConnectGetDomainCapabilities, /= * 2.1.0 */ + .domainInterfaceStats =3D bhyveDomainInterfaceStats, /* 11.5.0 */ }; =20 =20 --=20 2.49.0 From nobody Tue Sep 9 19:00:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1748517506041669.6140854852341; Thu, 29 May 2025 04:18:26 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 133FE18D1; Thu, 29 May 2025 07:18:25 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id B9D6313C4; Thu, 29 May 2025 07:17:18 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id F17811224; Thu, 29 May 2025 07:17:12 -0400 (EDT) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 408231224 for ; Thu, 29 May 2025 07:17:12 -0400 (EDT) Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-adb2bd27c7bso34317466b.2 for ; Thu, 29 May 2025 04:17:12 -0700 (PDT) Received: from tulp.my.domain (80-115-115-199.cable.dynamic.v4.ziggo.nl. [80.115.115.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ada6ad394dasm122537666b.130.2025.05.29.04.17.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 04:17:09 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748517430; x=1749122230; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nBxpdXkDxPeM5AeA/n7ILT9lQg+ISgquul0qtl1WpYw=; b=S+jntoH9kRRJ4XO6LjEnG1O9+ShvSMnzC14wrxiojwFuobwZl9khKRnZpyMwVF9GUk yQQt9jjXzEgK0GqrtkpTquYp4WYGfdg9ZQDMUr5sWed+yuLBPJk+ukO2LyXPyQ/9Sofg M6xTw17Z0bMUcjnFs7MiOQlhwNrMQ1xUs5ce2iWpXz1Z/+OoiCIOArC4NwmM6U//cIFR CwpQeS8AL2mbXVdnVkdamO12NP7LmfQfIhj8bdyXEcWGyxgN9jRW7VOebAt4L9gGF6mz fA1qeOEf4qC5+A6Dw0yItZk46fR1xBUmAYZm+PiI9xSfyE7TeqqP+Je543q+nkjm8cVY o1EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748517430; x=1749122230; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nBxpdXkDxPeM5AeA/n7ILT9lQg+ISgquul0qtl1WpYw=; b=WzgVnYosCo8rtwfktP3lZMkuwXuG1Uov0yyvMLnOygfoIEzdI1SiOSOX7mVKW5NDAi SyEWVEGnBUrjWT1Z2wkxM9Jh6HCOFdUhISa3mgHmOSrjHzohZmP79w84zMJp2UkPZl4E gY3uRFZ9XQc0yeOsnbpc4hucWH+e5WCm2WvE7N55DvEAVZCTybZlgS3KgRRS1IWG3+xI 54BDHhg5FuHL/9dbndhxRBShH+JJPH2VUoEwe1G6iqLd4so/25ZD9RDRL0kT1VGxcGBC TbbG32/GF7wVqC2o+cKsfeCAlio22ij0aFvCpUgDvXeb81bqSL1PUcVLxnUQqAtNahC6 M7SA== X-Gm-Message-State: AOJu0Yz6tZX92+F6UzaQqmNaZQIRiyJUZTmeeexew6p+II9NjahNSLTg 4/P4UDyxbI3k8M6hsnQ48mJR4Lx5vW4xxg48lVbtkHen4sqspzwIzeZ+5JaeYcOgteCOmA== X-Gm-Gg: ASbGncvcBMH4VTZE5X3BuDXx8zqq9XJagjHyOojZ9TZBAdcyBrmAYitoDX5l43a8psB NG0jDKCjiE1kowV1btwjry89luH4bCWpkat24xvK+iqsVPFVOlexJAX/j1UNjlNFlLQndKAVgHZ Nd5/A6Ni0lWuSf4Lr555pI80aXKIY45oc0Iyk73gaWtfr5vdH5V6AHFKmSUXeYbRbdZ4o3pEAiB BDPPErCbl+EdOL8aJYwW6QCz4y1T3DDA31kTsVCSG583Efw6nccbfViLGW0rws5zh8O2TgEbLy5 qJV34dhwwHuE9foFNYdPwRGZvjj2tO7to12/6PVDN+jtchlNVItci9YhIurdnFyahOXFAZg7fCv Acnp18d6RJ+j2gaE7t6U1dmHDjS3nCiZPhHU= X-Google-Smtp-Source: AGHT+IEZDatnvdQQBHyNoWvNdquSOJoDeM2jnEblHma9JFjsjhQ5WoAlsSdsON9NiQbJMPVErf5z3g== X-Received: by 2002:a17:907:7247:b0:ad8:a2a8:23d1 with SMTP id a640c23a62f3a-ad8a2a826admr489118866b.49.1748517429985; Thu, 29 May 2025 04:17:09 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 2/3] virprocess: implement virProcessGetStatInfo() for FreeBSD Date: Thu, 29 May 2025 13:15:50 +0200 Message-ID: <20250529111551.43347-3-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250529111551.43347-1-bogorodskiy@gmail.com> References: <20250529111551.43347-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7ZG3JWKHLW5I2JTUTGW3HEV4LTRURXUO X-Message-ID-Hash: 7ZG3JWKHLW5I2JTUTGW3HEV4LTRURXUO X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748517506565116600 Content-Type: text/plain; charset="utf-8" Use the "kern.proc.pid" sysctl and retrieve information from the kinfo_proc struct. Signed-off-by: Roman Bogorodskiy --- src/util/virprocess.c | 104 +++++++++++++++++++++++++++++++----------- 1 file changed, 78 insertions(+), 26 deletions(-) diff --git a/src/util/virprocess.c b/src/util/virprocess.c index 05db76d834..3889ba90f9 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -1812,7 +1812,85 @@ virProcessGetStatInfo(unsigned long long *cpuTime, =20 return 0; } +#elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) +int +virProcessGetStatInfo(unsigned long long *cpuTime, + unsigned long long *userTime, + unsigned long long *sysTime, + int *lastCpu, + unsigned long long *vm_rss, + pid_t pid, + pid_t tid) +{ + struct kinfo_proc p; + int mib[4]; + size_t len =3D 4; + unsigned long long utime =3D 0; + unsigned long long stime =3D 0; + unsigned long long rss =3D 0; + int cpu =3D 0; + const long pagesize =3D virGetSystemPageSizeKB(); + + sysctlnametomib("kern.proc.pid", mib, &len); + + len =3D sizeof(struct kinfo_proc); + mib[3] =3D pid; + + if (sysctl(mib, 4, &p, &len, NULL, 0) < 0) { + virReportSystemError(errno, "%s", + _("Unable to query process stats")); + return -1; + } + + utime =3D p.ki_rusage.ru_utime.tv_sec; + stime =3D p.ki_rusage.ru_stime.tv_sec; + rss =3D p.ki_rssize * pagesize; + cpu =3D p.ki_lastcpu_old; + + if (cpuTime) + *cpuTime =3D utime + stime; + if (userTime) + *userTime =3D utime; + if (sysTime) + *sysTime =3D stime; + if (lastCpu) + *lastCpu =3D cpu; + if (vm_rss) + *vm_rss =3D rss; + + VIR_DEBUG("Got status for %d/%d user=3D%llu sys=3D%llu cpu=3D%d rss=3D= %lld", + (int) pid, tid, utime, stime, cpu, rss); + + return 0; +} +#else +int +virProcessGetStatInfo(unsigned long long *cpuTime, + unsigned long long *userTime, + unsigned long long *sysTime, + int *lastCpu, + unsigned long long *vm_rss, + pid_t pid G_GNUC_UNUSED, + pid_t tid G_GNUC_UNUSED) +{ + /* We don't have a way to collect this information on non-Linux + * platforms, so just report neutral values */ + if (cpuTime) + *cpuTime =3D 0; + if (userTime) + *userTime =3D 0; + if (sysTime) + *sysTime =3D 0; + if (lastCpu) + *lastCpu =3D 0; + if (vm_rss) + *vm_rss =3D 0; + + return 0; +} +#endif =20 +#ifdef __linux__ int virProcessGetSchedInfo(unsigned long long *cpuWait, pid_t pid, @@ -1879,33 +1957,7 @@ virProcessGetSchedInfo(unsigned long long *cpuWait, =20 return 0; } - #else -int -virProcessGetStatInfo(unsigned long long *cpuTime, - unsigned long long *userTime, - unsigned long long *sysTime, - int *lastCpu, - unsigned long long *vm_rss, - pid_t pid G_GNUC_UNUSED, - pid_t tid G_GNUC_UNUSED) -{ - /* We don't have a way to collect this information on non-Linux - * platforms, so just report neutral values */ - if (cpuTime) - *cpuTime =3D 0; - if (userTime) - *userTime =3D 0; - if (sysTime) - *sysTime =3D 0; - if (lastCpu) - *lastCpu =3D 0; - if (vm_rss) - *vm_rss =3D 0; - - return 0; -} - int virProcessGetSchedInfo(unsigned long long *cpuWait, pid_t pid G_GNUC_UNUSED, --=20 2.49.0 From nobody Tue Sep 9 19:00:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1748517540252354.27142523458747; Thu, 29 May 2025 04:19:00 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3EF6B13CB; Thu, 29 May 2025 07:18:59 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id E59601826; Thu, 29 May 2025 07:17:21 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A2011135D; Thu, 29 May 2025 07:17:13 -0400 (EDT) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id EAC811362 for ; Thu, 29 May 2025 07:17:12 -0400 (EDT) Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-604533a2f62so1368252a12.3 for ; Thu, 29 May 2025 04:17:12 -0700 (PDT) Received: from tulp.my.domain (80-115-115-199.cable.dynamic.v4.ziggo.nl. [80.115.115.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ada6ad394dasm122537666b.130.2025.05.29.04.17.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 04:17:10 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748517431; x=1749122231; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3vVY/QB/s0640hlqw1zv0mNOWTuqvncI+zb5zV2OdIw=; b=UQcYcCmdOn8n4sHryLQmtJOm4GiyctUVRm5xlAVUMoz9kCsKW8a1cG1ynL6SJbImf0 zLsSE1oKZSvOucb//fPpHCCp3ZTjSSSujdj5J2+hEiavqPEMZVXimMyBYcJZ+Qez+qnO FmPfph7wZCVaYueqmBjGprExbTRNCxAegmqTWhI8TsDcfYk3ObXuuUUJjrnorV3a3hKj 4AoHu8fNL7pqANyIMhbbO5dgZ28WJnhHWofUy/bP8t7dhx5o/6xhPXMeHd+PmbcgXD2I EckbcV4/EPAaFFXoCO00ogjBZ3FDZdDmB/BtgelwgKIkhxx7xYLssd7MfhdrvBzmfdBr 1Ssg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748517431; x=1749122231; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3vVY/QB/s0640hlqw1zv0mNOWTuqvncI+zb5zV2OdIw=; b=FuqIhmXaWWrG6JoTgUlzUnVMnSGBMy4ygBzJim5UfSi6HiS8krzhF2/u32QM3Fo8WT +grC1laQOdsRNrtZrjTS5TkMzEBjxc/ddG4EuY0UBlSWhzC+4rNzsujgsO+HEfLq7nzs KbQeOQ8o9QYuXdQiHOm/1dAM++GkHjDgRKPaLiMgneScgSJWfgSWwfBho8L6+AQ2q9yo oKvCTeLrWC0bvSCCo9NflTgqqTjnN2NFPE1fr2se69ekiS1uq3OZt0u8aAlV87Z7wo3W FgQM9XxUqU6mZ1cj9W8HWMdNwkR8KM4Vgh27mcXUouTYWtQWsQk7QGq0PCmyCxHVsGvs 3OeA== X-Gm-Message-State: AOJu0Yw2DISHRkuVJQGhHsUk0n9DFKKWUnMyxSOUNS4nrG2GE/VNXjB/ yO/PHJeZM5zEhVq1o8qafLOGfhIuYtKUFeowQSTEyd0IwdB7CZUJP87FIsckwo7xXa2xNg== X-Gm-Gg: ASbGncsdbMe2UMmdiW/gRZBqQruA3epp4/EBmCD7NM90xcVHsusAmBcGw8+zSwyBZie +bezKs+I+A5vBx9nLa9yR+YOix3LnWgAxwqEw56wFjlPPoNszbdDwm7EPOqW3rqsBgEc0ZENPEL yodmhr3Qx/Dj8D0sUczrZajEfHkYC5IWA6q9NwNh41fbofylaxoT8HaS5gq2r0iluZMHXBgQQi3 x2jOi7t8JXsAs4cHecTyAWuZ7iD1SUAgQnfahjbG4RrWhphI3P0V2OT1CZqSb9yKqoOx1O0CPVg abGXj8/I+FDc1e5k4hdPdAIBYQvr0s47E8Ufq2Wyn5LIEHCfG33VCT+hwpnJ5wEunnOsHY4bD6H Gg4idzIMOnnjQcq1RvATAHhpf X-Google-Smtp-Source: AGHT+IE3bdru1+np/BTRtlAfOA2cAIFyLBfbYu8y2jaMBnl6EEefxi074/XskL9nwp0WXwlLdiZuTw== X-Received: by 2002:a17:906:4698:b0:ad8:9b5d:2c2f with SMTP id a640c23a62f3a-ad89b5d2ee4mr518118266b.4.1748517431162; Thu, 29 May 2025 04:17:11 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 3/3] bhyve: implement domainMemoryStats Date: Thu, 29 May 2025 13:15:51 +0200 Message-ID: <20250529111551.43347-4-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250529111551.43347-1-bogorodskiy@gmail.com> References: <20250529111551.43347-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BZO3CDW7ZI7LOXS4W67ZHF6U72CYV7WQ X-Message-ID-Hash: BZO3CDW7ZI7LOXS4W67ZHF6U72CYV7WQ X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748517541113116600 Content-Type: text/plain; charset="utf-8" Currently, bhyve does not support neither memory ballooning nor reporting guest memory usage. So the following information can be obtained: - RSS of the running process - Memory available to the guest (that is, guest total memory) Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_driver.c | 50 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index e4698b71bf..70e28c7e0b 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -3,6 +3,7 @@ * * Copyright (C) 2014 Roman Bogorodskiy * Copyright (C) 2014-2015 Red Hat, Inc. + * Copyright (C) 2025 The FreeBSD Foundation * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -1658,6 +1659,54 @@ bhyveDomainInterfaceStats(virDomainPtr domain, return ret; } =20 +#define BHYVE_SET_MEMSTAT(TAG, VAL) \ + if (i < nr_stats) { \ + stats[i].tag =3D TAG; \ + stats[i].val =3D VAL; \ + i++; \ + } + +static int +bhyveDomainMemoryStats(virDomainPtr domain, + virDomainMemoryStatPtr stats, + unsigned int nr_stats, + unsigned int flags) +{ + virDomainObj *vm; + unsigned maxmem; + unsigned long long rss; + size_t i =3D 0; + int ret =3D -1; + + virCheckFlags(0, -1); + + if (!(vm =3D bhyveDomObjFromDomain(domain))) + goto cleanup; + + if (virDomainObjCheckActive(vm) < 0) + goto cleanup; + + if (virDomainMemoryStatsEnsureACL(domain->conn, vm->def) < 0) + goto cleanup; + + if (virProcessGetStatInfo(NULL, NULL, NULL, NULL, &rss, vm->pid, 0) < = 0) + virReportError(VIR_ERR_OPERATION_FAILED, "%s", + _("cannot get RSS for domain")); + else + BHYVE_SET_MEMSTAT(VIR_DOMAIN_MEMORY_STAT_RSS, rss); + + maxmem =3D virDomainDefGetMemoryTotal(vm->def); + BHYVE_SET_MEMSTAT(VIR_DOMAIN_MEMORY_STAT_AVAILABLE, maxmem); + + ret =3D i; + + cleanup: + virDomainObjEndAPI(&vm); + return ret; +} + +#undef BHYVE_SET_MEMSTAT + static virHypervisorDriver bhyveHypervisorDriver =3D { .name =3D "bhyve", .connectURIProbe =3D bhyveConnectURIProbe, @@ -1719,6 +1768,7 @@ static virHypervisorDriver bhyveHypervisorDriver =3D { .connectDomainXMLFromNative =3D bhyveConnectDomainXMLFromNative, /* 2.= 1.0 */ .connectGetDomainCapabilities =3D bhyveConnectGetDomainCapabilities, /= * 2.1.0 */ .domainInterfaceStats =3D bhyveDomainInterfaceStats, /* 11.5.0 */ + .domainMemoryStats =3D bhyveDomainMemoryStats, /* 11.5.0 */ }; =20 =20 --=20 2.49.0