From nobody Tue Sep 9 23:37:04 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1748254469; cv=none; d=zohomail.com; s=zohoarc; b=ktsQpt/rN1rtM2MYT5U/4WyFlYogQ4ySLyQNHscEC9PiIez9Nj1WvdR9LHfaUw35b8+zE2A+0uEau6ayv8uBL96ofjUshw9eQWj9PIzaS6TmPzMJ0ErqrfZ1zu5R+ccVwQd9c8rDj8F34k4EniBk7KmW0I5Nlc2vSGK/f+SDHg0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748254469; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=3Q0399tvrBVaUSLfzOpTL2nYq9RfJj/MSzmPlKiXcp0=; b=Xtw3jzZZYdXYX9HNnjS/UYc4PS7NGvlIpGwmvYx/qRfmx0M9rpAVFUyH9vWzvnpIy9/ysrjSCDZSpKEOsWNDO4Al10ry2jzv0AAuokFeJaZRSWf3zp0I9F+iTf9RBOKnC86r7MoBXBmTLkdIEFoBcQ7E7tP8YcoabiDi1wxcrt0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 174825446965892.21152385599748; Mon, 26 May 2025 03:14:29 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A367B161C; Mon, 26 May 2025 06:14:28 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id B9C4C168A; Mon, 26 May 2025 06:13:14 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 1A5D417AC; Mon, 26 May 2025 06:13:09 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3D9C513D8 for ; Mon, 26 May 2025 06:13:07 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-317-Qd-g2sr7M0SF63qwrz-3Nw-1; Mon, 26 May 2025 06:13:05 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DCAF71800447 for ; Mon, 26 May 2025 10:13:04 +0000 (UTC) Received: from kshcheti-thinkpadp1gen4i.tpbc.com (unknown [10.43.2.246]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D3E2630001A1; Mon, 26 May 2025 10:13:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748254387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I6XJqDmsrw8X6CzPFK5gcLqPiFDfmpHC42GG8qwnlzI=; b=ALSW1GT1fOXDiEQM9vGPk5c0OlObd61bl9JvHWA/O8d5BjZ1mGhaAEvNGBwkA9d/f6YmYo zXO0V1KGlqbsTX9Re+IpSWSFQE7w2nkrUSijT2ukBTQljd+iSDK1LvX3YuKWnGBX5OGZo9 hZUNKWUE1gEGrRksnKhao3/bp4p5wno= X-MC-Unique: Qd-g2sr7M0SF63qwrz-3Nw-1 X-Mimecast-MFC-AGG-ID: Qd-g2sr7M0SF63qwrz-3Nw_1748254385 To: devel@lists.libvirt.org Subject: [PATCH 1/2] schemas: path types unification / refactor Date: Mon, 26 May 2025 12:10:38 +0200 Message-ID: <20250526101235.33731-2-kshcheti@redhat.com> In-Reply-To: <20250526101235.33731-1-kshcheti@redhat.com> References: <20250526101235.33731-1-kshcheti@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: z0l7R9ypT873T1hSdh9F3hLAv3nwwcw5PdnWF1IPoXA_1748254385 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: YP2LLPCNI35PAIGJSHIHP42UWNL45WFM X-Message-ID-Hash: YP2LLPCNI35PAIGJSHIHP42UWNL45WFM X-MailFrom: kshcheti@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Kirill Shchetiniuk X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Kirill Shchetiniuk via Devel Reply-To: Kirill Shchetiniuk X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748254472020116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Kirill Shchetiniuk Previously, path types were defined separately for files and directories. The `absDirPath` type, in particular, did not accept Windows-style paths. Now, absolute paths for files and directories are united under the 'absolutePath' type. Relative paths were in fact the same but under different names, and in some places the 'filePath` was used for the directories. Now, the relative path type definition is united under the 'relativePath' type. Now only one place is explicitly meant to accept relative paths. In other places, it is possible to use absolute paths, but the `relativePath` type was retained for users who previously relied on relative paths, to avoid breaking their existing setups. Thus, relative paths can still be accepted. Signed-off-by: Kirill Shchetiniuk --- src/conf/schemas/basictypes.rng | 18 +--- src/conf/schemas/capability.rng | 4 +- src/conf/schemas/domainbackup.rng | 10 +-- src/conf/schemas/domaincaps.rng | 2 +- src/conf/schemas/domaincheckpoint.rng | 2 +- src/conf/schemas/domaincommon.rng | 124 +++++++++++++------------- src/conf/schemas/domainsnapshot.rng | 8 +- src/conf/schemas/network.rng | 2 +- src/conf/schemas/secret.rng | 2 +- src/conf/schemas/storagecommon.rng | 2 +- src/conf/schemas/storagepool.rng | 10 +-- src/conf/schemas/storagevol.rng | 6 +- 12 files changed, 89 insertions(+), 101 deletions(-) diff --git a/src/conf/schemas/basictypes.rng b/src/conf/schemas/basictypes.= rng index 2931e316b7..f0f4086ace 100644 --- a/src/conf/schemas/basictypes.rng +++ b/src/conf/schemas/basictypes.rng @@ -305,36 +305,24 @@ =20 - + - .+ + (/|[a-zA-Z]:\\).* =20 - + .+ =20 - - - (/|[a-zA-Z]:\\).+ - - - \[[^\]]+\] .+ =20 - - - /.* - - - ([bB]([yY][tT][eE][sS]?)?)|([kKmMgGtTpPeE]([= iI]?[bB])?) diff --git a/src/conf/schemas/capability.rng b/src/conf/schemas/capability.= rng index a1606941e7..4fc8fd82b7 100644 --- a/src/conf/schemas/capability.rng +++ b/src/conf/schemas/capability.rng @@ -378,13 +378,13 @@ =20 - + =20 - + =20 diff --git a/src/conf/schemas/domainbackup.rng b/src/conf/schemas/domainbac= kup.rng index 91cf2a7bbd..9d6571f90f 100644 --- a/src/conf/schemas/domainbackup.rng +++ b/src/conf/schemas/domainbackup.rng @@ -87,7 +87,7 @@ unix - + @@ -185,7 +185,7 @@ - + @@ -209,7 +209,7 @@ - + @@ -267,7 +267,7 @@ - + @@ -290,7 +290,7 @@ - + diff --git a/src/conf/schemas/domaincaps.rng b/src/conf/schemas/domaincaps.= rng index 595dbcd634..3afc282a2f 100644 --- a/src/conf/schemas/domaincaps.rng +++ b/src/conf/schemas/domaincaps.rng @@ -13,7 +13,7 @@ - + diff --git a/src/conf/schemas/domaincheckpoint.rng b/src/conf/schemas/domai= ncheckpoint.rng index 72c4186235..188954d19a 100644 --- a/src/conf/schemas/domaincheckpoint.rng +++ b/src/conf/schemas/domaincheckpoint.rng @@ -56,7 +56,7 @@ - + diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincom= mon.rng index 5597d5a66b..c333e3e1e2 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/conf/schemas/domaincommon.rng @@ -359,7 +359,7 @@ - + @@ -367,7 +367,7 @@ - + @@ -381,7 +381,7 @@ - + @@ -480,7 +480,7 @@ - + @@ -500,7 +500,7 @@ - + @@ -995,7 +995,7 @@ - + @@ -1322,7 +1322,7 @@ - + @@ -1535,17 +1535,17 @@ - + - + - + @@ -1560,7 +1560,7 @@ - + @@ -1892,7 +1892,7 @@ - + @@ -1925,7 +1925,7 @@ - + @@ -1956,7 +1956,7 @@ - + @@ -2000,7 +2000,7 @@ unix - + @@ -2048,7 +2048,7 @@ - + @@ -2243,7 +2243,7 @@ - + @@ -2256,10 +2256,10 @@ - + - + @@ -2495,7 +2495,7 @@ unix - + @@ -2510,7 +2510,7 @@ - + @@ -3165,7 +3165,7 @@ - + @@ -3182,7 +3182,7 @@ - + @@ -3207,12 +3207,12 @@ - + - + @@ -3236,7 +3236,7 @@ - + @@ -3341,7 +3341,7 @@ - + @@ -3495,7 +3495,7 @@ - + @@ -3857,7 +3857,7 @@ - + @@ -3865,7 +3865,7 @@ - + @@ -3900,17 +3900,17 @@ - + - + - + @@ -4195,7 +4195,7 @@ --> - + - + diff --git a/src/conf/schemas/domainsnapshot.rng b/src/conf/schemas/domains= napshot.rng index 2549c47b22..6fbf66da5c 100644 --- a/src/conf/schemas/domainsnapshot.rng +++ b/src/conf/schemas/domainsnapshot.rng @@ -46,7 +46,7 @@ - + @@ -143,7 +143,7 @@ - + @@ -171,7 +171,7 @@ - + @@ -201,7 +201,7 @@ - + diff --git a/src/conf/schemas/network.rng b/src/conf/schemas/network.rng index b7c8551fad..bc170a59b5 100644 --- a/src/conf/schemas/network.rng +++ b/src/conf/schemas/network.rng @@ -422,7 +422,7 @@ - <= /attribute> + diff --git a/src/conf/schemas/secret.rng b/src/conf/schemas/secret.rng index c90e2eb81f..66a66e1c7b 100644 --- a/src/conf/schemas/secret.rng +++ b/src/conf/schemas/secret.rng @@ -51,7 +51,7 @@ volume - + =20 diff --git a/src/conf/schemas/storagecommon.rng b/src/conf/schemas/storagec= ommon.rng index 14704c737e..04a913a776 100644 --- a/src/conf/schemas/storagecommon.rng +++ b/src/conf/schemas/storagecommon.rng @@ -82,7 +82,7 @@ unix - + diff --git a/src/conf/schemas/storagepool.rng b/src/conf/schemas/storagepoo= l.rng index 63a8b75fd8..ec25ac7c25 100644 --- a/src/conf/schemas/storagepool.rng +++ b/src/conf/schemas/storagepool.rng @@ -311,7 +311,7 @@ - + @@ -323,7 +323,7 @@ - + @@ -354,7 +354,7 @@ - + @@ -395,7 +395,7 @@ - + @@ -404,7 +404,7 @@ - + diff --git a/src/conf/schemas/storagevol.rng b/src/conf/schemas/storagevol.= rng index 3e0f482007..a372c7ab78 100644 --- a/src/conf/schemas/storagevol.rng +++ b/src/conf/schemas/storagevol.rng @@ -106,7 +106,7 @@ - + @@ -138,7 +138,7 @@ - + @@ -159,7 +159,7 @@ - + --=20 2.49.0