From nobody Tue Sep 9 23:41:31 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1748103528140240.73351563949916; Sat, 24 May 2025 09:18:48 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3844E1771; Sat, 24 May 2025 12:18:47 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id EC57A15BF; Sat, 24 May 2025 12:17:07 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 8499A1515; Sat, 24 May 2025 12:17:00 -0400 (EDT) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AD6091506 for ; Sat, 24 May 2025 12:16:59 -0400 (EDT) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-ad545e74f60so103681466b.2 for ; Sat, 24 May 2025 09:16:59 -0700 (PDT) Received: from tulp.my.domain (80-115-115-199.cable.dynamic.v4.ziggo.nl. [80.115.115.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad52d06e098sm1430294466b.59.2025.05.24.09.16.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 May 2025 09:16:57 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748103418; x=1748708218; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PCvmhw0pJUhCLWivSKViHOvZ+XgOTLFiyL9EQrpzHzI=; b=md1Jf3qIrCu+b6nuEvmKlTMHHhRU27cIXiaGJZ5IXlM8hU7ltAgktOfZRsItOFz5+G QXCuh4jo3bZrzNO9N51W6JzVsjudcXsQRyPprpeyOciYg24HkBQbXp7t/NpZ8vcHls95 14GPPrGkaOP2uLqHUfk3oqGNuXvqBjwe8ebGRj5FC7IYUC+2a2FKsn0GQloqvQtckId/ 7DmZfzq9Zeoamc+T58ciKAH8ZDa3kK2+VgknCtOXqCjwCj+Qg3jv2WtC6Pbx+Z+vwbBv OTmvaVEFEyYwTqXZvnaJha2ZAlIcxduXnZBH4oZECJn3UA6a0pqXndeNhm8DiNFiuOxu sYoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748103418; x=1748708218; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PCvmhw0pJUhCLWivSKViHOvZ+XgOTLFiyL9EQrpzHzI=; b=nlrz1qGkVOgCJT0s3zuF1dHyhwrM5fK4dXB+Q9+U+y+HtOUt3vSKs6ImLiP5Sh5oiu FvIjDHXZfj38IPALK9tiLXI9yWZYe18z0Z1ZyxQxsjxQt7DRsRPJefXFLg58q7//KX7u noTTS9xBN/e8VmINpgdHSZVTSFT32lJtgTMqpWv/nohqhsVxpZj4eTHldaejO/ntyDhC C0DT31/3wlPW53+OiGx2y2zxOQJFM9vx9iwBqDfuyVA+P5D/ylKEY5h27AZIpKjLV0MO JrGa4t9qxzoAoZ5QYbW+6cq8ZDXFk8cdHB22rSTsBDgVO8uyDFxT51QVzdZlpLj8UhPI Z7Kg== X-Gm-Message-State: AOJu0YyoeD9uv0AArGoze0ep8ohP4ABD2aB4+g8TA0y3SgZoDnkXVbK1 4iNEko1qNn8zyTnCRHIe+Y1OLWbfMgRZZRXAd1dL9QTxp7SfD7O0g6KKV1GLDUuQJkcdNg== X-Gm-Gg: ASbGncuKCxKakov78dxQBo1/BHfbOlvsztTgV6sAnrc24hYtlK9CHHNfVkcL5Uq6gpN WextHcOoVE01ezEXRvmKHHxBC/PmNlyst9olxBzkUi9KyFO5MTSCCRdZYU8N0Sh8qud8FD4JHjX AZs35e4a4RauSn+zcCYgElrEdrtgDuK2/hJH34MrQxKkjIJ1zyytZHXfeg2nepZoStUJ4Z71hs9 kpWpFHtVUpIwi+dTCdDi8TAbp5afnq/nTFHJ0XPAW7JAzVWtJNcMKaeP6npuH0TYfJrA6cSxV0D KskOAwdZLeYc5WyLMstzL1lZkpiiu4ZQSPB/kktXyJQvYRsLRlzKeNCcgk6IYJQyPpvYbcOp2cP DVp3VT6H4YOCqIbyw6oeUg9kG X-Google-Smtp-Source: AGHT+IEh4qgiik7GVMXQMic6fZRAvdgXWt2488/ITHcKnGeUqxNnBCua8MH2rq2lI/vah6jP0W6Saw== X-Received: by 2002:a17:906:1f4c:b0:ad2:1a63:3ba4 with SMTP id a640c23a62f3a-ad85b3071b1mr159455566b.37.1748103418004; Sat, 24 May 2025 09:16:58 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH v2 4/4] libxl: capabilities: report supported console types Date: Sat, 24 May 2025 18:15:49 +0200 Message-ID: <20250524161549.34995-5-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250524161549.34995-1-bogorodskiy@gmail.com> References: <20250524161549.34995-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: H2KLRC4DQHOQYFOTXB6OOGBXJIBGNPFY X-Message-ID-Hash: H2KLRC4DQHOQYFOTXB6OOGBXJIBGNPFY X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748103529786116600 Content-Type: text/plain; charset="utf-8" Extend domain capabilities with information about the supported console device types. Signed-off-by: Roman Bogorodskiy --- src/libxl/libxl_capabilities.c | 23 ++++++++++++++++++++++- tests/domaincapsdata/libxl-xenfv.xml | 13 +++++++++++++ tests/domaincapsdata/libxl-xenpv.xml | 13 +++++++++++++ 3 files changed, 48 insertions(+), 1 deletion(-) diff --git a/src/libxl/libxl_capabilities.c b/src/libxl/libxl_capabilities.c index 522256777d..6aca4075e7 100644 --- a/src/libxl/libxl_capabilities.c +++ b/src/libxl/libxl_capabilities.c @@ -628,6 +628,25 @@ libxlMakeDomainDeviceHostdevCaps(virDomainCapsDeviceHo= stdev *dev) return 0; } =20 +static int +libxlMakeDomainDeviceConsoleCaps(virDomainCapsDeviceConsole *console) +{ + console->supported =3D VIR_TRISTATE_BOOL_YES; + console->type.report =3D true; + VIR_DOMAIN_CAPS_ENUM_SET(console->type, + VIR_DOMAIN_CHR_TYPE_DEV, + VIR_DOMAIN_CHR_TYPE_FILE, + VIR_DOMAIN_CHR_TYPE_PIPE, + VIR_DOMAIN_CHR_TYPE_PTY, + VIR_DOMAIN_CHR_TYPE_STDIO, + VIR_DOMAIN_CHR_TYPE_TCP, + VIR_DOMAIN_CHR_TYPE_UDP, + VIR_DOMAIN_CHR_TYPE_UNIX, + VIR_DOMAIN_CHR_TYPE_VC); + + return 0; +} + virCaps * libxlMakeCapabilities(libxl_ctx *ctx) { @@ -672,6 +691,7 @@ libxlMakeDomainCapabilities(virDomainCaps *domCaps, virDomainCapsDeviceGraphics *graphics =3D &domCaps->graphics; virDomainCapsDeviceVideo *video =3D &domCaps->video; virDomainCapsDeviceHostdev *hostdev =3D &domCaps->hostdev; + virDomainCapsDeviceConsole *console =3D &domCaps->console; =20 if (STREQ(domCaps->machine, "xenfv")) domCaps->maxvcpus =3D HVM_MAX_VCPUS; @@ -681,7 +701,8 @@ libxlMakeDomainCapabilities(virDomainCaps *domCaps, if (libxlMakeDomainOSCaps(domCaps->machine, os, firmwares, nfirmwares)= < 0 || libxlMakeDomainDeviceDiskCaps(disk) < 0 || libxlMakeDomainDeviceGraphicsCaps(graphics) < 0 || - libxlMakeDomainDeviceVideoCaps(video) < 0) + libxlMakeDomainDeviceVideoCaps(video) < 0 || + libxlMakeDomainDeviceConsoleCaps(console)) return -1; if (STRNEQ(domCaps->machine, "xenpvh") && libxlMakeDomainDeviceHostdevCaps(hostdev) < 0) diff --git a/tests/domaincapsdata/libxl-xenfv.xml b/tests/domaincapsdata/li= bxl-xenfv.xml index c71d759517..45887c5fa3 100644 --- a/tests/domaincapsdata/libxl-xenfv.xml +++ b/tests/domaincapsdata/libxl-xenfv.xml @@ -70,6 +70,19 @@ xen + + + vc + pty + dev + file + pipe + stdio + udp + tcp + unix + + diff --git a/tests/domaincapsdata/libxl-xenpv.xml b/tests/domaincapsdata/li= bxl-xenpv.xml index 8ae2370b7e..50be0c5cec 100644 --- a/tests/domaincapsdata/libxl-xenpv.xml +++ b/tests/domaincapsdata/libxl-xenpv.xml @@ -60,6 +60,19 @@ xen + + + vc + pty + dev + file + pipe + stdio + udp + tcp + unix + + --=20 2.49.0