From nobody Mon Sep 8 21:37:47 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=fail (BodyHash is different from the expected one); dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747268398118886.1833986978369; Wed, 14 May 2025 17:19:58 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 79D631285; Wed, 14 May 2025 20:19:57 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 2FA161211; Wed, 14 May 2025 20:19:22 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id B28EC1187; Wed, 14 May 2025 20:19:18 -0400 (EDT) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2045.outbound.protection.outlook.com [40.107.94.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9155311E9 for ; Wed, 14 May 2025 20:18:54 -0400 (EDT) Received: from MW6PR12MB8897.namprd12.prod.outlook.com (2603:10b6:303:24a::19) by DS7PR12MB5814.namprd12.prod.outlook.com (2603:10b6:8:76::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.29; Thu, 15 May 2025 00:18:47 +0000 Received: from MW6PR12MB8897.namprd12.prod.outlook.com ([fe80::7c55:5a45:be80:e971]) by MW6PR12MB8897.namprd12.prod.outlook.com ([fe80::7c55:5a45:be80:e971%4]) with mapi id 15.20.8722.021; Thu, 15 May 2025 00:18:47 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, FORGED_SPF_HELO,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.4 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WYZbekWBwyAsC48PEzW5muqJFIU0uY6e7KcZEsW4ORH8PgWkIvKe/Kuy1r/XuIFVQLf31xczBCQF9U3SBJGYetwIvcB24iW1CgVIbZ3aCXt/KU1DktZ5CAUa0icW1RwvelHxI/bUtC/wVoAuKMXcvge9KCfK/YfrQtRquMEE03idTg+36NxRrfuMJJnI6fh4mS0zZ0JLDfZgxMpJZDdPglJNVcDUiv4/n1rBNiSe2fnn91O8L2yGgm7rEICbqRJ9wHFQLOaLTAJHLdHjPvCl19NOzdFLdFhWZ/pNI0D86o/y/G+cbD3VkZGiuffz0r0u+kvC3knGZ2e0T+6TzanSnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xOG8B3yTJmKHmMlrmU0CsLuuseRsqvFA3OX3GfaX1Tc=; b=d68Okys6uNFQmgWWySfFitCK3uHhEPOEaZ2eX1r2W/8bFdmuWkyVIqBE9qGfm/E9zvlVds5HywieLn8ssVJ+jZoWKm33+7Hj5Y+9PYzRnD71oie/DpDN+Ncq3KYpzDS4AOCnllxR+iEG4XIg3aV14oFdNgq5kH1GSHNqyJIKmCSgs16q0NmCrUYtAhbKZ6uQxw6P+lQvP4vtgenMno3ZybjMdmPgla2gJwBQS6haAIDEQ2Aq/nMLKQ8idYdsM/fzZEBuM1qhJZj/jYIz91T/hDvcY/IET/iT1PKGd9KcdW59YHAVrShALL4wvc//h/MH8fEF36Yjd2qMevuuGNtb1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xOG8B3yTJmKHmMlrmU0CsLuuseRsqvFA3OX3GfaX1Tc=; b=WAikZlm/WjL+vYuz80x5xpjK+XWO34PMyfi380MZBTDIzx1pYAIXVRoyDp4p17njsQZsHrlidIP7igmdUtVP2Gy3DImzmpK0jbhkEHmU312kdNZ6fiiyAPrfIGFV01vfU+YcpfCgQPT+Ai6w4p/5yj4HoKDnxUPEeruqByYZoSf7gTOIULesjEDC1HiaFYYRjNSTlG1/JcMskkOBbWhFhDlUmj3VuTNi+OfLd9kaypVPApxHVzVLZDeVoqmyyl6xkO+sA3uHBSEaXCRknVEfoI3rd6cUGSwQWI/K3bQXjG7asK+MUU0AbuhK6wQGa5k0agNtYvrvCHlNIlhn3qyI1Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; To: devel@lists.libvirt.org Cc: berrange@redhat.com Subject: [PATCH v2 1/3] qemu: Add capability for PCI high memory MMIO size Date: Wed, 14 May 2025 17:18:45 -0700 Message-ID: <20250515001846.2227420-1-mochs@nvidia.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20250515001814.2227195-1-mochs@nvidia.com> References: <20250515001814.2227195-1-mochs@nvidia.com> X-NVConfidentiality: public X-ClientProxiedBy: BYAPR06CA0016.namprd06.prod.outlook.com (2603:10b6:a03:d4::29) To MW6PR12MB8897.namprd12.prod.outlook.com (2603:10b6:303:24a::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW6PR12MB8897:EE_|DS7PR12MB5814:EE_ X-MS-Office365-Filtering-Correlation-Id: 5633ef25-b413-4c98-4071-08dd93460f2b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?yo4CuAB+xwz5jXpKEi/fTVj2wuisrvKV6mNGSQCVUTGGV4eOjyOU69GL8DZb?= =?us-ascii?Q?PUvgHnPmzjwYXWn4YHeKoplblUQJGRkPr02sxqVsX/97kYBaiaOGKMsjWyxf?= =?us-ascii?Q?hQqx76Y4mia6mfAuY88M58jw8jU0IIRBk4UnIZbwt2mFZdaTvL/38pjE6jFC?= =?us-ascii?Q?1SGEj/+UG98vwEA627M5gJO4tMFiuJBrjEG3PJevarLxHZcIXNke9/UbtKl9?= =?us-ascii?Q?gQQgykbd7Q2X0osalLejAv7/CynYNwV3pcvaCoKEE+/WERh4iNa01v+BWH73?= =?us-ascii?Q?0epipDA6wyD9TFmOCOyG/2gKUm7D1VPfiaMV/bdTx5J/7e6g0e79FkAmnV1h?= =?us-ascii?Q?gW4ARjUpm9F14YGjZHXunoHlDFB1by8MZJEoBcbUbu574N1vkNmyO34sBa7M?= =?us-ascii?Q?M7RHDJMvKPpTeffc1zOjlIG1LoB1TG0HHSpr03Tc+7+F9Is3kfkFQ7TSRVrG?= =?us-ascii?Q?jy9BYFv5SSrUA22vLK3ufoGvQRPD/5jhk/xenRPHuN4Yd6vzVKkC/sGB1ptA?= =?us-ascii?Q?WsD+SmXXy7QhP7IgDAy1WByo9e3a4t1grDJuenbkLLj61y+Vs1R0ltwQJOcT?= =?us-ascii?Q?MvpAj1lv1vAeEpLi82PvMBr1R1uI5M9wePiCSxe74HznNdmETdyRrhgLyOKr?= =?us-ascii?Q?33I5znI0uZjWixOcWsHsp3T7Wmk3TDx8eJqjYyIFk2txylVH+PPVuloW/EU7?= =?us-ascii?Q?PPkSiZuJwtvMkMEhzkeTiFfPyWyzHXXz9KeaqKU9kr1rpBBqRTVR4JqKUCv2?= =?us-ascii?Q?DPoI29V64FPkK4Zp7yHv4Z9ZzSsLktwUhgHGAV2B3N3pvvg/jxKWcCc9azfR?= =?us-ascii?Q?3w2SLG4+0nrAs4XpKamcdeuKVHsYT+4NB0fAuNx5KitVAseFnfegIJAobkT3?= =?us-ascii?Q?APJYdqJ8SKzfYfVL31WH2psca+IQl6g1CmGEbD9yctx6hGnWO9dElqsZZcHm?= =?us-ascii?Q?OqBqFdjMfWk6qFKoDvFcY/Vo4YIf9JqivB1dQ6qG5VOQdgWVAjpIpDe58dTZ?= =?us-ascii?Q?isn7w67U3AfptyWF0LwrirWaf/HNGxNeTh7uQO/aA4IaJHrbYWwyeek6nDD4?= =?us-ascii?Q?JuJlwva2kmFS5/B5+moGikzeMxM5GBwBxWkssURXG/Vc+b1drGUWidfn9c1l?= =?us-ascii?Q?vByt0VkOTJ6nvnpC/8jANyo16svJoI5sJGsxJNUSvoSD6FIIQvm0xw1mpGNx?= =?us-ascii?Q?IAjsImCWjhdsMGUn2AiOdEPSBOfK6WNNSbfvvVCLCf4h4/bWEJf7BNsYezLZ?= =?us-ascii?Q?6Z7vLrRuZyJG/MCJp778c+66XidCpFu/4MQ10nAqfj41m6TQ8XakHDgPJAqJ?= =?us-ascii?Q?dqUoGIHxUwZXqb56Kvu5PmV4+G+L+JWpIvR+yTijEBy8HHOSGC7IXMuGc5dO?= =?us-ascii?Q?gLi77vgI7JcttQ5/PNckaWlJxB7ajdLP+hMA2J6SGgbjz95RyeL5c6Wq8dXq?= =?us-ascii?Q?p3Iu5mF3Q3s=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW6PR12MB8897.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aQMNQ7FZrBtQsNE8ueuSsYfFjWVVlUfovA6S2zN8Yfb0F3FU/goV1DBtB78o?= =?us-ascii?Q?kknaNHBuJnGdZvJAPBJavAcQX8muQwaRMHl7MqqfFuOP/O1uRAatxyFpUnML?= =?us-ascii?Q?aFdjwX5ZJVRPgn6mKYKON142Q+dPKlpGMQ9FhAgGF0eia6nl3POBVIrS2lKl?= =?us-ascii?Q?xFHAG/q6ea9Yi+yhlEKJNACp74zBXNOevNpaPE9ibijU9x67HtlID9elf/kV?= =?us-ascii?Q?jy6UhnZ3y37tfzNOT4PbpXgWwOuRcCVMURSK0F3Xx45/JgFY3P0dWPgYpD95?= =?us-ascii?Q?vcJTFod0GhCJ38veNgQUDCDwYjiOb77JrLGHHUkDVcU8ictSPWX6qMaMsLNq?= =?us-ascii?Q?JqR6aQv0BHDGmcM6ROS/Qpq6I6mpHGgxDJYYWBfJXWrN5ZFVSw6q5YwQ9MS2?= =?us-ascii?Q?4P9fK+TjAdkGkj8wLzRYC036Er4l6a+Vn3x/C9RM4cpm6IkcRmTVTVhjUArt?= =?us-ascii?Q?0tuE41ll0Z5t9gnJFMC4KOLsYWuB3XOGFzzHos3PIsgyRCli3sekiY9ENxWk?= =?us-ascii?Q?M64BXUuU678PICG8XyNzPS1zojHuruoKdPjJzb4jDjg1jzxkP6Rtyo1H4Fbm?= =?us-ascii?Q?R9Bryz55ZgvKLJaFwJlMlSyZ1DVHbIiCYY5tWoie1wIEPLadRE+SdQeD1YLs?= =?us-ascii?Q?OnlFCTyfvvnCnUhIwIDwKWiWAvxS+3NszkVOyiN72yjzDQQyL6d4e0LXL9T7?= =?us-ascii?Q?fAOmbMWZN/eIzndpg7zxYvMcjUbJfNpxEQqxrAqNuo65hmWLabeIBR/NNAfC?= =?us-ascii?Q?bS1itHrMaa0cI2z5Cl5zvwR9st0LfESt1Wy04V1yQuO6vEJoKme3nW3H1GyA?= =?us-ascii?Q?eGVl1L1rLHpWSgN1tjrPBcvn1amLYlS0vWwvS8M5UgKWlSOnqai8/5EtiDge?= =?us-ascii?Q?QIcRZrlsh++SJtetIZgX1fbw2Ks+KmxjSKBroVQrzxdtEalVll99ctqkhUlx?= =?us-ascii?Q?S8l0MUSsd5Ij/ndWKlwTOe3RNJXW9WANFgsid3eFlI6giNaufLytm+eGLZ0T?= =?us-ascii?Q?ut2NHuMCY3rQY5zLpcXLKbVP4CicvIDbh1KpKoH9VePBJrgjogpeTYUbASn8?= =?us-ascii?Q?Ogoorbp97H2YbkhAWLnfAvRol6wV6eLDnqFqJmCS9zNGMvkeM3kFrRmcKcSy?= =?us-ascii?Q?pao/xVkQ+QGjHsAyWMPCXNOGRvF+cGZsov9WVyQg4JxJ8DDDzkPmXS9PmQxM?= =?us-ascii?Q?DoRbUZHMkXcgVqF2UyRzjO5jL0LKnatdAp3zRFh6ZaqgPj6ynbia8pEesxMT?= =?us-ascii?Q?EU7ShUz8oyAj4oIhrzKUNc6va86L9C94xNXaMdX+Be1WaeUQQELcxOfM3snQ?= =?us-ascii?Q?DP1JuWZHNiB53D6Gphb9bWWhvFrSWm2KmGmD048rZN9z4iAZucvGxvQD+tSB?= =?us-ascii?Q?+SgHmSaStQGv9jx2V5BQYgUXt2TzzJbiVjrheQJFOTfS2znXmWLMP+Ta+45u?= =?us-ascii?Q?vdcCeP/BJfgVaBbbnoSwemC1u14DoyqXCrIGNZ8xTXCiyioba7wDoWDBfB0y?= =?us-ascii?Q?lcUSPIz82yGgR+JdnRut3jDmOC5E4GoyAJfHocSGe5bjlFd1nWdZL3ZvGEb6?= =?us-ascii?Q?UGcvxD9zR6q7u1wzKR/dXRDhMHOGlGZrd9v2EJgU?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5633ef25-b413-4c98-4071-08dd93460f2b X-MS-Exchange-CrossTenant-AuthSource: MW6PR12MB8897.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2025 00:18:46.9772 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hpcjsr3ezY/Zy7nctJ2ZEK+8WNd94HwExlPc7TMcvbhjIXJl6fCwfk6NspuoFNfKadN8RoL0KBSblD8OO2LPWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5814 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: PRARM6R3LG54TLIF6DFNA36EYGK53ACX X-Message-ID-Hash: PRARM6R3LG54TLIF6DFNA36EYGK53ACX X-MailFrom: mochs@nvidia.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: "Matthew R. Ochs via Devel" Reply-To: "Matthew R. Ochs" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747268399451019000 Content-Type: text/plain; charset="utf-8" Add QEMU capability for PCI high memory MMIO size configuration: - Add QEMU_CAPS_MACHINE_VIRT_HIGHMEM_MMIO_SIZE capability - Add capability to virt machine properties - Add highmem-mmio-size virt machine property to aarch64 qemu 10.0.0 capabilities This allows detecting support for the highmem-mmio-size virt machine property in QEMU. Signed-off-by: Matthew R. Ochs Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_10.0.0_aarch64.xml | 1 + 3 files changed, 4 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index c24584bf75fd..b600dd38b8fc 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -732,6 +732,7 @@ VIR_ENUM_IMPL(virQEMUCaps, =20 /* 475 */ "virtio-scsi.iothread-mapping", /* QEMU_CAPS_VIRTIO_SCSI_IOT= HREAD_MAPPING */ + "machine.virt.highmem-mmio-size", /* QEMU_CAPS_MACHINE_VIRT_= HIGHMEM_MMIO_SIZE */ ); =20 =20 @@ -1771,6 +1772,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsMachi= nePropsVirt[] =3D { { "iommu", QEMU_CAPS_MACHINE_VIRT_IOMMU }, { "ras", QEMU_CAPS_MACHINE_VIRT_RAS }, { "aia", QEMU_CAPS_MACHINE_VIRT_AIA }, + { "highmem-mmio-size", QEMU_CAPS_MACHINE_VIRT_HIGHMEM_MMIO_SIZE }, }; =20 static struct virQEMUCapsStringFlags virQEMUCapsMachinePropsGeneric[] =3D { diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index 40aa7acef42e..df33212a348a 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -713,6 +713,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for = syntax-check */ =20 /* 475 */ QEMU_CAPS_VIRTIO_SCSI_IOTHREAD_MAPPING, /* virtio-scsi supports per-vi= rtqueue iothread mapping */ + QEMU_CAPS_MACHINE_VIRT_HIGHMEM_MMIO_SIZE, /* -machine virt,highmem-mmi= o-size=3D */ =20 QEMU_CAPS_LAST /* this must always be the last item */ } virQEMUCapsFlags; diff --git a/tests/qemucapabilitiesdata/caps_10.0.0_aarch64.xml b/tests/qem= ucapabilitiesdata/caps_10.0.0_aarch64.xml index e14e926c290d..7fd50185575a 100644 --- a/tests/qemucapabilitiesdata/caps_10.0.0_aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_10.0.0_aarch64.xml @@ -160,6 +160,7 @@ + 10000000 61700285 v10.0.0 --=20 2.46.0 From nobody Mon Sep 8 21:37:47 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=fail (BodyHash is different from the expected one); dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747268421950212.77826647173197; Wed, 14 May 2025 17:20:21 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 5422D1126; Wed, 14 May 2025 20:20:21 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id EBDA012B4; Wed, 14 May 2025 20:19:24 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id C1C4610F2; Wed, 14 May 2025 20:19:21 -0400 (EDT) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2045.outbound.protection.outlook.com [40.107.94.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id CA83F1126 for ; Wed, 14 May 2025 20:18:54 -0400 (EDT) Received: from MW6PR12MB8897.namprd12.prod.outlook.com (2603:10b6:303:24a::19) by DS7PR12MB5814.namprd12.prod.outlook.com (2603:10b6:8:76::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.29; Thu, 15 May 2025 00:18:51 +0000 Received: from MW6PR12MB8897.namprd12.prod.outlook.com ([fe80::7c55:5a45:be80:e971]) by MW6PR12MB8897.namprd12.prod.outlook.com ([fe80::7c55:5a45:be80:e971%4]) with mapi id 15.20.8722.021; Thu, 15 May 2025 00:18:51 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, FORGED_SPF_HELO,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.4 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k7XTi9nnzzNFGsNSe6PGjQODUOdCmTlnKY8js6H/8St0OzNldWVw+4N96unI8ZVQOtGSDmmEmkeyRLERQnmkSgV+2uwsNMdGdKiiKphURUbtyKnjbSfF1oHPOLWlzQ6Q37qTvccx5NIvPmgPhB228GwwgKEPNlHv4gYvComu+HZzN0ZZfCqlQpX9vsjl5I9uTh9wIfLvCbBoAbSH4MLMb8kKuTDAxsxkJaYuEnUecKBYj6AdKUFyC6L1gu5ow9jUCp+6Nf6A53hrmkvxQUcR/a4StMROzPfcnmVaUIyP3tvuDaVDOlx35QnGdzmn8gWZfh9cTJTZmGum6bipjJC9Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8RBj52Xs1KXPqdnjvU/mRNpN+SKzQMR6lgO7gSzB0Jk=; b=ke5Zt2YDbsRooQTxKV/tMcFPPHpoH8VdHA083xcRgSl/2PYyvzbyVmbr6VCPdwyDuziQiKLIz2rUeLqDHLyRTPD+8d7qCPLNVeo39CSy8aY1xyabcpE50ED9WWXpv5Oiuq3pWfCObJMFnH/SlSNP+zzztlQzICfl0i9a5ocCARMJNiTuaxouRJV9mu/BA0LTPBO6CPbBdRtKy9E3JiruQDAKCFdEcxIzTLgeBohLtZXY0o5lEhfbLGiewdyLuqSjD3KmFep3oFe3hF08IYhqdwZEf9YB1baKOwQyJ3S5YXFXY5HU33JlAIYbK3JSKjzEMuoubSa/6f56o1kty4PBuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8RBj52Xs1KXPqdnjvU/mRNpN+SKzQMR6lgO7gSzB0Jk=; b=pL/VMdLGBbeLvf3YrOfJkjVpRmG2cPH/Be6tgMblAJPI0iqK+n3oy89gHTANDAR90Y3uaYheDqIe7F4GRPagVSP+cJBLk02wpSxglAk7Yt0w1KuHVxVBHtpSM7dHt/jtgX4UGDecBwc4SN1EtPv0/lricFccbwNnvCfRB6MOTejc406WO+16FCo+8cW1u2kFOHl1F7ufhoBIojk5rgZS5YbXVH6VtysINIvjpAAsMugNxWxXTRl/n14WdtxFTGOYJV3GIYDFF8riVP0Z+F3PT3CtUSWEr0O3VaqStvINH6nYQNjBJxsxLa7WPz7OChVUJFOlLdfqiwLByGt0ZR2v9A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; To: devel@lists.libvirt.org Cc: berrange@redhat.com Subject: [PATCH v2 2/3] qemu: Add command line support for PCI high memory MMIO size Date: Wed, 14 May 2025 17:18:50 -0700 Message-ID: <20250515001850.2227536-1-mochs@nvidia.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20250515001814.2227195-1-mochs@nvidia.com> References: <20250515001814.2227195-1-mochs@nvidia.com> X-NVConfidentiality: public X-ClientProxiedBy: BY5PR04CA0003.namprd04.prod.outlook.com (2603:10b6:a03:1d0::13) To MW6PR12MB8897.namprd12.prod.outlook.com (2603:10b6:303:24a::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW6PR12MB8897:EE_|DS7PR12MB5814:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f65980e-d7eb-40dc-0c01-08dd934611b3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?XDr1WOkx5DFabwb7CrNJQwATBiQHL3jMQvl+UtHsjkZrBsg0gbGAuEgl/vP0?= =?us-ascii?Q?HBmh/kRZxlI4cHtc1/XtwCbu4S+sYPMw3ttxsa+0LEKEUuNv+S3IbWKljoYF?= =?us-ascii?Q?xK5CKCq0QLJho8yYSKjXruWyIuJrBaAlLXYpm0bOm2qu9LkdBhV6MB8efs8s?= =?us-ascii?Q?Ocb23vLV2wI953xvNuXBYExCwMAY/MprJvKmZuLH+gK7QoogEl0xp2ZQRI1y?= =?us-ascii?Q?g0sHrYOBRD5NCKWSWCgV6KdsVGwA9M1bGT6IdfHfX++I/CFsVLSUnG5/mO2y?= =?us-ascii?Q?YGChEhtkvMphCLkdIkOojIGB3jGu94mfoeCaZgVMwmHN3gHtqnvX1XoFkqya?= =?us-ascii?Q?flfYw+tRivN92WfCauIyBClB1+X3eTlIg9nwdcH5YSz8CwlvSF8W28xtPhEl?= =?us-ascii?Q?Fey9jaGhAbarv7bVhk1nWClNH8C8igG9hH9jc4hY8pIyNAsMfpWmVINQiwj8?= =?us-ascii?Q?eV/7XSgBKTnV5p/LfGHWM9AG6qJFh7bKl0YIttPZZ/M5xvGp/HUKjWDwnWNd?= =?us-ascii?Q?muQaQnM6UbVtOc3+/D6WpR/gW5TYWK7qGpdtAz/b74CVIipa2ic9HQas7oqc?= =?us-ascii?Q?baRJQdQoGKSTFo+p9/jKUAJopScXibek+/4YEtSd0W/NKmRy2ss2r0em4Bmb?= =?us-ascii?Q?nt6UYgjpHc4Q6kCIkISg2OFT1as9pa/tbiJwg1mUeQT/8NGr5jKb/9l5ecbc?= =?us-ascii?Q?Zlc6Zx1/GXTGo2aj4wrDLnIG+FrVF6K6PPkLj56sx+Fta1yclgTkNt/FgiYX?= =?us-ascii?Q?6wl3AJbWRchIOZ1MlKwPl6P+gU1xjOW+oGep9aeN7MSqMQtiZWUo9TLEzDYa?= =?us-ascii?Q?BKJlTfpY2R+K09/2nkEG3JiQ5fpAKgntXXeLKmjXOkw6aqipzOLhUr6N+cCy?= =?us-ascii?Q?2R/lpBTkH3816Wz06Wqy6AwYSk/sp1vcUd7P0ypvkTOhxwOSPWqcp+OrPkHa?= =?us-ascii?Q?z8soJ/NAsOpEzt2Ysla6snqZDqk3o2nopQwTQmi6RWuuQjuuFRk/v2wltLT4?= =?us-ascii?Q?zBldFAjSEg/MegdxTNvpcIrjazFt32zAt9ClVrwDJ8iZWnsEk3APTS1nWakL?= =?us-ascii?Q?TKvRmRP/bWeGMohfe+0IJQqD1arH0+uh6siK2yo4NbbtXEu3nGO0Mf2md+5I?= =?us-ascii?Q?IRvGpnAP+uSFSVjYumrGqF8r6mNQI8hUCcawDT2OHFUdBtG9FTstpRiL5/Bg?= =?us-ascii?Q?fRU8UOx5Ey1D9X4t/D5rw9u7Vxlbdi36JLMNjX2qWUCF5iNjXguILFECFe4j?= =?us-ascii?Q?yUUPTbwWrmJVc6fhJfsBhcA/s7gHoH5lzTCDJi/PviKQdsryAGXA0Gaq04ni?= =?us-ascii?Q?mOLOZCsxpavdHjXljbi6LMa0wYXGHjK7I0WUpPzA0anXR9cONwKuWDiAP2Rh?= =?us-ascii?Q?Alw7ElxBMMl6h0vEFq56N+og8AfKlxHjYmtTppaJUyEQDEBimPfC8sRPdcCv?= =?us-ascii?Q?dbl4FkIfN/I=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW6PR12MB8897.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m5YdjocnIBpIUP6HBUNKirFY4VP3AUeNg2oKezoD9IjrPWoFeaXQ2ni4svYK?= =?us-ascii?Q?MUdVGmJCTp0tKE88xhhmPelteMWInoafvpCMou8Ggb5o3bV32CBIwAKfmpMm?= =?us-ascii?Q?l7kBhSxeLX8DTY1yodTl7f5WBo6wnZ2eumYEjlp/9FbdvGXIzqhnAqMmGblk?= =?us-ascii?Q?NJuxtlT1bNU9r5a9fJ+IeyaKsWJz/tZ6ceLeyUuDfJh15/pa+2xNlp5bqYoj?= =?us-ascii?Q?X/Aduh0cmABkjLm/dr32d8ul8N2l4yppO/R76oMi+c0sp8i4N9BrsdQ5zvGu?= =?us-ascii?Q?sYVVK9G4hGFkdjQS3Yh687HMsMDq9CXzBZFIsNG0gWsLzGXGJBHMEwExHTo5?= =?us-ascii?Q?jf/7pAYBGLspr3aqA4immgiDBu3xqaenj9eB2aQcCzHifR7eaX7H9Y9vwAif?= =?us-ascii?Q?qi8wcTFc4kKCXlsLlhs5fuHVGCGh6gj4qnRxO9D5xniRLINo0BsRmtQKP1ZL?= =?us-ascii?Q?qRHVW9vNXKDKsGCK4g6Ft2i/TCjnDXZzos5sWp2Kcs+fL0WXylCiIufpTdj6?= =?us-ascii?Q?4LylnbyAj428s4IEpbu+3WAvQWmIFy18NSqj4VdozspWA17RgRFLrjIAZCF4?= =?us-ascii?Q?bB3tvLLWz5KIgYTsKwsdO6Iz4YCYI6NyWyf2bxvPuBtsTjU0HaA59udLDwFG?= =?us-ascii?Q?KN9DlHUMgCqMjoT39RCsXPMrSbfBwC/Lr8En29mxpqoWXNT22011qd6JuADJ?= =?us-ascii?Q?1X6SxsK7Kq7rFzoekpXqa9XvQkXBoadYGCEqCa4kAvK3JDCbVsSSkrztlt81?= =?us-ascii?Q?DDa79oOGqssU8qX4bdVFi5VK8NgLCVgzIY1p5e8qAcpPtNngADDXZVJLhgjO?= =?us-ascii?Q?85o/zbD/BoiO+RFDJwsRPw3BV82QJaXd50sgO9zUZjRuFp+2kF/IsJ9DKfOO?= =?us-ascii?Q?emfUMjyD0qkY77r1Nw0jbQ+SM0AFOlI6oONuH1tLZrDaWl6N2JgP9Tzn9dAL?= =?us-ascii?Q?gseO1Awea5KzbDifysDOMzUMMZeBPSiisyRfBykt1cUMpJLziC4eD/jODB9D?= =?us-ascii?Q?YMUWD0WYBzOo60E5P3rWI4M36xloC04r+PstOS6I2QxEbNTWVgfRCjz3PRDK?= =?us-ascii?Q?ZsbKYTzu6AzngLR3kC04etiY79v0U/lGVyOgbC6RFuMyc83dhiO9Pp7AuDAb?= =?us-ascii?Q?6ozgDk3sN+9KOpSfoFE3cTCQvG8n2ofcwaW6CYTkpWg/bZGsuKXPPtFtXiEE?= =?us-ascii?Q?pUnj/XuAEctEEzxWC35GF/RSgmnbM6Z8M7IAedVmTbrYltFrH+7HsxE934eE?= =?us-ascii?Q?m+6RMIPimbPQ9DZboJQYEMVbiy9Da7lnd6WWegELZxKuw21JbCiP9pelwliB?= =?us-ascii?Q?6adg14DTZcsb1JXpmgrD454AYFkzrsW9Wc0HZmFIlymbsyULCMgA9A8CDKwl?= =?us-ascii?Q?t+NEkEXUgM5GJuv3QDnPNqG+XeCCNLD/EyyivlpZitDsQg+heuTmFMsIWx5n?= =?us-ascii?Q?MBPO13GYXFb3JSTJLf5TBiuxrqZ+UjYl0ww6x/M8W28B1lcRixHf4f9D/Cn4?= =?us-ascii?Q?6icjdKRV27p/4zFmwmTMXSHw+9Ppi45DgYtCVNb2D5ycH/zUjOvUcgHfZabE?= =?us-ascii?Q?wAYq5/LYnbothIrHJakY2FRAbHVNUS73ZMRqVZ4z?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f65980e-d7eb-40dc-0c01-08dd934611b3 X-MS-Exchange-CrossTenant-AuthSource: MW6PR12MB8897.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2025 00:18:51.1741 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qc8QXzwuXALw00ACIeaQeuYM3BiW05i8Mys7ySamsW1tNe1b/FNR2IR04+DUxm6HRKWua5QWLgQPxeqUps8hLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5814 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: LRQPJ2GLFULHZ2KKBAQTIQ2CAN3TIQ5P X-Message-ID-Hash: LRQPJ2GLFULHZ2KKBAQTIQ2CAN3TIQ5P X-MailFrom: mochs@nvidia.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: "Matthew R. Ochs via Devel" Reply-To: "Matthew R. Ochs" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747268423431019000 Content-Type: text/plain; charset="utf-8" Add support for generating QEMU command line with PCI high memory MMIO size: - Add highmem-mmio-size to machine command line generation using size conveyed through pcihole64 - Add validation for aarch64/virt machine type requirement - Add capability check for QEMU support This enables configuring the PCI high memory MMIO window size for aarch64 virt machine types using the existing pcihole64 element. Signed-off-by: Matthew R. Ochs --- src/qemu/qemu_command.c | 14 +++++++++++++- src/qemu/qemu_validate.c | 8 ++++++-- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index e6d308534f87..1386b2772a55 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6195,7 +6195,8 @@ qemuBuildGlobalControllerCommandLine(virCommand *cmd, for (i =3D 0; i < def->ncontrollers; i++) { virDomainControllerDef *cont =3D def->controllers[i]; if (cont->type =3D=3D VIR_DOMAIN_CONTROLLER_TYPE_PCI && - cont->opts.pciopts.pcihole64) { + cont->opts.pciopts.pcihole64 && + !qemuDomainIsARMVirt(def)) { const char *hoststr =3D NULL; =20 switch (cont->model) { @@ -7112,6 +7113,17 @@ qemuBuildMachineCommandLine(virCommand *cmd, =20 qemuBuildMachineACPI(&buf, def, qemuCaps); =20 + if (qemuDomainIsARMVirt(def)) { + for (i =3D 0; i < def->ncontrollers; i++) { + virDomainControllerDef *cont =3D def->controllers[i]; + if (cont->type =3D=3D VIR_DOMAIN_CONTROLLER_TYPE_PCI && + cont->opts.pciopts.pcihole64) { + virBufferAsprintf(&buf, ",highmem-mmio-size=3D%lluK", cont= ->opts.pciopts.pcihole64size); + break; + } + } + } + virCommandAddArgBuffer(cmd, &buf); =20 return 0; diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index b2c3c9e2f631..f808aac1063a 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -4074,7 +4074,9 @@ qemuValidateDomainDeviceDefControllerPCI(const virDom= ainControllerDef *cont, switch ((virDomainControllerModelPCI) cont->model) { case VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROOT: if (pciopts->pcihole64 || pciopts->pcihole64size !=3D 0) { - if (!qemuDomainIsI440FX(def)) { + if (!qemuDomainIsI440FX(def) && + !(qemuDomainIsARMVirt(def) && virQEMUCapsGet(qemuCaps, + QEMU_CAPS_MAC= HINE_VIRT_HIGHMEM_MMIO_SIZE))) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Setting the 64-bit PCI hole size is not = supported for machine '%1$s'"), def->os.machine); @@ -4085,7 +4087,9 @@ qemuValidateDomainDeviceDefControllerPCI(const virDom= ainControllerDef *cont, =20 case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_ROOT: if (pciopts->pcihole64 || pciopts->pcihole64size !=3D 0) { - if (!qemuDomainIsQ35(def)) { + if (!qemuDomainIsQ35(def) && + !(qemuDomainIsARMVirt(def) && virQEMUCapsGet(qemuCaps, + QEMU_CAPS_MAC= HINE_VIRT_HIGHMEM_MMIO_SIZE))) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Setting the 64-bit PCI hole size is not = supported for machine '%1$s'"), def->os.machine); --=20 2.46.0 From nobody Mon Sep 8 21:37:47 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=fail (BodyHash is different from the expected one); dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747268445119370.4773524004638; Wed, 14 May 2025 17:20:45 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 8366911CE; Wed, 14 May 2025 20:20:44 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 45D6012BB; Wed, 14 May 2025 20:19:27 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 828B6121D; Wed, 14 May 2025 20:19:22 -0400 (EDT) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2086.outbound.protection.outlook.com [40.107.94.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4244B1224 for ; Wed, 14 May 2025 20:18:59 -0400 (EDT) Received: from MW6PR12MB8897.namprd12.prod.outlook.com (2603:10b6:303:24a::19) by DS7PR12MB5814.namprd12.prod.outlook.com (2603:10b6:8:76::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.29; Thu, 15 May 2025 00:18:55 +0000 Received: from MW6PR12MB8897.namprd12.prod.outlook.com ([fe80::7c55:5a45:be80:e971]) by MW6PR12MB8897.namprd12.prod.outlook.com ([fe80::7c55:5a45:be80:e971%4]) with mapi id 15.20.8722.021; Thu, 15 May 2025 00:18:55 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, FORGED_SPF_HELO,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.4 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=W8qUQAAzWG0tpogTv516VUsrULXnOkJnqxTXT/TsjI0RoDiL099Umea/+TtNk1Kh+8QjzSp79yimupvPWce+7NGXZFV5zpj8BdciBOMycnCdEw4EwiMldP7pH4zYX7tSO0q6HA8xTdfRZrCa/Z1WfhZI099jKEu+FjH1WtD/uKT/3r3R+FvM/6mJLEiDLALpKz6av7b9uxoZcIA8iA9vufAu9AREQgno3uWtJqbmSNGD2e1jqxLn3X83Yn1jsYnRdZAs2kNYvFz6gis7dgIXkHhDryJ3edMAfoOUMXhXManN4jRFqZ6XImzALjE8gDzB3jPGPirTdl8gG1DtBxwRjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+JyacLhU2p8/X7gE1JMJJauN6T6a82juaq7YJuWwy/k=; b=yMvZ59LWo2iad0xIWQBG9jOtbeAmpkG/dIY88Yq8PHrTWeVvMUG34y00vlk0KLkBQVrsCflCh6ARGdIIO3HIoAa/zDnXXy5XI+AgCdDX0mDX32OeJcZtV9ThmOLFKCMLe0KEHMiy6lod/SYU8S+9SAYZLXcotiIKyv/8n28YbUDCp1qA+C8ZZ92e7jY/tMrI+Kdg4TrCH3mkGd+8GuZh5cH5fvspmMbDuu2sUjgbg+ayNckjxhiGPg3jhyXHswWpkh2XArWksloKL4p8Z0L9G9+TFtFbC8zyS9qSYkX+R6O5/tlFenQFWYp4GVQx3shQCSKpbvxTcOX4VPe8eduqyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+JyacLhU2p8/X7gE1JMJJauN6T6a82juaq7YJuWwy/k=; b=YSn7qwumymp95KJ3W00orQN05X8tvI9Cca01MnsSHCZYs0YingIlUkYXAH3NMEV6WJ0BRglYnEbVa/4XxUsMa/yTAX1X02UC+DWLKQlFgVsJ7+ksc6QIGddKmg6e/GjHT6SuBjboqajHhgwvlaI6YR7GXrWirVYha1/+40sLSwZjtmai5VkdXHDnFMQAOvZVOJQC5HJsAjKNuH8VNhWw+TYoEI14jAdXAtbGb85gx6CAnP78+Me0URjFAqMgaF//7ChLJAE6chcG37t+UogTck1iobVVT267s0Zc9xzuKXgYzPRYW+fEkofGyaXXmrljcc9FGt7I/oPovJZD5uUCrA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; To: devel@lists.libvirt.org Cc: berrange@redhat.com Subject: [PATCH v2 3/3] tests: Add pcihole64 test for virt machine Date: Wed, 14 May 2025 17:18:54 -0700 Message-ID: <20250515001854.2227554-1-mochs@nvidia.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20250515001814.2227195-1-mochs@nvidia.com> References: <20250515001814.2227195-1-mochs@nvidia.com> X-NVConfidentiality: public X-ClientProxiedBy: SJ0PR03CA0223.namprd03.prod.outlook.com (2603:10b6:a03:39f::18) To MW6PR12MB8897.namprd12.prod.outlook.com (2603:10b6:303:24a::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW6PR12MB8897:EE_|DS7PR12MB5814:EE_ X-MS-Office365-Filtering-Correlation-Id: e99bfbc8-463f-4456-06c6-08dd9346143d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?UIQm8/invHEmAFwvyAgUYxE0C7RpA5Rpbiy+LErW6EDwPkWDrFHTk+fadV9p?= =?us-ascii?Q?ujho/NqNyC4dFedCzkITMpq/+vq1BJF7AeEUYPOhoevlK3WzNU3MQiTG2ZRw?= =?us-ascii?Q?v6pY+RsnXObwUDscM8DaEUG9KH4yEA/nlDeypfqIfMfPDDo223w6imXcNdeN?= =?us-ascii?Q?NhwR/TudCx77ftDe6aIvyYdWhhOzrxeR5ZI1SWLM6ab8/0m3r0pRrEMpYihf?= =?us-ascii?Q?SYcEQ4NGC3nqfX/1B1fYPlNwypNRkiDo/+oL/ZGzi0/6u7KnjMEWMLFrfGsK?= =?us-ascii?Q?9hHh7lNnraKj/IEDva8uidTrVOZ6kauCvQaLxkp/nr2CPbAroSQD35fpRQc6?= =?us-ascii?Q?tYW1yeROLvsOCVoepaopEM+T3SgoBSYnHdZhZ8MsZYd2tp011O4YhC1OXNUm?= =?us-ascii?Q?OWzMLuJwu6BzUw5eKr2GWGh1dOhcb2m8yhAVF1mNPKXOVRRTEkGDvV5ELA3J?= =?us-ascii?Q?4svqxUxPgYozIED/pUkK9BvgNHIKReoNn9qJ5MbbK1p1y8wA1Ji7vcP2tlgj?= =?us-ascii?Q?S5pG7h6Uh2PszC4mP1D6E8e1uRsMNm38Yl3l2VWd3wUvzY+NLuzvcbShvlkv?= =?us-ascii?Q?psQgtCU2lojjS6FicUINY1lkn0ycX3Il6DpsnpRfa2jU4KGgR7kmblKgm1fp?= =?us-ascii?Q?GhXKV+jOa9tOKirULZAGvzN2cRN20nxKcibyt+LvFgIOEYYVMXPMNiwnWl4n?= =?us-ascii?Q?kcWm5mdXJOBQou7UsZ6sFcHo2kBOSsceKlM1O241g4AoosULG6jTq95vffQB?= =?us-ascii?Q?RSwzpcSLcbz14z5HkrZA++z/TLJvsm+OIMUsIuRLFmmwjOF+/MZTNWvvP02j?= =?us-ascii?Q?w8mNZdfK3FlhoKlLKFKIMpizhsEk08TEWuJszUxfAVLeHgC7jtdAeZHlEqHd?= =?us-ascii?Q?Na8EDUaTzmO92wYTu+2IBK5wyZqTP/v9j/E0So7JlDwrxbx7DakqZHuzM7FY?= =?us-ascii?Q?mi+9ZgNrvZ5VBiw6HIqTJgm16oj0fvm5V/RpEZqOFGCjR+HwR7jZvg+bda9i?= =?us-ascii?Q?FDTLRzg/Fgsgdb0PtbF1ulOPCcnSOMA63LI/XdRKE8P2ERdE/19LP1OD34IY?= =?us-ascii?Q?6Xd9Oddyj172bcQll2CyhJlI/FCtglk8R25d37XMNMAZsnrn0EOOZh8XQ49B?= =?us-ascii?Q?v9k4gyxEzBedCdva9/VslJTZzI1O9ZmzFaMOYR3fBHKI2W9aJDZZ80L+GC1V?= =?us-ascii?Q?uz5n52GORBoZKINIYj8NT2Jb62GsPtpXLnbxeAbvGcjQBaR/fTiMuH38PKZj?= =?us-ascii?Q?nGQeLDTJHHV/G8uOzwHElloJvLmglmL+yElhb0RYVV6PSav7pkfSFtTLo1N/?= =?us-ascii?Q?7MsDjXZprOPSIF+FgpYYJH4tJoskqMer9SsbzA70VMEZ81AXrueVIArfrVRe?= =?us-ascii?Q?f195rd9Aoqrkf3HD5eSEKYK0lkeIn0dkX4MXGXnHsC92KywjAI8Zb3dC6DOE?= =?us-ascii?Q?uhOuxeAf4Ys=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW6PR12MB8897.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+hxVBSYZH1b9g6eswxvelZCidnjK2dDXEmU7Vgpr9o+piuuSkDehw7qScjek?= =?us-ascii?Q?WH0DdeE+2fvQjGiwl6xh3yV3UZ+V/eHQey7toFtZbEP/vYoWbE3nmgzaIkYy?= =?us-ascii?Q?xTrOfOuReY2J8DUIr5/Fe9IYFhhSno8FSVSjkrff39sLUgh4fxwDrolnF6Pi?= =?us-ascii?Q?VvJkuhspTatXoLzT8scbWUXacua8roxLhDldn5B58/IZVXVFfSw7mWxADkOt?= =?us-ascii?Q?VzWh3h4LRfnUYD3DIqgW0dvm5+y3eqPy56y3FYx3LDnuiX9c3VVoBoz4BGiY?= =?us-ascii?Q?xFE+KssAt9WrsDkWvYDsmW1lsQs0v5nMnAAqXBgnOQbv7uAjiiHuXf/km/GF?= =?us-ascii?Q?l4nNKFxgKq4tLxg1k3LMFvLH3TE2QlZ9up+QYaErlHaP9ipYOGsnZ/2SXuWA?= =?us-ascii?Q?kGhORvWX0jI568+RDk3+HrCXnYdgN2bNVt32gZl/f1qVqb+DU4NG8fY6uAlJ?= =?us-ascii?Q?zad4NWTD76bx+VBHmyog0EPH21G1hmpUhNysYbEN0Gwy82++OSsUCpH4m3Qf?= =?us-ascii?Q?LisYkpB9bO71980G4sWwySoIw/k+BIVBBGJQoogdJjhezZfLfqhw+pGEq4Fz?= =?us-ascii?Q?Fkk3yN0VovYLlhVXwKIiDAkef1xDchoxaCqZtY0XeaCTvuIh5PhNSYS494zI?= =?us-ascii?Q?fOrTnbnjJV/VcH/goKqmsIjZSx+mRqmHybs3xKlQNg99YEguZ+KQBFDrfJdA?= =?us-ascii?Q?DLg/Qz8sdniuh4wMfRsf5kx2SVq0n97yU24vrw4j38/44RyprHViNFTyiRgm?= =?us-ascii?Q?m+fH/ehXfxVXtgzxtegCoPDXKmrTIX0W8Vv3sB7Y1RnLPgx/ITVGMDiVedjH?= =?us-ascii?Q?rqiTgD0NOSgzXCScwkfI9AcCsWAoITb4lcKzBCUkS+IimrKV8Ayda3oLGXVw?= =?us-ascii?Q?vsE+O4vR3TxsB6an9Q7RC7wieB5p2Xwb5j3qfJTKJ+cU8zqoGhZimrm4D7sH?= =?us-ascii?Q?TL7rnEf9Uu28IWSLnAv5YIlu0Qpkb2wR6KZFIBll1giPKjqvfHXoWKijGH2v?= =?us-ascii?Q?zZUYR/uDmb0xjCx5Kqm05iVYwO9HihnKhUgtPVGNQJcGFoJRAlg9KdDkVXE3?= =?us-ascii?Q?1CRBj8+7cEgGUAXsn9dQHsVBQm0lMBjGrRliKoFDifbaHTJdyH1pkJ6HBf65?= =?us-ascii?Q?Cjq7w6JlQWSkR4DXp7tnZ8Tkcw/6bdinVy/hCMsbWgnGv0w76nXGbOPCjG3Y?= =?us-ascii?Q?UU0WD0I9VLh9rnsFbki3PAhJzoE/d6kt5l+fqNwzJwW95xsylm45JGOAGpMN?= =?us-ascii?Q?Oyb4gg+0W6nHlxDJ1Gc6dUcVr33cF3LERMh+214SCyihEhfKcTYPmkGib+uu?= =?us-ascii?Q?Pk5tWelUFo2rE3BinTCypjgb2TdFe4gnWA00e+rLIXJxVWIE/ixo4hzsXvKW?= =?us-ascii?Q?OLWvflPnB23PgJvg58hDwCtC6i7sLFyDPgCsao22rwe1uejv0+/dzecHDrKI?= =?us-ascii?Q?1Od5wcB55FdUAmPfHWjhw7rAtePqPJNfrmOKMw2u7BsT6///UfhYWg2kHJLs?= =?us-ascii?Q?fR4exBT2fgZkuZMfsCJ4xZnT3ObjGgb0qocMeS2GNS5rLzceeOKBrb3r9S6i?= =?us-ascii?Q?AFqSsIeW5K6vLSAsbzvbVN69HknwNRruFMz77ral?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: e99bfbc8-463f-4456-06c6-08dd9346143d X-MS-Exchange-CrossTenant-AuthSource: MW6PR12MB8897.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2025 00:18:55.4228 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VisoDlLlG0B4xgpOjl4eQtFrtUwx8IaKrf7KcpRlrFZ9tRcMOPkitH2C6NoIOTl+lENgPvZWsVpnHT+CLHpSEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5814 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: VQ4OKLHZZP6LXIYCFISYJVN6TLP7BUPG X-Message-ID-Hash: VQ4OKLHZZP6LXIYCFISYJVN6TLP7BUPG X-MailFrom: mochs@nvidia.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: "Matthew R. Ochs via Devel" Reply-To: "Matthew R. Ochs" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747268445707019000 Content-Type: text/plain; charset="utf-8" Add a pcihole64 test for the aarch64 virt machine that verifies the value is propagated to the highmem-mmio-size virt machine parameter. Signed-off-by: Matthew R. Ochs Reviewed-by: Daniel P. Berrang=C3=A9 --- .../pcihole64-virt.aarch64-latest.args | 31 +++++++++++++++++++ .../pcihole64-virt.aarch64-latest.xml | 29 +++++++++++++++++ tests/qemuxmlconfdata/pcihole64-virt.xml | 17 ++++++++++ tests/qemuxmlconftest.c | 1 + 4 files changed, 78 insertions(+) create mode 100644 tests/qemuxmlconfdata/pcihole64-virt.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/pcihole64-virt.aarch64-latest.xml create mode 100644 tests/qemuxmlconfdata/pcihole64-virt.xml diff --git a/tests/qemuxmlconfdata/pcihole64-virt.aarch64-latest.args b/tes= ts/qemuxmlconfdata/pcihole64-virt.aarch64-latest.args new file mode 100644 index 000000000000..d2df31ed868e --- /dev/null +++ b/tests/qemuxmlconfdata/pcihole64-virt.aarch64-latest.args @@ -0,0 +1,31 @@ +LC_ALL=3DC \ +PATH=3D/bin \ +HOME=3D/var/lib/libvirt/qemu/domain--1-foo \ +USER=3Dtest \ +LOGNAME=3Dtest \ +XDG_DATA_HOME=3D/var/lib/libvirt/qemu/domain--1-foo/.local/share \ +XDG_CACHE_HOME=3D/var/lib/libvirt/qemu/domain--1-foo/.cache \ +XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-foo/.config \ +/usr/bin/qemu-system-aarch64 \ +-name guest=3Dfoo,debug-threads=3Don \ +-S \ +-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-foo/master-key.aes"}' \ +-machine virt,usb=3Doff,gic-version=3D2,dump-guest-core=3Doff,memory-backe= nd=3Dmach-virt.ram,acpi=3Doff,highmem-mmio-size=3D536870912K \ +-accel tcg \ +-cpu cortex-a15 \ +-m size=3D1048576k \ +-object '{"qom-type":"memory-backend-ram","id":"mach-virt.ram","size":1073= 741824}' \ +-overcommit mem-lock=3Doff \ +-smp 1,sockets=3D1,cores=3D1,threads=3D1 \ +-uuid 6ba7b810-9dad-11d1-80b4-00c04fd430c8 \ +-display none \ +-no-user-config \ +-nodefaults \ +-chardev socket,id=3Dcharmonitor,fd=3D1729,server=3Don,wait=3Doff \ +-mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ +-rtc base=3Dutc \ +-no-shutdown \ +-boot strict=3Don \ +-audiodev '{"id":"audio1","driver":"none"}' \ +-sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ +-msg timestamp=3Don diff --git a/tests/qemuxmlconfdata/pcihole64-virt.aarch64-latest.xml b/test= s/qemuxmlconfdata/pcihole64-virt.aarch64-latest.xml new file mode 100644 index 000000000000..1fb38b429e9f --- /dev/null +++ b/tests/qemuxmlconfdata/pcihole64-virt.aarch64-latest.xml @@ -0,0 +1,29 @@ + + foo + 6ba7b810-9dad-11d1-80b4-00c04fd430c8 + 1048576 + 1048576 + 1 + + hvm + + + + + + + cortex-a15 + + + destroy + restart + destroy + + /usr/bin/qemu-system-aarch64 + + 536870912 + + + diff --git a/tests/qemuxmlconfdata/pcihole64-virt.xml b/tests/qemuxmlconfda= ta/pcihole64-virt.xml new file mode 100644 index 000000000000..00bb51ab0e9a --- /dev/null +++ b/tests/qemuxmlconfdata/pcihole64-virt.xml @@ -0,0 +1,17 @@ + + foo + 6ba7b810-9dad-11d1-80b4-00c04fd430c8 + 1048576 + 1048576 + 1 + + hvm + + + /usr/bin/qemu-system-aarch64 + + 512 + + + + diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c index 1f31ec810c7a..7fe51ba4f81c 100644 --- a/tests/qemuxmlconftest.c +++ b/tests/qemuxmlconftest.c @@ -2587,6 +2587,7 @@ mymain(void) =20 DO_TEST_CAPS_LATEST("pcihole64"); DO_TEST_CAPS_LATEST("pcihole64-q35"); + DO_TEST_CAPS_ARCH_LATEST("pcihole64-virt", "aarch64"); =20 DO_TEST_CAPS_ARCH_LATEST("arm-vexpressa9-nodevs", "aarch64"); DO_TEST_CAPS_ARCH_LATEST("arm-vexpressa9-basic", "aarch64"); --=20 2.46.0