From nobody Fri Dec 19 20:17:28 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1746810828610434.26389905792837; Fri, 9 May 2025 10:13:48 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id DE40417D9; Fri, 9 May 2025 13:13:47 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id D592117D3; Fri, 9 May 2025 13:13:06 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 642831739; Fri, 9 May 2025 13:13:02 -0400 (EDT) Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E88561473 for ; Fri, 9 May 2025 13:12:59 -0400 (EDT) Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5faaddb09feso4396384a12.2 for ; Fri, 09 May 2025 10:12:59 -0700 (PDT) Received: from tulp.my.domain (80-115-115-199.cable.dynamic.v4.ziggo.nl. [80.115.115.199]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5fcb3773b04sm581106a12.10.2025.05.09.10.12.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 May 2025 10:12:57 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746810778; x=1747415578; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i47mSFLxNJe4VTDp7imQJsZiWKkqjCNWrh9y5o018IA=; b=OqVXjdp+Bpi9fwCgln0d2xX5t09/1O+ItCFPIHy9Ek/HroLU0G2kY59EMw6rsQEjDP AsNI8nXyx2RgwLJqbpSlQQn/1qp6f36Wo5Ec+FsaIk/sKdGZ0imUAYAlxg6hSn/KZZ2U A6A2usxb2/JNvFwQtzE/6mL23c9uFw6NrzTUjBNakxFB57CIP5vNO6KFmcQtKCDYNPQ2 R3czPhrYtrusPDbiSibkkfPQJ93G1dRUgxq/8Iron6UCJu/8/RFNAjR9cxK9Z96wJ3SO MbdkJO9bQCozn7pHtIy2k9ZuZso51h4oJUQeKv3fHLQfeug8foo0NFK4eZ+OBqofeBrm yN3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746810778; x=1747415578; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i47mSFLxNJe4VTDp7imQJsZiWKkqjCNWrh9y5o018IA=; b=kCORoOsQU3GSidj9Fu5r0dRvqKDuhpxZdd7QRF3/UGfvVWipfNKFesVkvDd7GUxI3C 1rk0NwoCuM/piqidZs4F1X4VJryEuXYDxoSSSDJZpT8sBu/sHH6GZ0JDMSNCIXpmy7Z7 xl58J7K/X3KcuNiD2pV/t2aiXj7tVkQfrWZYSC+alDgwPH9RvzURswkwviK3GAYVFl+O QO5mNmm/bpnTosmW2n5NlnTLgWq1IO96wba2SPfA47Ve3HRC1IV0emGV7iKE+JgsEiBg 4ox70y4A6jLAg7yEyHEllHOyKApJJ+Uppa3u7SIsYrtpwY7msAvfztnRkYamHOyF5pyJ M+Xw== X-Gm-Message-State: AOJu0YywC3qPKx2x57uMy9Pnps3wrA5Hsqaa2LMkJt/ehs9ERdY5vxxd NjCHib0JYIucyQVHRt6c66BAvH8/h8ikDTP86mjDWRBWcMJ021RtFmJV96ha5bvrMA== X-Gm-Gg: ASbGnctGpfzvI1HaRCMJMPqFJTG2F32UoO29iFV8TtF6sIh548dMgsh3iZBHgZ1IkiC 11cbsk0c7lgwRMxU0yVpQKBQyzR21TPT0kXm2KjnAJhPDDSA9mRHSKfPaz11OuzuffIFWb3sC6j 5j2tZRi+fxXx43pprTi4tnoypavZY5qk7bFRwDO4egSfZVzdJ1hT4iGyBg7uRdaV+L3nIE0wveg B7oZo+1qYU9CmxvusQecn2MZqXCGK3wEcJTdB1Vs59KBmw8BJPYSHRi+2Gi0GzkyT11cRzN/1jI lZHSdHUFdu2umg94pYbJnTF92BjwnSPPEv9soSwZaim2DR+WSP+xvOS+z08FOC4hh0YtHmx3XXq NqRy9qyx0EEUKSw== X-Google-Smtp-Source: AGHT+IEOyztePKziScIReOzQlY9Rb+DU7sxTx7aIjX6lQV5GCgKOZrTZRzPFLfdutfz77d8T7xvOjg== X-Received: by 2002:a05:6402:1e96:b0:5fc:8d86:8ea3 with SMTP id 4fb4d7f45d1cf-5fca081af06mr3733309a12.30.1746810778137; Fri, 09 May 2025 10:12:58 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 1/5] bhyve: conf: introduce nvramDir Date: Fri, 9 May 2025 19:11:47 +0200 Message-ID: <20250509171151.31305-2-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250509171151.31305-1-bogorodskiy@gmail.com> References: <20250509171151.31305-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 2HUOJSTQDQTYQIUTB3P7R4MOM35MEGF2 X-Message-ID-Hash: 2HUOJSTQDQTYQIUTB3P7R4MOM35MEGF2 X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1746810832153019000 Content-Type: text/plain; charset="utf-8" As a preparation for NVRAM support, introduce nvramDir configuration item. Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_conf.c | 4 ++++ src/bhyve/bhyve_utils.h | 2 ++ src/bhyve/meson.build | 5 +++++ 3 files changed, 11 insertions(+) diff --git a/src/bhyve/bhyve_conf.c b/src/bhyve/bhyve_conf.c index 28981c90b7..f18b24f91d 100644 --- a/src/bhyve/bhyve_conf.c +++ b/src/bhyve/bhyve_conf.c @@ -57,6 +57,8 @@ virBhyveDriverConfigNew(void) return NULL; =20 cfg->firmwareDir =3D g_strdup(DATADIR "/uefi-firmware"); + cfg->libDir =3D g_strdup_printf("%s/lib/libvirt/bhyve", LOCALSTATEDIR); + cfg->nvramDir =3D g_strdup_printf("%s/nvram", cfg->libDir); =20 return cfg; } @@ -95,6 +97,8 @@ virBhyveDriverConfigDispose(void *obj) struct _virBhyveDriverConfig *cfg =3D obj; =20 g_free(cfg->firmwareDir); + g_free(cfg->libDir); + g_free(cfg->nvramDir); } =20 void diff --git a/src/bhyve/bhyve_utils.h b/src/bhyve/bhyve_utils.h index 6c6fd12dbe..9c9ea0a01a 100644 --- a/src/bhyve/bhyve_utils.h +++ b/src/bhyve/bhyve_utils.h @@ -39,6 +39,8 @@ struct _virBhyveDriverConfig { virObject parent; =20 char *firmwareDir; + char *libDir; + char *nvramDir; }; =20 G_DEFINE_AUTOPTR_CLEANUP_FUNC(virBhyveDriverConfig, virObjectUnref); diff --git a/src/bhyve/meson.build b/src/bhyve/meson.build index b3551477b7..11920d9c3e 100644 --- a/src/bhyve/meson.build +++ b/src/bhyve/meson.build @@ -64,4 +64,9 @@ if conf.has('WITH_BHYVE') virt_daemon_confs +=3D { 'name': 'virtbhyved', } + + virt_install_dirs +=3D [ + localstatedir / 'lib' / 'libvirt' / 'bhyve', + localstatedir / 'lib' / 'libvirt' / 'bhyve' / 'nvram', + ] endif --=20 2.49.0