From nobody Tue Sep 9 09:48:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1746720999; cv=none; d=zohomail.com; s=zohoarc; b=KbAULlQcOZ97DED0oe2ZwrJxT0uuE+j2W06OkyFW+ZGtz+SqiZaj2CEfMocSSldbjJ0dOVt+Qr1+Q/sAmf2InrwHkxsHTZl7tu8c6TLdPT5uNPKoxSdWPjLfSYo7qTCcxY4p+wP7ElQ0DIRGCF/UTLrnQKTgFjYHvQRymOhk2a8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1746720999; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=dfkPAlB3ZW0sfG2ML+2QlCKaR7fek2gC0qmDv93OV6k=; b=NtXJAsbW4TBrWyLGEurHk0Az2rKlSpW08HgGV6pkmsyPbv2IloyIlaOTcg+frf7beUUavz+3lMJfTpAAcgXI1DWSEEKfxTu6YhjzDd4tlNEBbxVPT4QY85n2oOprYNj/YqieRaFCHehYz/yUb74fTc5To3uUkauIEjTz4HWyLyI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1746720999723159.69965367285624; Thu, 8 May 2025 09:16:39 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 2205F1710; Thu, 8 May 2025 12:16:39 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 3A39515ED; Thu, 8 May 2025 12:16:13 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 1D46D15BC; Thu, 8 May 2025 12:16:08 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 7400B16F8 for ; Thu, 8 May 2025 12:15:55 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-494-Ds6sSIvAPnu47t7Lc-zc-A-1; Thu, 08 May 2025 12:15:50 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 41828180045C; Thu, 8 May 2025 16:15:48 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.138]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 53477180049D; Thu, 8 May 2025 16:15:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746720955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N3cKX666Bi8FN5j4sXz69W+1rVvNDKX62XzUMC75xX0=; b=MEj5gBd3bL8dO9XVDJKrpkzmDhKUJ1IXmXiQUNomXhAAW1IN96PgwInvcD5Zs3/+gPJMNO UvEZHL7orT0V1ET/br1ck+qYm8aSdCyAkeH1XtmwpuUpZTC8o3fwy2hkxH2nUHx3cWNA0w tltBM+dr/Cr2dKvRZet7qrpOu7wkZjw= X-MC-Unique: Ds6sSIvAPnu47t7Lc-zc-A-1 X-Mimecast-MFC-AGG-ID: Ds6sSIvAPnu47t7Lc-zc-A_1746720948 To: qemu-devel@nongnu.org Subject: [PULL 1/6] tests/qtest/q35-test: Remove the obsolete test_without_smram_base test Date: Thu, 8 May 2025 17:15:31 +0100 Message-ID: <20250508161536.865866-2-berrange@redhat.com> In-Reply-To: <20250508161536.865866-1-berrange@redhat.com> References: <20250508161536.865866-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: SVFK7VX7NUIDHXSA4IS3765N427NDHNV X-Message-ID-Hash: SVFK7VX7NUIDHXSA4IS3765N427NDHNV X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Yanan Wang , devel@lists.libvirt.org, Laurent Vivier , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Fabiano Rosas , Zhao Liu , Peter Maydell , Marcel Apfelbaum , Eduardo Habkost , John Snow , "Michael S. Tsirkin" , Thomas Huth X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1746721000893019000 Content-Type: text/plain; charset="utf-8" From: Thomas Huth With the release of QEMU 10.1, the pc-q35-4.1 machine will be older than 6 years and thus will get disabled automatically by the MACHINE_VER_DELETION() macro. Remove the related test to avoid that the q35-test is failing when the machine is not available anymore. Tested-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Thomas Huth --- tests/qtest/q35-test.c | 37 +------------------------------------ 1 file changed, 1 insertion(+), 36 deletions(-) diff --git a/tests/qtest/q35-test.c b/tests/qtest/q35-test.c index 75d4078b79..62fff49fc8 100644 --- a/tests/qtest/q35-test.c +++ b/tests/qtest/q35-test.c @@ -246,41 +246,6 @@ static void test_smram_smbase_lock(void) qtest_quit(qts); } =20 -static void test_without_smram_base(void) -{ - QPCIBus *pcibus; - QPCIDevice *pcidev; - QTestState *qts; - int i; - - qts =3D qtest_init("-M pc-q35-4.1"); - - pcibus =3D qpci_new_pc(qts, NULL); - g_assert(pcibus !=3D NULL); - - pcidev =3D qpci_device_find(pcibus, 0); - g_assert(pcidev !=3D NULL); - - /* check that RAM is accessible */ - qtest_writeb(qts, SMBASE, SMRAM_TEST_PATTERN); - g_assert_cmpint(qtest_readb(qts, SMBASE), =3D=3D, SMRAM_TEST_PATTERN); - - /* check that writing to 0x9c succeeds */ - for (i =3D 0; i <=3D 0xff; i++) { - qpci_config_writeb(pcidev, MCH_HOST_BRIDGE_F_SMBASE, i); - g_assert(qpci_config_readb(pcidev, MCH_HOST_BRIDGE_F_SMBASE) =3D= =3D i); - } - - /* check that RAM is still accessible */ - qtest_writeb(qts, SMBASE, SMRAM_TEST_PATTERN + 1); - g_assert_cmpint(qtest_readb(qts, SMBASE), =3D=3D, (SMRAM_TEST_PATTERN = + 1)); - - g_free(pcidev); - qpci_free_pc(pcibus); - - qtest_quit(qts); -} - int main(int argc, char **argv) { g_test_init(&argc, &argv, NULL); @@ -293,6 +258,6 @@ int main(int argc, char **argv) qtest_add_data_func("/q35/tseg-size/ext/16mb", &tseg_ext_16mb, test_tseg_size); qtest_add_func("/q35/smram/smbase_lock", test_smram_smbase_lock); - qtest_add_func("/q35/smram/legacy_smbase", test_without_smram_base); + return g_test_run(); } --=20 2.49.0