From nobody Tue Sep 9 09:45:38 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1745925351; cv=none; d=zohomail.com; s=zohoarc; b=nPJf7Iskqj2kcodMm6RhEX/RvVY3nKvft7AzTOhsx5NMPmoKjx54igqBMFg096/FJ8iW/aQe7qZ0DFbkzWXqPwjPv6uxW5FwBPymhabqMkw75uIBl4zVPGdqrPpvIdyhpNcTNATXw8POpNwP4KSCk8FKEGGPbCs4gbdseGtEAMM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1745925351; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=4oiGNOZb+vrpRHQWPV9gmMHRcV03pLj6Jrnb6RghokI=; b=JqPfzWxUmBmqIb5pyj8A3wu0HC1Tzm3mnxHv/KI7EPiXiI0AHxlyFnWqxPrpbdhaD184pYEnL2w3Kbwfo6Lw0qUrqqNrnPjysHgv9VQfLr35j8NtsdPosJ6CMLmtV1QcKsIehCG4DcO8i8jWOv3eJ3Me+5UjlnVZXanBkGT+3Uk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1745925351422525.1401490212588; Tue, 29 Apr 2025 04:15:51 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 7666E1405; Tue, 29 Apr 2025 07:15:50 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 4A17613EC; Tue, 29 Apr 2025 07:14:34 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A530E11F1; Tue, 29 Apr 2025 07:14:28 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4953F11F1 for ; Tue, 29 Apr 2025 07:14:28 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-495-4BTvg_uzOLmInqT6DEFP8w-1; Tue, 29 Apr 2025 07:14:25 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DF1C81956086 for ; Tue, 29 Apr 2025 11:14:24 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.98]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2332D195608D; Tue, 29 Apr 2025 11:14:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745925268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IEFwtEs7TTFageTfPuCdGaUtTlh6sh3gMbav5oOEBrM=; b=cfiemj/cSsgonyF9aGLVsIl5INc1SAZ04aWVW0OqKnk9ZnURddatRHtykw5WSW1v9IcM81 1qDUCPwFvsiaylw3qbBMw6otYFel2J12kBBD2fxpoEMMZvENQns8pAOlvONZKgQnvUrWpL ncof+6K3D6brVSaWIGmh9BhVDBNpGCg= X-MC-Unique: 4BTvg_uzOLmInqT6DEFP8w-1 X-Mimecast-MFC-AGG-ID: 4BTvg_uzOLmInqT6DEFP8w_1745925265 To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 02/20] tests: storage hardcoding paths for mount & vgchange Date: Tue, 29 Apr 2025 12:14:02 +0100 Message-ID: <20250429111420.1748521-3-berrange@redhat.com> In-Reply-To: <20250429111420.1748521-1-berrange@redhat.com> References: <20250429111420.1748521-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XhsKqIrbabwUZstvr-cT3fvbyxgGGb1ebOOBurJiP0U_1745925265 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7RTBLROLHKHKSH77ABGCKE7QAF5OH3ES X-Message-ID-Hash: 7RTBLROLHKHKSH77ABGCKE7QAF5OH3ES X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745925354900019100 Content-Type: text/plain; charset="utf-8" From: Daniel P. Berrang=C3=A9 This is redundant since the tests will strip any path component from the binary name before comparison. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- tests/storagepoolxml2argvtest.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/tests/storagepoolxml2argvtest.c b/tests/storagepoolxml2argvtes= t.c index e8e40d695e..d5c2531ab8 100644 --- a/tests/storagepoolxml2argvtest.c +++ b/tests/storagepoolxml2argvtest.c @@ -6,14 +6,6 @@ =20 #define VIR_FROM_THIS VIR_FROM_NONE =20 -#ifndef MOUNT -# define MOUNT "/usr/bin/mount" -#endif - -#ifndef VGCHANGE -# define VGCHANGE "/usr/sbin/vgchange" -#endif - static int testCompareXMLToArgvFiles(bool shouldFail, const char *poolxml, @@ -46,12 +38,12 @@ testCompareXMLToArgvFiles(bool shouldFail, goto cleanup; } =20 - cmd =3D virStorageBackendFileSystemMountCmd(MOUNT, def, src); + cmd =3D virStorageBackendFileSystemMountCmd("mount", def, src); def =3D NULL; break; =20 case VIR_STORAGE_POOL_LOGICAL: - cmd =3D virStorageBackendLogicalChangeCmd(VGCHANGE, def, true); + cmd =3D virStorageBackendLogicalChangeCmd("vgchange", def, true); break; =20 case VIR_STORAGE_POOL_DIR: --=20 2.49.0