From nobody Wed Apr 29 20:22:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1745925771; cv=none; d=zohomail.com; s=zohoarc; b=T5aRh/pifLS8R5VTMdZIiy1LPkuCLTZuf2p/GCpGuda6Zm6mQq9iOS+08JceeWUoPIDaN1phi1RSp84dTNnBofgfOTPKC2uG60/Ysk9CTROdORpUkJ5iz367U38BGQr9K1Zuw+84379eNGc2NcEV9pYqMsrZg2B7inu6fcY9qYo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1745925771; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=7BLDM/ycwXsnpcARzy4jc11PtlUB/XC8rEiJwwjcq40=; b=eZZOVIR/kUlNbiDCAQ8qYAiJ/yyFY9VT/Pw11IdaZ927rLmtGHO58U/TUaIKYAo4k6MHW4x8TFtKjjWkY6j3GYBYv0+vnE/lJPkoV7QHNDOk7x9pCdM++dhalMxwYlSr8mtk+8RctGB7Sx1c7k8lHcU/g5n+8Y25f6SFb7GLoDg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1745925771933718.9001927226869; Tue, 29 Apr 2025 04:22:51 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id EF1C81284; Tue, 29 Apr 2025 07:22:50 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id DF95F13D7; Tue, 29 Apr 2025 07:15:25 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id AEF631391; Tue, 29 Apr 2025 07:15:08 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C2015142F for ; Tue, 29 Apr 2025 07:14:47 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-96-WzBj2SKYOZyOvpn2fwewFw-1; Tue, 29 Apr 2025 07:14:46 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 505AE19560A5 for ; Tue, 29 Apr 2025 11:14:45 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.98]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 76287195608D; Tue, 29 Apr 2025 11:14:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745925287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QRISucJxMzPQjqLP3zKGhMWb4Yq+P+fTvb8XrIyh0UI=; b=aMsMu5HVkcG3DvaIGEeKXQT0v2tf5zzaAi7YpTAYVrqAioWX15psgNXKzDgpA1Nfodv+VP BeVrO2GtCQ91Ftp3fADTNK30YylyyLXPwhNXrZyE4wjS2vhsavuN7/mZ1YhauPeA5O9N3j w8UoQkPr7bZH9SOoLAaPp+wXlNgbCzg= X-MC-Unique: WzBj2SKYOZyOvpn2fwewFw-1 X-Mimecast-MFC-AGG-ID: WzBj2SKYOZyOvpn2fwewFw_1745925285 To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 19/20] util: stop hardcoding pkttyagent path Date: Tue, 29 Apr 2025 12:14:19 +0100 Message-ID: <20250429111420.1748521-20-berrange@redhat.com> In-Reply-To: <20250429111420.1748521-1-berrange@redhat.com> References: <20250429111420.1748521-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: WZp1eriAIl8BG4RWHBOeq2Sit3tvmwMaE0beSgR-wd0_1745925285 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: SRSZY4QEYNOG3WL2O44E32VIT25QSFHB X-Message-ID-Hash: SRSZY4QEYNOG3WL2O44E32VIT25QSFHB X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745925774931019100 Content-Type: text/plain; charset="utf-8" From: Daniel P. Berrang=C3=A9 Allow virCommand to find it in $PATH Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- src/util/virpolkit.c | 8 +++++--- src/util/virpolkit.h | 2 -- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index 0a637db9ba..81fa5d0989 100644 --- a/src/util/virpolkit.c +++ b/src/util/virpolkit.c @@ -189,7 +189,7 @@ virPolkitAgentCreate(void) =20 agent =3D g_new0(virPolkitAgent, 1); =20 - agent->cmd =3D virCommandNewArgList(PKTTYAGENT, "--process", NULL); + agent->cmd =3D virCommandNewArgList("pkttyagent", "--process", NULL); =20 virCommandAddArgFormat(agent->cmd, "%lld", (long long int) getpid()); virCommandAddArg(agent->cmd, "--notify-fd"); @@ -234,11 +234,13 @@ virPolkitAgentAvailable(void) { const char *termid =3D ctermid(NULL); VIR_AUTOCLOSE fd =3D -1; + g_autofree char *agent =3D NULL; =20 - if (!virFileIsExecutable(PKTTYAGENT)) + if (!termid) return false; =20 - if (!termid) + agent =3D virFindFileInPath("pkttyagent"); + if (!agent) return false; =20 /* diff --git a/src/util/virpolkit.h b/src/util/virpolkit.h index 7bcd040e5e..afc0005365 100644 --- a/src/util/virpolkit.h +++ b/src/util/virpolkit.h @@ -24,8 +24,6 @@ #include "internal.h" #include "vircommand.h" =20 -#define PKTTYAGENT "/usr/bin/pkttyagent" - int virPolkitCheckAuth(const char *actionid, pid_t pid, unsigned long long startTime, --=20 2.49.0