From nobody Thu Apr 30 09:11:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1745925593; cv=none; d=zohomail.com; s=zohoarc; b=SdCYwNV8oNXrjB9qqKd2yhnH52iYGMPjG8zFwe8boW/WC2USWnvkfkiROkRb9HHIbWYu9LhAuGvxDO/yuhocysO6L3c24NlsLXlDJIWiIeyffYO3XA+ZQqHFL6dptHiQj9IkGiZXsdN2mrPmW5A3/qaCO4VVPJzqOXymPrDYvBg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1745925593; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=tjg2wtBsLwoGKaKHqMStkMhIVFvVKNeseR0XW+07HYE=; b=Qv9XjEbIoAgmnk1bwZxD8WpEtMqkXTts6KDfIVBy+ANh8HVayE27fDHxAfTXqXlI6EgA4ojwy66dJWAD21jBRt42oprwhacxkzNmEtkV7qurQnl0TpdPAEBYxc4qNt5sm5TLmHa8AD/e0CwGrO/IAYWSiR+F+wqf22Q7x9awSHg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1745925593893159.29446755094898; Tue, 29 Apr 2025 04:19:53 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 55C9614AC; Tue, 29 Apr 2025 07:19:53 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id B832513DB; Tue, 29 Apr 2025 07:15:11 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 735EE12E6; Tue, 29 Apr 2025 07:15:04 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3F3BA1415 for ; Tue, 29 Apr 2025 07:14:40 -0400 (EDT) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-152-8YkRnWmKMiuRzz-4BJFQlQ-1; Tue, 29 Apr 2025 07:14:38 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9EEA91956087 for ; Tue, 29 Apr 2025 11:14:37 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.98]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D9AAA195608D; Tue, 29 Apr 2025 11:14:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745925279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ocQhEdHV0P2qyUHQGizH+gIK985CVGQuSVG9hwUyU74=; b=IRliYZ/rTJmJnscmiARo6Wi/XJABU+gXplKdJd9gHwxYtpHGLDKaEqvxpORs7zpMgQ4OcG fHI+Crtj+6A26IYlcToJWjej9OHVMsRmlqn07YXfTCa2ruUQRufMexEv5B/4FRR65fv38A w1HAoJC6CcodUbkRBSIjFvT0Zxk7OXE= X-MC-Unique: 8YkRnWmKMiuRzz-4BJFQlQ-1 X-Mimecast-MFC-AGG-ID: 8YkRnWmKMiuRzz-4BJFQlQ_1745925277 To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 13/20] util: remove use hardcoded MM_CTL path Date: Tue, 29 Apr 2025 12:14:13 +0100 Message-ID: <20250429111420.1748521-14-berrange@redhat.com> In-Reply-To: <20250429111420.1748521-1-berrange@redhat.com> References: <20250429111420.1748521-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ur5iA3LDctqunKTj9bNRyeScnRZxVoLbNNcBz37F-B8_1745925277 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: HORSMQX4QKUL3V5C6ASLHQV6DOG6WBYV X-Message-ID-Hash: HORSMQX4QKUL3V5C6ASLHQV6DOG6WBYV X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745925594825019000 Content-Type: text/plain; charset="utf-8" From: Daniel P. Berrang=C3=A9 Allow virCommand to find 'mm-ctl' in $PATH. This command is only used when running privileged in which case both 'bin' and 'sbin' dirs will be in $PATH, so virFindFileInPath will do the right thing to find it. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- meson.build | 2 -- src/util/virnetdevmidonet.c | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index 9759a3322b..2a7c264114 100644 --- a/meson.build +++ b/meson.build @@ -854,8 +854,6 @@ optional_test_programs =3D [ ] =20 optional_programs =3D [ - 'mdevctl', - 'mm-ctl', 'modprobe', 'ovs-vsctl', 'rmmod', diff --git a/src/util/virnetdevmidonet.c b/src/util/virnetdevmidonet.c index 7a285d2bab..a6f1dd1a8f 100644 --- a/src/util/virnetdevmidonet.c +++ b/src/util/virnetdevmidonet.c @@ -43,7 +43,7 @@ virNetDevMidonetBindPort(const char *ifname, =20 virUUIDFormat(virtualport->interfaceID, virtportuuid); =20 - cmd =3D virCommandNew(MM_CTL); + cmd =3D virCommandNew("mm-ctl"); =20 virCommandAddArgList(cmd, "--bind-port", virtportuuid, ifname, NULL); =20 @@ -73,7 +73,7 @@ virNetDevMidonetUnbindPort(const virNetDevVPortProfile *v= irtualport) =20 virUUIDFormat(virtualport->interfaceID, virtportuuid); =20 - cmd =3D virCommandNew(MM_CTL); + cmd =3D virCommandNew("mm-ctl"); virCommandAddArgList(cmd, "--unbind-port", virtportuuid, NULL); =20 if (virCommandRun(cmd, NULL) < 0) { --=20 2.49.0