From nobody Tue Sep 9 09:47:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1745925577; cv=none; d=zohomail.com; s=zohoarc; b=em/da5gKsCG8BKeLeECsIRSWYLnUe6W1zdT7jGqLPtRUn/Bt/yubyAjsds8xN9/J1zEX3ab6dkeKHRadOa4JCYWNdDFaBK8RF1gh7PWo7FDB73KPmRTNNs+XdqZT/G9hTe2TYdWsakLvNktPgYDKT7URWZD6FpSc3hL5HK7vDrQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1745925577; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=5BX2qRZ0PUOIa1K7kd7i8+Cdwo/Rxf9zGHypXsOYZwk=; b=cuLUosadxGPqMU4C3xVUZRdneKWrwxwCh0nBdgwpZcGN1Ynj1bOCT1AKhuLqFyly8gvfWne/EuWED1ri5VfQubA4uPxi0rWP8YTE87tRNPpfEiD6EasaNLiZjGUD8KJsh/LxRyi1cQ2BWe4HsfjNlVSuMLIzWKQvBrRLx/KOvTU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 174592557754294.72565762286013; Tue, 29 Apr 2025 04:19:37 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 0329A1294; Tue, 29 Apr 2025 07:19:36 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 939AE140D; Tue, 29 Apr 2025 07:15:08 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 5AD2C12E6; Tue, 29 Apr 2025 07:15:04 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 03558140E for ; Tue, 29 Apr 2025 07:14:38 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-157-ad7zj7rTOIurheh7mIk-Zw-1; Tue, 29 Apr 2025 07:14:37 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8466D180010A for ; Tue, 29 Apr 2025 11:14:36 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.98]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BF459195608D; Tue, 29 Apr 2025 11:14:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745925278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J3+mmETqEHAbEznjPyeh1vcfwwNg7L0mxuFN6RrnEps=; b=KkG4bshp3r0vf2LiafR/hzyUWevPJXcha7SW5t7vSaHjtdCg7/g8FuAQ/oWK1GXuX06EP9 PL0v6gOXdbiiQPFvsjUjnUquPZ0IJyUYZh7qnZcN2sBxKYRc0bXZ24A5Zo8xQE63vDgWFA gsuoUOjPP5ijidfOrtq8B3j0xGBeUHQ= X-MC-Unique: ad7zj7rTOIurheh7mIk-Zw-1 X-Mimecast-MFC-AGG-ID: ad7zj7rTOIurheh7mIk-Zw_1745925276 To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 12/20] nodedev: remove use hardcoded MDEVCTL path Date: Tue, 29 Apr 2025 12:14:12 +0100 Message-ID: <20250429111420.1748521-13-berrange@redhat.com> In-Reply-To: <20250429111420.1748521-1-berrange@redhat.com> References: <20250429111420.1748521-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ECzAX7usKqoZupQ4SNXOyDMlHikhudaMQ57dW78euGk_1745925276 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: IHWIXLVPIYNRUFCLTACBEQ6T5VPWZLCI X-Message-ID-Hash: IHWIXLVPIYNRUFCLTACBEQ6T5VPWZLCI X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745925578724019000 Content-Type: text/plain; charset="utf-8" From: Daniel P. Berrang=C3=A9 Allow virCommand to find 'mdevctl' in $PATH. This command is only used when running privileged in which case both 'bin' and 'sbin' dirs will be in $PATH, so virFindFileInPath will do the right thing to find it. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- src/node_device/node_device_driver.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_de= vice_driver.c index 123b16a292..2c9e749495 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -744,14 +744,14 @@ nodeDeviceGetMdevctlCommand(virNodeDeviceDef *def, case MDEVCTL_CMD_CREATE: /* now is the time to make sure "create" is replaced with "start" = on * mdevctl cmdline */ - cmd =3D virCommandNewArgList(MDEVCTL, "start", NULL); + cmd =3D virCommandNewArgList("mdevctl", "start", NULL); break; case MDEVCTL_CMD_STOP: case MDEVCTL_CMD_START: case MDEVCTL_CMD_DEFINE: case MDEVCTL_CMD_UNDEFINE: case MDEVCTL_CMD_MODIFY: - cmd =3D virCommandNewArgList(MDEVCTL, subcommand, NULL); + cmd =3D virCommandNewArgList("mdevctl", subcommand, NULL); break; case MDEVCTL_CMD_LAST: default: @@ -901,7 +901,7 @@ nodeDeviceGetMdevctlModifySupportCheck(void) g_autoptr(virCommand) cmd =3D NULL; const char *subcommand =3D virMdevctlCommandTypeToString(MDEVCTL_CMD_M= ODIFY); =20 - cmd =3D virCommandNewArgList(MDEVCTL, + cmd =3D virCommandNewArgList("mdevctl", subcommand, "--defined", "--live", @@ -1130,7 +1130,7 @@ nodeDeviceGetMdevctlSetAutostartCommand(virNodeDevice= Def *def, bool autostart, char **errmsg) { - virCommand *cmd =3D virCommandNewArgList(MDEVCTL, + virCommand *cmd =3D virCommandNewArgList("mdevctl", "modify", "--uuid", def->caps->data.mdev.uuid, @@ -1176,7 +1176,7 @@ nodeDeviceGetMdevctlListCommand(bool defined, char **output, char **errmsg) { - virCommand *cmd =3D virCommandNewArgList(MDEVCTL, + virCommand *cmd =3D virCommandNewArgList("mdevctl", "list", "--dumpjson", NULL); @@ -1894,8 +1894,8 @@ nodeDeviceUpdateMediatedDevices(virNodeDeviceDriverSt= ate *node_driver) virMdevctlForEachData data =3D { 0, }; size_t i; =20 - if (!(mdevctl =3D virFindFileInPath(MDEVCTL))) { - VIR_DEBUG(MDEVCTL " not found. Skipping update of mediated devices= ."); + if (!(mdevctl =3D virFindFileInPath("mdevctl"))) { + VIR_DEBUG("'mdevctl' not found. Skipping update of mediated device= s."); return 0; } =20 --=20 2.49.0