From nobody Tue Sep 9 09:46:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1745925560; cv=none; d=zohomail.com; s=zohoarc; b=OtedqLR4AmzoAPM8VLjYxDrBYgnB1nLRp6H+u4WrV6gD7Dj8WR7kxTbI4h1uz/9DVXyI0KF5j3jaXQgyjZdVBzhZJGb+uEprl1j1qj/E970CJoyuMTnsUbF4nRhKxp51cAcJIb5r1hgBEfydH9YHaarmodFxv9PWOeO9E/DqNzM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1745925560; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=jClYo+6NfPGWgefJYmvUGjagblhAembQT85Mg4o4ezM=; b=fFzbX7uXW7z7UuduOfi4zd2TBEO69JUVkgceJC9wKsBuk2/q2hRK7PMHC46+niM3eCRzmnaR0ZHfGbqx54MoXF8exuvO/zRNLWeyBWJt0bc4cXiF44TLJAcV5Ib/9Zxa5QYKSHrzX5c1znlOlEC0oa4nitlr8SzvuWJdIbvOyLU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1745925560665281.37499364620385; Tue, 29 Apr 2025 04:19:20 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id BCECE1294; Tue, 29 Apr 2025 07:19:19 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 9DFD8142A; Tue, 29 Apr 2025 07:15:02 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 4FB1511C8; Tue, 29 Apr 2025 07:14:56 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AB41711C8 for ; Tue, 29 Apr 2025 07:14:38 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-205-RAcmGuw2PcWbmZJTqZrnCg-1; Tue, 29 Apr 2025 07:14:35 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 356ED19560A6 for ; Tue, 29 Apr 2025 11:14:34 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.98]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6EEE71956096; Tue, 29 Apr 2025 11:14:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745925278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FzYPg4CKAXVgKf9T6X/oHY00pY/bJXG1J8ikEYLI/Fw=; b=D9S1rbLYOP2C3r7ItkiGVpT7rNWuot1qoqSgTz0uQJ0AbKuYnVXjzlytdTPQGpi8f5aCXA CxxoAInczvp4tEDGOtr002P2fAbWRJOIqZAZYjnMY39MRB053cVscxaruT5UJclj469GJn u6qO12zOR/flK2AW3CC/y4kulh9mPr4= X-MC-Unique: RAcmGuw2PcWbmZJTqZrnCg-1 X-Mimecast-MFC-AGG-ID: RAcmGuw2PcWbmZJTqZrnCg_1745925274 To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 10/20] meson: remove check for 'ip' program Date: Tue, 29 Apr 2025 12:14:10 +0100 Message-ID: <20250429111420.1748521-11-berrange@redhat.com> In-Reply-To: <20250429111420.1748521-1-berrange@redhat.com> References: <20250429111420.1748521-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rjfOdCZAUespi3m7jdmYlBS8ZqqEuiagefLj6Rdvt6o_1745925274 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: H4YFLE5VPJKTSYY5UCKVMVOJ75IDNBFU X-Message-ID-Hash: H4YFLE5VPJKTSYY5UCKVMVOJ75IDNBFU X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745925563993019100 Content-Type: text/plain; charset="utf-8" From: Daniel P. Berrang=C3=A9 There are no references to an "IP" conf variable nor a meson 'ip_prog' variable so the check serves no purpose. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- meson.build | 1 - src/util/virnetdevip.c | 6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index 06a69308ac..d355767a53 100644 --- a/meson.build +++ b/meson.build @@ -854,7 +854,6 @@ optional_test_programs =3D [ ] =20 optional_programs =3D [ - 'ip', 'iscsiadm', 'mdevctl', 'mm-ctl', diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c index f7a7db620d..d4f023ca5c 100644 --- a/src/util/virnetdevip.c +++ b/src/util/virnetdevip.c @@ -404,7 +404,7 @@ virNetDevIPAddrAdd(const char *ifname, virCommandAddArgList(cmd, "broadcast", bcaststr, NULL); virCommandAddArg(cmd, "alias"); # else - cmd =3D virCommandNew(IP); + cmd =3D virCommandNew("ip"); virCommandAddArgList(cmd, "addr", "add", NULL); virCommandAddArgFormat(cmd, "%s/%u", addrstr, prefix); if (peerstr) @@ -441,7 +441,7 @@ virNetDevIPAddrDel(const char *ifname, virCommandAddArgFormat(cmd, "%s/%u", addrstr, prefix); virCommandAddArg(cmd, "-alias"); # else - cmd =3D virCommandNew(IP); + cmd =3D virCommandNew("ip"); virCommandAddArgList(cmd, "addr", "del", NULL); virCommandAddArgFormat(cmd, "%s/%u", addrstr, prefix); virCommandAddArgList(cmd, "dev", ifname, NULL); @@ -469,7 +469,7 @@ virNetDevIPRouteAdd(const char *ifname, return -1; if (!(gatewaystr =3D virSocketAddrFormat(gateway))) return -1; - cmd =3D virCommandNew(IP); + cmd =3D virCommandNew("ip"); virCommandAddArgList(cmd, "route", "add", NULL); virCommandAddArgFormat(cmd, "%s/%u", addrstr, prefix); virCommandAddArgList(cmd, "via", gatewaystr, "dev", ifname, --=20 2.49.0