From nobody Fri Dec 19 17:00:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1744909984; cv=none; d=zohomail.com; s=zohoarc; b=PI+G2ekjjYflmwpjJUEC72yjnnsIWHAaYUNhDco/QAJq92bPrKnWonGUhnYmZJvMVnorUX9nY8zVCzwnfWZ8TgoomMt6zJg67Yglj44LrtVDkEdk1TSBbBrVYxCAYDE1fbMONjJFbEvtaCylcpzwSqaOYGpFbLPWw3GPWEpf/OQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1744909984; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=MGJFW5lYJzzLz8KAE5Va3gedlAj13UIW5Hs2uNNsUkE=; b=TrByNDuepcO3Q/l2gZ+UCxMW7oAmhKagtgL1LOmGr89fcsQHGRAoPhetFKGoZ1XK/OL+lJTiTKhWBiv80P8svf9Xhvjkv/usAs+sle6rt48ZRlwd5SkwN6k86068zguBd2Hfm5pBboZ0xvFMFGHipnuDNH3Qu3uPx5qyze7tj8I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1744909984284798.7096399087266; Thu, 17 Apr 2025 10:13:04 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id AA5671213; Thu, 17 Apr 2025 13:13:03 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 6F3F111E2; Thu, 17 Apr 2025 13:12:16 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 29C9910F5; Thu, 17 Apr 2025 13:12:09 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id A6A65E77 for ; Thu, 17 Apr 2025 13:12:07 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-116-YvfyS7oMObSvefQIuxv0YA-1; Thu, 17 Apr 2025 13:12:04 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 67134195608C for ; Thu, 17 Apr 2025 17:12:03 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.151]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D40CC30002C2; Thu, 17 Apr 2025 17:12:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744909927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+UwAiVrLRk9H1KWaVBf6soEq+IX57NtFf67gbq28rFQ=; b=ZcayW/c1YmhfDiKoI+ZXdwfiEYe0/Oy97sKuJBK/PIVyHEfx4wpjEtQjIH4iRrLz+6pR1h g1AVPhzL5EI/sFkdhEBXF/M3HeorU6s5S+Kdhdv9a6UgZuVj44sDFDc2zbJsOfwTKS9ntT SvhU8A2HeU51uJzDgJemCabKi3NnTx0= X-MC-Unique: YvfyS7oMObSvefQIuxv0YA-1 X-Mimecast-MFC-AGG-ID: YvfyS7oMObSvefQIuxv0YA_1744909923 To: devel@lists.libvirt.org Cc: rjones@redhat.com, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 1/3] remote: improve error message when no URI is set Date: Thu, 17 Apr 2025 18:11:56 +0100 Message-ID: <20250417171158.1729829-2-berrange@redhat.com> In-Reply-To: <20250417171158.1729829-1-berrange@redhat.com> References: <20250417171158.1729829-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HAZiGF8T1UxYaawLM82-JEvxwkNn3lwOqC8yXVn4xNc_1744909923 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BXQDBMJINTKNVF5H7TK4QZWDXLKQGT3J X-Message-ID-Hash: BXQDBMJINTKNVF5H7TK4QZWDXLKQGT3J X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1744909984864019000 Content-Type: text/plain; charset="utf-8" From: Daniel P. Berrang=C3=A9 When no URI is set we try to guess what daemon to connect to by looking for any listening sockets. If there are no listening sockets, however, we don't even know what daemon the user expected to connect to. The error message in this case is not especially clear This tweaks the error message to try to make the problem easier to understand. Signed-off-by: Daniel P. Berrang=C3=A9 --- src/remote/remote_sockets.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote/remote_sockets.c b/src/remote/remote_sockets.c index 8d403b6f01..4e6d19098c 100644 --- a/src/remote/remote_sockets.c +++ b/src/remote/remote_sockets.c @@ -398,7 +398,7 @@ remoteGetUNIXSocket(remoteDriverTransport transport, =20 if (!direct_sock_name) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", - _("Cannot use direct socket mode if no URI is s= et. For more information see https://libvirt.org/kbase/failed_connection_af= ter_install.html")); + _("No URI is provided and cannot identify any l= istening daemon socket path to attempt to connect to. Please ensure the exp= ected daemon sockets are active and/or provide an explicit URI. For more in= formation see https://libvirt.org/kbase/failed_connection_after_install.htm= l")); return NULL; } =20 --=20 2.48.1