From nobody Fri Dec 19 02:49:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1744909984; cv=none; d=zohomail.com; s=zohoarc; b=PI+G2ekjjYflmwpjJUEC72yjnnsIWHAaYUNhDco/QAJq92bPrKnWonGUhnYmZJvMVnorUX9nY8zVCzwnfWZ8TgoomMt6zJg67Yglj44LrtVDkEdk1TSBbBrVYxCAYDE1fbMONjJFbEvtaCylcpzwSqaOYGpFbLPWw3GPWEpf/OQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1744909984; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=MGJFW5lYJzzLz8KAE5Va3gedlAj13UIW5Hs2uNNsUkE=; b=TrByNDuepcO3Q/l2gZ+UCxMW7oAmhKagtgL1LOmGr89fcsQHGRAoPhetFKGoZ1XK/OL+lJTiTKhWBiv80P8svf9Xhvjkv/usAs+sle6rt48ZRlwd5SkwN6k86068zguBd2Hfm5pBboZ0xvFMFGHipnuDNH3Qu3uPx5qyze7tj8I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1744909984284798.7096399087266; Thu, 17 Apr 2025 10:13:04 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id AA5671213; Thu, 17 Apr 2025 13:13:03 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 6F3F111E2; Thu, 17 Apr 2025 13:12:16 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 29C9910F5; Thu, 17 Apr 2025 13:12:09 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id A6A65E77 for ; Thu, 17 Apr 2025 13:12:07 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-116-YvfyS7oMObSvefQIuxv0YA-1; Thu, 17 Apr 2025 13:12:04 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 67134195608C for ; Thu, 17 Apr 2025 17:12:03 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.151]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D40CC30002C2; Thu, 17 Apr 2025 17:12:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744909927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+UwAiVrLRk9H1KWaVBf6soEq+IX57NtFf67gbq28rFQ=; b=ZcayW/c1YmhfDiKoI+ZXdwfiEYe0/Oy97sKuJBK/PIVyHEfx4wpjEtQjIH4iRrLz+6pR1h g1AVPhzL5EI/sFkdhEBXF/M3HeorU6s5S+Kdhdv9a6UgZuVj44sDFDc2zbJsOfwTKS9ntT SvhU8A2HeU51uJzDgJemCabKi3NnTx0= X-MC-Unique: YvfyS7oMObSvefQIuxv0YA-1 X-Mimecast-MFC-AGG-ID: YvfyS7oMObSvefQIuxv0YA_1744909923 To: devel@lists.libvirt.org Cc: rjones@redhat.com, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 1/3] remote: improve error message when no URI is set Date: Thu, 17 Apr 2025 18:11:56 +0100 Message-ID: <20250417171158.1729829-2-berrange@redhat.com> In-Reply-To: <20250417171158.1729829-1-berrange@redhat.com> References: <20250417171158.1729829-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HAZiGF8T1UxYaawLM82-JEvxwkNn3lwOqC8yXVn4xNc_1744909923 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BXQDBMJINTKNVF5H7TK4QZWDXLKQGT3J X-Message-ID-Hash: BXQDBMJINTKNVF5H7TK4QZWDXLKQGT3J X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1744909984864019000 Content-Type: text/plain; charset="utf-8" From: Daniel P. Berrang=C3=A9 When no URI is set we try to guess what daemon to connect to by looking for any listening sockets. If there are no listening sockets, however, we don't even know what daemon the user expected to connect to. The error message in this case is not especially clear This tweaks the error message to try to make the problem easier to understand. Signed-off-by: Daniel P. Berrang=C3=A9 --- src/remote/remote_sockets.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote/remote_sockets.c b/src/remote/remote_sockets.c index 8d403b6f01..4e6d19098c 100644 --- a/src/remote/remote_sockets.c +++ b/src/remote/remote_sockets.c @@ -398,7 +398,7 @@ remoteGetUNIXSocket(remoteDriverTransport transport, =20 if (!direct_sock_name) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", - _("Cannot use direct socket mode if no URI is s= et. For more information see https://libvirt.org/kbase/failed_connection_af= ter_install.html")); + _("No URI is provided and cannot identify any l= istening daemon socket path to attempt to connect to. Please ensure the exp= ected daemon sockets are active and/or provide an explicit URI. For more in= formation see https://libvirt.org/kbase/failed_connection_after_install.htm= l")); return NULL; } =20 --=20 2.48.1 From nobody Fri Dec 19 02:49:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1744909964; cv=none; d=zohomail.com; s=zohoarc; b=g9XVniU6NfYK6h05nhEzf8TT2DnzdUUMEKhCe+kdFGUuf26Lj3MwD3vvNZe8WxQwbQuYYVRyT+kISm5B0Tv7NBVCH/oSIp+N1mXjONWZlvYlPrW4ZffPQsBLB9p/4iryvSMsEIlnDHGP+uU9iy+Y0zFv4ewe7L+YGD37PrIZa6g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1744909964; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=BDrMzOUsT69bMGAm/yQ9j+p6qSi1COG4kp8hPLMgtvM=; b=dAj9cY3WuhBMq/ZJC2eSLQmHetDr3oi3sXhdeRpBpzd1lqrtsXlAZ6EGjTEyRrTRwU1TPiUv0ULTqTAPK2quJsUA6VruRmZiHaRfkxQChHtQT6q64qE8Y+7rfMW50DyeS1lM6T97WUP2jiEC3BXk2Gh1DHw0jEoriVALs5ks4wU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1744909964621675.9349536197118; Thu, 17 Apr 2025 10:12:44 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 00B651258; Thu, 17 Apr 2025 13:12:43 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 941741285; Thu, 17 Apr 2025 13:12:13 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 19FE1E77; Thu, 17 Apr 2025 13:12:09 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id EBA67C86 for ; Thu, 17 Apr 2025 13:12:07 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-271-SMvKYO-xPIutafBRAS_0VQ-1; Thu, 17 Apr 2025 13:12:06 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 65D511800876 for ; Thu, 17 Apr 2025 17:12:05 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.151]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 12D6F30002C2; Thu, 17 Apr 2025 17:12:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744909927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ccKPOBqO6pbgwF5GyGTcEcHbWy261JF2Lp71csaIu5c=; b=hNgcrzXQFWPEd04s6xdGy+/Q/ujrLmj+chK5nAb1Zo8ljL7sTKjU38Dv+V4rLwbAbfJwSP bMo6DDSG7v/NDq2sLyC13NbzVHGcdG2Uw3/e5etIOQZ2mxw2mFgLoDtmUvBguNjj+6di8Y dUH4tgvnKE5P73nV1DLSRtCUBsfZzF4= X-MC-Unique: SMvKYO-xPIutafBRAS_0VQ-1 X-Mimecast-MFC-AGG-ID: SMvKYO-xPIutafBRAS_0VQ_1744909925 To: devel@lists.libvirt.org Cc: rjones@redhat.com, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 2/3] kbase: update docs to account for changed error message Date: Thu, 17 Apr 2025 18:11:57 +0100 Message-ID: <20250417171158.1729829-3-berrange@redhat.com> In-Reply-To: <20250417171158.1729829-1-berrange@redhat.com> References: <20250417171158.1729829-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZmxsCXshPwbSgK_s9qtq7W5FFOJf7MmtMfGaPF3x1HY_1744909925 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 4LRTUFPF3T6UNNQQ2P7L4NHL7ZWPUWRS X-Message-ID-Hash: 4LRTUFPF3T6UNNQQ2P7L4NHL7ZWPUWRS X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1744909967729019000 Content-Type: text/plain; charset="utf-8" From: Daniel P. Berrang=C3=A9 The updated doc refers to both the old and new error message, as users with old deployed versions will still be pointed to the current online docs URL. Signed-off-by: Daniel P. Berrang=C3=A9 --- docs/kbase/failed_connection_after_install.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/kbase/failed_connection_after_install.rst b/docs/kbase/fa= iled_connection_after_install.rst index cea57c460e..f2c6fee72d 100644 --- a/docs/kbase/failed_connection_after_install.rst +++ b/docs/kbase/failed_connection_after_install.rst @@ -28,6 +28,16 @@ not work when run as root: error: Operation not supported: Cannot use direct socket mode if no URI= is set. For more information see https://libvirt.org/kbase/failed_connection_af= ter_install.html =20 +Or + +:: + + # virsh list + error: failed to connect to the hypervisor + error: Operation not supported: No URI is provided and cannot identify = any listening + daemon socket path to attempt to connect to. For more information see + https://libvirt.org/kbase/failed_connection_after_install.html + Root cause =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 --=20 2.48.1 From nobody Fri Dec 19 02:49:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1744910001; cv=none; d=zohomail.com; s=zohoarc; b=mA6OOANzGwsMYoF8azplGv/YQHynGG2Cnq2PeCowtmvbBeehFSAwTjj7gAOIUCHgbd5wqSDUc4G8FEuW3EefOoi1p5Yl1vKcSIXvNflhxlWSBPtzfNBVBrVPFDELzXSl1JNOQ+1wrSxezpnHZIPlIWVFyGyQJ+lgQ2Fnvb7tgZY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1744910001; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=j/q28SeWn1v+OFH318xdQY3QIjTM0qnzyh/m0XCwXqw=; b=LYLTkRBWy3nzQDXOh4Kh0XcHyckfY//IB7R+xBqDlm7tc20nmpzaj1lSH2GFUcne3tHrCx02FUYikMJbUrbtouCZ3j8qmL8JMgPDU/mgecG0uBNGtn+8hZ/6uJlfToUkaLrmdsjg/kIF8RqZiTX3ka5TlTE7smy8Yr5umZNw7/M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1744910001579186.23048695204966; Thu, 17 Apr 2025 10:13:21 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id EE2ED110D; Thu, 17 Apr 2025 13:13:20 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 5ABF51248; Thu, 17 Apr 2025 13:12:25 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id C1F5E11D9; Thu, 17 Apr 2025 13:12:21 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 2D9A2126C for ; Thu, 17 Apr 2025 13:12:11 -0400 (EDT) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-424--RgHnUJUMOKmejEnUXuriw-1; Thu, 17 Apr 2025 13:12:08 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1FF281955DC6 for ; Thu, 17 Apr 2025 17:12:07 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.151]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E92C130002CA; Thu, 17 Apr 2025 17:12:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744909930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eEmxj4620uCx/HrmyiI8OZSp0TWJyr6dwFFAC9jq3Cs=; b=BApv9/G71Dy/0HuTdIbwf542ZpQkzoIJ7TKxi4Fwphwj3t/j12xn24Dhzh9WRKo3H6ylRq +sNsTI2/4msLgAHj1YseKbU+2V/3XB8a5bLVCcsXetybyu+CcaMnCUqatwTu8zH1O6fxNH y4ZLRzzVvBnnQ0TLx4fAQ7p/WuKDZ0I= X-MC-Unique: -RgHnUJUMOKmejEnUXuriw-1 X-Mimecast-MFC-AGG-ID: -RgHnUJUMOKmejEnUXuriw_1744909927 To: devel@lists.libvirt.org Cc: rjones@redhat.com, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 3/3] remote: expand some debug messages for socket detection Date: Thu, 17 Apr 2025 18:11:58 +0100 Message-ID: <20250417171158.1729829-4-berrange@redhat.com> In-Reply-To: <20250417171158.1729829-1-berrange@redhat.com> References: <20250417171158.1729829-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: omcEuKCfd9qOlmL7j_QDRrjyYKp8Y8U4KGfm7feLo_c_1744909927 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KREJS7GOOYS45YDW3M7FTDQCTOIC65WC X-Message-ID-Hash: KREJS7GOOYS45YDW3M7FTDQCTOIC65WC X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1744910004098019000 Content-Type: text/plain; charset="utf-8" From: Daniel P. Berrang=C3=A9 Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Richard W.M. Jones --- src/remote/remote_sockets.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_sockets.c b/src/remote/remote_sockets.c index 4e6d19098c..b3f6cd6a42 100644 --- a/src/remote/remote_sockets.c +++ b/src/remote/remote_sockets.c @@ -317,7 +317,7 @@ remoteGetUNIXSocket(remoteDriverTransport transport, VIR_DEBUG("Choosing remote socket for transport=3D%s mode=3D%s driver= =3D%s flags=3D0x%x", remoteDriverTransportTypeToString(transport), remoteDriverModeTypeToString(mode), - driver, flags); + NULLSTR(driver), flags); =20 #ifdef REMOTE_DRIVER_AUTOSTART_DIRECT if (!driver && mode !=3D REMOTE_DRIVER_MODE_LEGACY) { @@ -342,6 +342,7 @@ remoteGetUNIXSocket(remoteDriverTransport transport, return NULL; } driver =3D guessdriver; + VIR_DEBUG("Guessed driver %s", NULLSTR(driver)); } #endif =20 @@ -354,6 +355,9 @@ remoteGetUNIXSocket(remoteDriverTransport transport, legacy_sock_name =3D remoteGetUNIXSocketHelper(transport, "libvirt", f= lags); =20 if (mode =3D=3D REMOTE_DRIVER_MODE_AUTO) { + VIR_DEBUG("Resolving mode=3Dauto direct_daemon=3D%s direct_sock=3D= %s legacy_daemon=3D%s legacy_sock=3D%s", + NULLSTR(direct_daemon), NULLSTR(direct_sock_name), + NULLSTR(legacy_daemon), NULLSTR(legacy_sock_name)); if (transport =3D=3D REMOTE_DRIVER_TRANSPORT_UNIX) { /* * When locally accessing libvirtd, we pick legacy or @@ -380,6 +384,7 @@ remoteGetUNIXSocket(remoteDriverTransport transport, */ mode =3D REMOTE_DRIVER_MODE_LEGACY; } + VIR_DEBUG("Resolved mode=3D%s", remoteDriverModeTypeToString(mode)= ); } =20 switch ((remoteDriverMode)mode) { --=20 2.48.1