From nobody Sun Feb 8 13:50:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1744523847158836.046010429605; Sat, 12 Apr 2025 22:57:27 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3032B151E; Sun, 13 Apr 2025 01:57:26 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 776551714; Sun, 13 Apr 2025 01:56:58 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id E405F1777; Sun, 13 Apr 2025 01:56:54 -0400 (EDT) Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 990D41777 for ; Sun, 13 Apr 2025 01:56:47 -0400 (EDT) Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5e5cded3e2eso5091910a12.0 for ; Sat, 12 Apr 2025 22:56:47 -0700 (PDT) Received: from tulp.my.domain (80-115-115-199.cable.dynamic.v4.ziggo.nl. [80.115.115.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1bb2ed4sm696960966b.34.2025.04.12.22.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 22:56:45 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744523806; x=1745128606; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p1YndnVwkYqrzIY/2hayq8C/4PTo76ExQX5mlIs5isQ=; b=JFukTKJxuCJkMaE+ZEssQavyEbIk/XOyYFD3iuRA74RAJ30eAQXY65xpKmMzbSkcBd gxXngXyO3zcPGWUldv2ypXXYv3jtkvnfPKiaJR8w/ElfCvlAehkkOxdRn88Un6OlUm4A EfuyUjIfQ2FEjDcCFLkBGechAr/txWcefH6BMRGEWYXJaMhZ0XRq0NhzUDskFs7jph5g fkJKDsB4UoG1OoHMXRY8XFI7tIzKVeYdn58NblD791AM2cTyLVfH8ccEEpIsqgkjTpX9 fwYv0BeCblV8Ofhv2dCwcX8kM4v3UME7yC0CxC6y2yQMc3e0XlGoGAwgkNOp4uo4qF6d IitQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744523806; x=1745128606; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p1YndnVwkYqrzIY/2hayq8C/4PTo76ExQX5mlIs5isQ=; b=VC/0/agJBsvR88aWKKCYGyabehh4yF45yFdAN+8hZEVZoGpP0Rwka1ab89wg8ueJex ScY+UntRwXthvRzjolgh5OGFldDIqwHaAJW9XKdEdeilwVJZkdMTFOyVfytEaoJuNQUL bPCw+T7VGXYRwaVKNsGjCYavy0GQmJm6V4uN7GDYnvvB7NDWutc1e3NiJDubAAwOKPpX 3Cape4Uc34na+sEqKAf5VKTa/A9ccgTO7EIY1JCRi27wXzRDTDsB2G+GeFycUUQ3szhL sofOSPGOT78j25wZP4QcjM1tbiJEMpBTB742d9RXluj/D6Qk4f8CDoQXAioFjG6Nke11 kmWQ== X-Gm-Message-State: AOJu0YxHHdyQK1oATKb8iSKUwHQEECcFZB7Heyc2Lz0Pa9/vnJzfGiqe R/uHsEI6v18ISA/iiTPV5s5yJ+oG4ZP9Y4xHZb8m0TeoHJLPK/UQfahvXT3HG+xo0g== X-Gm-Gg: ASbGncsSthfSr4j6rXxrzloJ3WTcUHF9ROis80kVUrJUd8LN5W/VsRMmRlW+/TfP/ah fa5UHyKVEK+Dka1DuxfBg9qpGeFqqhVhB1qlY9+d+MJ0h2qLLKWjzE/19/GfCP+KEkiEuGh/iHr MRufE7LxKszcvSFhAS50Tqa49uvPYhhGmvJYaB/xAS/QBJnBBwyKl01dZeaA4HPrADOs8P8XR3/ CUYQfHLlUFCzXa4C3WdXXlypeTAQeHXU5Huanc2vuNOrdcV3i2kyvwOH+itElilZ3J9AEJQ6/1R DwoCPyNwuOH1wZF5jzp2JLKHNXO/ZpymPAd+DcMUTKKOibYVEbQDl+/ZpM5wyB5opKygeCAr31N DaIux+EPgakS7LitLg5GtUOd+ X-Google-Smtp-Source: AGHT+IHnHb6NLDdP+NNfpM9FPk2G9zbsqdRqz0FeN0l4CFBu5A2c4zr5V2dbw7056Z4VRs8NYMqOyg== X-Received: by 2002:a17:906:6a25:b0:ac3:17bb:34fc with SMTP id a640c23a62f3a-acad36d89f6mr617733766b.52.1744523805704; Sat, 12 Apr 2025 22:56:45 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH v2 1/2] conf: use const virDomainDef pointers Date: Sun, 13 Apr 2025 07:52:41 +0200 Message-ID: <20250413055242.699-2-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250413055242.699-1-bogorodskiy@gmail.com> References: <20250413055242.699-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: A4Z4PVB7ICMJ7DDBEBELMSLANYMYVVIM X-Message-ID-Hash: A4Z4PVB7ICMJ7DDBEBELMSLANYMYVVIM X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1744523848550019100 Content-Type: text/plain; charset="utf-8" Some virDomainNet* functions use virDomainDef pointers even though they don't modify the domain config, so switch to const pointers there. Signed-off-by: Roman Bogorodskiy Reviewed-by: J=C3=A1n Tomko --- src/conf/domain_conf.c | 10 +++++----- src/conf/domain_conf.h | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c724638180..542d6ade91 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -31002,7 +31002,7 @@ virDomainNetTypeSharesHostView(const virDomainNetDe= f *net) } =20 virNetworkPortDef * -virDomainNetDefToNetworkPort(virDomainDef *dom, +virDomainNetDefToNetworkPort(const virDomainDef *dom, virDomainNetDef *iface) { g_autoptr(virNetworkPortDef) port =3D NULL; @@ -31128,7 +31128,7 @@ virDomainNetDefActualFromNetworkPort(virDomainNetDe= f *iface, } =20 virNetworkPortDef * -virDomainNetDefActualToNetworkPort(virDomainDef *dom, +virDomainNetDefActualToNetworkPort(const virDomainDef *dom, virDomainNetDef *iface) { virDomainActualNetDef *actual; @@ -31240,7 +31240,7 @@ virDomainNetDefActualToNetworkPort(virDomainDef *do= m, =20 static int virDomainNetCreatePort(virConnectPtr conn, - virDomainDef *dom, + const virDomainDef *dom, virDomainNetDef *iface, unsigned int flags) { @@ -31305,7 +31305,7 @@ virDomainNetCreatePort(virConnectPtr conn, =20 int virDomainNetAllocateActualDevice(virConnectPtr conn, - virDomainDef *dom, + const virDomainDef *dom, virDomainNetDef *iface) { return virDomainNetCreatePort(conn, dom, iface, 0); @@ -31313,7 +31313,7 @@ virDomainNetAllocateActualDevice(virConnectPtr conn, =20 void virDomainNetNotifyActualDevice(virConnectPtr conn, - virDomainDef *dom, + const virDomainDef *dom, virDomainNetDef *iface) { virDomainNetType actualType =3D virDomainNetGetActualType(iface); diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 8dfadbb98d..58b97a2b54 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -4531,7 +4531,7 @@ virDomainDefLifecycleActionAllowed(virDomainLifecycle= type, virDomainLifecycleAction action); =20 virNetworkPortDef * -virDomainNetDefToNetworkPort(virDomainDef *dom, +virDomainNetDefToNetworkPort(const virDomainDef *dom, virDomainNetDef *iface); =20 int @@ -4539,18 +4539,18 @@ virDomainNetDefActualFromNetworkPort(virDomainNetDe= f *iface, virNetworkPortDef *port); =20 virNetworkPortDef * -virDomainNetDefActualToNetworkPort(virDomainDef *dom, +virDomainNetDefActualToNetworkPort(const virDomainDef *dom, virDomainNetDef *iface); =20 int virDomainNetAllocateActualDevice(virConnectPtr conn, - virDomainDef *dom, + const virDomainDef *dom, virDomainNetDef *iface) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); =20 void virDomainNetNotifyActualDevice(virConnectPtr conn, - virDomainDef *dom, + const virDomainDef *dom, virDomainNetDef *iface) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3); =20 --=20 2.49.0 From nobody Sun Feb 8 13:50:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1744523869169560.0321215728652; Sat, 12 Apr 2025 22:57:49 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 238F8168D; Sun, 13 Apr 2025 01:57:48 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 6A3271526; Sun, 13 Apr 2025 01:57:02 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id B41C5155E; Sun, 13 Apr 2025 01:56:57 -0400 (EDT) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 058211710 for ; Sun, 13 Apr 2025 01:56:50 -0400 (EDT) Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5e5deb6482cso8151272a12.1 for ; Sat, 12 Apr 2025 22:56:49 -0700 (PDT) Received: from tulp.my.domain (80-115-115-199.cable.dynamic.v4.ziggo.nl. [80.115.115.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1bb2ed4sm696960966b.34.2025.04.12.22.56.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 22:56:47 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744523808; x=1745128608; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=09gtSza+eBhYHKYXPjjxn4Nr1B3oT58c0YDjV3uzuqM=; b=A294N9/JMXyyhQXwCTy0OKSSstnbvydXX/Dx30KWGs4zUlJscRZtLCPgTIA3udBXr2 jd3nDjLYU3lT1CCzuSlcaQ+a1mBLVbr6qqtHb5UWRniqh2xAOMFGlby09+mS0dF8m7TX LTA5qkj6PE876lM4DKxYeVbfdT3hHZQYabMLzlyOuVezj9zsU7SZHw8yVg3s2euepU7i kqZN9tFZGloIDTO40TE0nivgUWsaMezI0jl100g+6ahccGG3ihifJ0YbUd5XBQsDDk82 XFtcm4e8yjUi43GyK68CUX4WG4KQixXqm2I5h/zdWENs/RKBPDgwjFYgCA1CjWQX2NzD Mt/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744523808; x=1745128608; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=09gtSza+eBhYHKYXPjjxn4Nr1B3oT58c0YDjV3uzuqM=; b=sx07e5hnKundh3yfsztJM0m9tcy7urhDmuktp2LPnQCfE76fkmmpRu4+rcuaULqfpt BMVY5HueT6elyHgndLXOhtLx6hGZ7+cXkpOqydUDDMmnvHep3YgQCcWwK2nBDhDwDFNk 3bH0+gGwr7+yhkkoeXKPKKOCBk0GlG3HcR0fyDpFhus5xyDP73ieZTJCjhzgqm3oLaTN m73+28+nC01bVQ2FW/d4oJx5rQi+82LIX67S6IJSvtvfNrczGmeI5Bisxth5X7gQ1d+f hSIGfuAYoT7jMZGQ5SH4hQe+EY1gz5BlMmmMF1VYl66dEsbzJWxRRg2g7d9gfkrC1ueL +Rgg== X-Gm-Message-State: AOJu0Yyh1i90mcuDfAwljCxvaiWZSy2OGp5RximVajUKJwPkZ0RLthSk O1CSHcMTZqMZIN1TfelRip5fQ4GgnFdZklmXviqOS3WVKs+SO/TeaCDITn4w7KPQdw== X-Gm-Gg: ASbGnctKcYzmXxkhvj7l8fKP7dTTVlN+MRj/GrW+mgpk2cgL6SPVFlOPVrKPOJB6SVP wXbZvxfSbJHRLCuvInT4RDGDd7B96GvG97IK0oVUcm+cPOXaNud3Lb1HbZye0syRdP8yuSwYebI NI3SocCYZCxdWWY7+aHEIen61cy8ZK4t1OxI1lqwNQMMX0ZtnLPcpXWlto3XiU8pWp2s6EATAxf 2gWY++O4B0WcDpaE3mLd0fkGAU85i7gol3qvhx/Ix5roupasWMx2KYSousnGV2sgFdaEJa16SP2 c58Gy2xdy4xsrG4pKcSYAGUtjZxb1nuf9hmv53VPVSoDgAVQ7hx5uolHSYUi1Pb1wO3K+/2nulJ HL7pQj+fZ2xxZJQ== X-Google-Smtp-Source: AGHT+IH1kZJa6/KB2RLjtyogCtuWv1B60+3uvFbp7bM/hHqbOAMCRpIsL4GJsBKeHKvc2+DjCB5alQ== X-Received: by 2002:a17:907:9805:b0:ac7:b231:9554 with SMTP id a640c23a62f3a-acad166d1eamr715934266b.11.1744523807832; Sat, 12 Apr 2025 22:56:47 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH v2 2/2] bhyve: use const virDomainDef pointer in bhyveBuildNetArgStr() Date: Sun, 13 Apr 2025 07:52:42 +0200 Message-ID: <20250413055242.699-3-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250413055242.699-1-bogorodskiy@gmail.com> References: <20250413055242.699-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: D7T426FR2NA2RMHRSR74YAQL7U5KNGNE X-Message-ID-Hash: D7T426FR2NA2RMHRSR74YAQL7U5KNGNE X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1744523870626019100 Content-Type: text/plain; charset="utf-8" As virDomainNet* functions were converted to use const virDomainDef pointers, update bhyveBuildNetArgStr() as well, like it was before it was changed in e1e40b5035. Signed-off-by: Roman Bogorodskiy Reviewed-by: J=C3=A1n Tomko --- src/bhyve/bhyve_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index b9f4a15200..6578a4326c 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -42,7 +42,7 @@ VIR_LOG_INIT("bhyve.bhyve_command"); =20 static int -bhyveBuildNetArgStr(virDomainDef *def, +bhyveBuildNetArgStr(const virDomainDef *def, virDomainNetDef *net, struct _bhyveConn *driver, virCommand *cmd, --=20 2.49.0