From nobody Sun Feb 8 14:28:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1744296776630599.3688456798371; Thu, 10 Apr 2025 07:52:56 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id E92C117B9; Thu, 10 Apr 2025 10:52:55 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 0BA3917C9; Thu, 10 Apr 2025 10:52:37 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A809C17A1; Thu, 10 Apr 2025 10:52:33 -0400 (EDT) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 780E117A6 for ; Thu, 10 Apr 2025 10:52:32 -0400 (EDT) Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-aaf0f1adef8so166395966b.3 for ; Thu, 10 Apr 2025 07:52:32 -0700 (PDT) Received: from tulp.my.domain (80-115-115-199.cable.dynamic.v4.ziggo.nl. [80.115.115.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1bea8d5sm288037966b.71.2025.04.10.07.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 07:52:29 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744296751; x=1744901551; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1C6r/o/4jF4qF5oGNilIMzs0X8ELd+Q/y04ELvq8QfE=; b=Zg5/5XT1PR2TbThh0fiqxdKtY10Do87MzbDkxR8gxaJ/dA709mEy9Roeb/6zbKS6sa gVpvC8+Oz7fV2BdsH2kwcm5gKPlDP7/m/JjwGFT+LUgaUMOa4mfS4lV9ZnecOgvBPVkX ZZjL6AooX8oGgygUJw721IzXb1ufv88rNpH/RMrkiFHV0G8+dzw0SBFljkvlwUZaQMdH L7xsTGKA0scvneYRbQ2wnDEQnKuUkJXZJIqOqq+/ynO4cWC/IIFsJ06lQ/GjUTOR3Q63 8sjukHyq/oPnQnAP6zSGUgXlTC+rD6NCzUXdzE15GAZynlIVeEADbQIoBvZuMvuTDgh9 d3TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744296751; x=1744901551; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1C6r/o/4jF4qF5oGNilIMzs0X8ELd+Q/y04ELvq8QfE=; b=ObuHXFLdyu1CZskOD2T+VjRHjtJRTrAfCMsIzbrnhVqN3kII2lAWbRPvPY7XZSS5Mt hReUXy5hMxFaIq7is117m/iDqQPuzbR2LyPyi02yXNmvm3/XIVFHrEtaufcGPG4WABj2 JSXYhzqNwV22hXo3b+62TKlR3HpR8OpfwbyzVQVUVlVWLgoW5Zm3LCBVxXDJqN6hcLQT gozFgBxenUoi969rUoiq08J6KBmkBN98rp/AIp23JG2IkRQZYrb7Uo1ZfNfTyI3Nkztp s1stzra+sL3igrRmstQt0ZtHFAkcIlb5aCNZu09Ou2CL67vauUvazOk0uZeUKeVBticd WLCQ== X-Gm-Message-State: AOJu0YwfK4CpONmzNaLYeZmkTL/PTcU4egA9GnjBMm3DcaWS7xIGRBMl ZaFvPRbXmWRjQqaOLPEupIV+MYUStvyYH0myP9U0n0QJYhkky/FisnhqremRn4V6UA== X-Gm-Gg: ASbGncvfhhC08k+tlkiiXNrhnpe+T4Dix0SeIei4K/MVPbyFSu+1TiXiGlPZjakQid2 9RzvgPfFsq5oxkQAsnWoRL2Q7AO3ShQPF8L/3K0qyJ7ZqJkl9kqyRVhwiAParYmDNFf/opbNHUU tItIEI2QqBtJAaw6eytN6bNff/p2cbV1bM8f6QkEdz3UziJHpo/RMx06wcEeQPqp1aCmn8a7v7A Jw1PFJqk0GEI+ot2iVIm6ZDNcweYAe33nAKQ7dW79JNyUzyF3MU+bXMRxJL4T2RddWLXfDjz854 3sFD2jWJ5HIci/v3E5kzT2Af425MpZ50lFLpQtDWRCx71iUw6eZVrSbOQV0b6FHiJLUBNXs4AGM CEREpoA6Zu20bzg== X-Google-Smtp-Source: AGHT+IGb042XqvitikW250MGuOUSK1kb/m3vUmQB+T31ebT17BhGJanv7Esqi5PW2p4BzntWT4D+DA== X-Received: by 2002:a17:907:f818:b0:ac7:333a:a5bb with SMTP id a640c23a62f3a-acac033259amr274568666b.39.1744296750584; Thu, 10 Apr 2025 07:52:30 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH] conf: use const virDomainDef pointers Date: Thu, 10 Apr 2025 16:48:48 +0200 Message-ID: <20250410144848.17629-1-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: Z7PQDGP7G64FEFZ2CAJQTIPIT265MUIO X-Message-ID-Hash: Z7PQDGP7G64FEFZ2CAJQTIPIT265MUIO X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1744296777621019000 Content-Type: text/plain; charset="utf-8" Some virDomainNet* functions use virDomainDef pointers even though they don't modify the domain config, so switch to const pointers there. This also allows to use the const pointer again in bhyveBuildNetArgStr() after it was changed in e1e40b5035. Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_command.c | 2 +- src/conf/domain_conf.c | 8 ++++---- src/conf/domain_conf.h | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index b9f4a15200..6578a4326c 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -42,7 +42,7 @@ VIR_LOG_INIT("bhyve.bhyve_command"); =20 static int -bhyveBuildNetArgStr(virDomainDef *def, +bhyveBuildNetArgStr(const virDomainDef *def, virDomainNetDef *net, struct _bhyveConn *driver, virCommand *cmd, diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c724638180..c1793334a9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -31002,7 +31002,7 @@ virDomainNetTypeSharesHostView(const virDomainNetDe= f *net) } =20 virNetworkPortDef * -virDomainNetDefToNetworkPort(virDomainDef *dom, +virDomainNetDefToNetworkPort(const virDomainDef *dom, virDomainNetDef *iface) { g_autoptr(virNetworkPortDef) port =3D NULL; @@ -31128,7 +31128,7 @@ virDomainNetDefActualFromNetworkPort(virDomainNetDe= f *iface, } =20 virNetworkPortDef * -virDomainNetDefActualToNetworkPort(virDomainDef *dom, +virDomainNetDefActualToNetworkPort(const virDomainDef *dom, virDomainNetDef *iface) { virDomainActualNetDef *actual; @@ -31240,7 +31240,7 @@ virDomainNetDefActualToNetworkPort(virDomainDef *do= m, =20 static int virDomainNetCreatePort(virConnectPtr conn, - virDomainDef *dom, + const virDomainDef *dom, virDomainNetDef *iface, unsigned int flags) { @@ -31305,7 +31305,7 @@ virDomainNetCreatePort(virConnectPtr conn, =20 int virDomainNetAllocateActualDevice(virConnectPtr conn, - virDomainDef *dom, + const virDomainDef *dom, virDomainNetDef *iface) { return virDomainNetCreatePort(conn, dom, iface, 0); diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 8dfadbb98d..ff8c6abdd0 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -4531,7 +4531,7 @@ virDomainDefLifecycleActionAllowed(virDomainLifecycle= type, virDomainLifecycleAction action); =20 virNetworkPortDef * -virDomainNetDefToNetworkPort(virDomainDef *dom, +virDomainNetDefToNetworkPort(const virDomainDef *dom, virDomainNetDef *iface); =20 int @@ -4539,12 +4539,12 @@ virDomainNetDefActualFromNetworkPort(virDomainNetDe= f *iface, virNetworkPortDef *port); =20 virNetworkPortDef * -virDomainNetDefActualToNetworkPort(virDomainDef *dom, +virDomainNetDefActualToNetworkPort(const virDomainDef *dom, virDomainNetDef *iface); =20 int virDomainNetAllocateActualDevice(virConnectPtr conn, - virDomainDef *dom, + const virDomainDef *dom, virDomainNetDef *iface) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); =20 --=20 2.49.0