From nobody Fri Dec 19 17:52:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1744268361; cv=none; d=zohomail.com; s=zohoarc; b=oJS3d3pbDnasMIKx2vbizndF6vIfubgt6qM68cLoqzwy2tOHpsZv9IAY0DSxQcdJ6du2O6K+yAkDQTDF4aVBBkww1vhvGtc+iolu5Qt4m51mvrxlSOXelA3qzv1ZwIJrkEzufHKQEChjAouyc+Cl46cSlJE6KY6DcPdKopP8VYA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1744268361; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=y0PyJNYnyK92lOlg9b+INNVRddyc3Z8IxyqzVxA/hM0=; b=DblYINsuE7Zel5uaeXNqDStpoh59WFzLyb+aRIXwG+6VrAfTSnoaCm8v8ezk1mh7Z8CtcXXeLv8Bof452KwnjfNiJPNhdr/1FxPHMkD6xhlvtAUmDeB5yfeg809e508UIT9t3QvjqEPWDHf1SvzqLpGIFrYw0qw+BeN9R5pPhFQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1744268361318410.48828174733205; Wed, 9 Apr 2025 23:59:21 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id B28611747; Thu, 10 Apr 2025 02:59:20 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 2EB28173A; Thu, 10 Apr 2025 02:58:40 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id AEF8D1594; Thu, 10 Apr 2025 02:58:35 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3C1341239 for ; Thu, 10 Apr 2025 02:58:35 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-498-eaW6kQJ8MkCbqQb99LPtkQ-1; Thu, 10 Apr 2025 02:58:33 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7DD231954B33 for ; Thu, 10 Apr 2025 06:58:32 +0000 (UTC) Received: from vhost3.router.laine.org (unknown [10.22.64.128]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BA28D18009BC; Thu, 10 Apr 2025 06:58:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744268315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lOiFaNuP73UBvGbqWT8qG79y22E9F4VW6Up3vKhRpVg=; b=Y5nzaWdDqfW0oxn59BLnsuqe8tIPM9SIlZ6EORqECNmTPBrXNTgpQYEIu8m/JCpvoexhTl Oy7x4sWW7U9UBMXY2Or5WCc94a66Ps6qcHrZBKtbpoc/Qbytd1KSFF+WP+iLNEqmSrCX+V JivN+FAou1vDxJMElx5W+rbWlVTyGDo= X-MC-Unique: eaW6kQJ8MkCbqQb99LPtkQ-1 X-Mimecast-MFC-AGG-ID: eaW6kQJ8MkCbqQb99LPtkQ_1744268312 To: devel@lists.libvirt.org Subject: [PATCH 1/5] qemu: remove nonsensical sanity check in processNetdevStreamDisconnectedEvent() Date: Thu, 10 Apr 2025 02:58:26 -0400 Message-ID: <20250410065830.380720-2-laine@redhat.com> In-Reply-To: <20250410065830.380720-1-laine@redhat.com> References: <20250410065830.380720-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jc9-Ln9wRCAYcAKxMumFCQwb1NQwAX-u3B5Go28Mz9M_1744268312 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 3MS7MDKCYM7GTIFKRIGRWJ57PIPEW5ML X-Message-ID-Hash: 3MS7MDKCYM7GTIFKRIGRWJ57PIPEW5ML X-MailFrom: laine@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Laurent Vivier , Stefano Brivio X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Laine Stump via Devel Reply-To: Laine Stump X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1744268361826019000 Content-Type: text/plain; charset="utf-8"; x-default="true" By definition QEMU will never send a NETDEV_STREAM_DISCONNECTED event if it doesn't support the reconnect option for a stream netdev (and even if, by some comedy of errors, it did send NETDEV_STREAM_DISCONNECTED in that case, our response to the event doesn't request anything at all of QEMU (much less something that would fail if QEMU didn't understand NETDEV_STREAM_DISCONNETED) - it just starts a new passt process to replace the one that has just been terminated, so we don't need to check the QEMU capabilities for QEMU_CAPS_NETDEV_STREAM_RECONNECT. Signed-off-by: Laine Stump Reviewed-by: Jiri Denemark --- src/qemu/qemu_driver.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6ce949dd07..411cf79317 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3612,7 +3612,6 @@ processNetdevStreamDisconnectedEvent(virDomainObj *vm, { virDomainDeviceDef dev; virDomainNetDef *def; - virQEMUCaps *qemuCaps =3D QEMU_DOMAIN_PRIVATE(vm)->qemuCaps; const char *devAlias =3D STRSKIP(netdevId, "host"); =20 /* The event sends us the "netdev-id", but we don't store the @@ -3658,12 +3657,6 @@ processNetdevStreamDisconnectedEvent(virDomainObj *v= m, goto endjob; } =20 - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_NETDEV_STREAM_RECONNECT)) { - VIR_WARN("ignore NETDEV_STREAM_DISCONNECTED event for passt networ= k device %s in domain %s - QEMU binary does not support reconnect", - def->info.alias, vm->def->name); - goto endjob; - } - /* handle the event - restart the passt process with its original * parameters */ --=20 2.49.0