From nobody Mon Feb 9 16:38:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1744129970894612.4431833447401; Tue, 8 Apr 2025 09:32:50 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 22197168A; Tue, 8 Apr 2025 12:32:43 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 171EC1523; Tue, 8 Apr 2025 12:31:22 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 98D4B148D; Tue, 8 Apr 2025 12:31:14 -0400 (EDT) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 80B4014AF for ; Tue, 8 Apr 2025 12:31:12 -0400 (EDT) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-aca99fc253bso12755066b.0 for ; Tue, 08 Apr 2025 09:31:12 -0700 (PDT) Received: from tulp.my.domain (80-115-115-199.cable.dynamic.v4.ziggo.nl. [80.115.115.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac7bfe5c5ffsm937295966b.23.2025.04.08.09.31.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 09:31:09 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744129871; x=1744734671; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ItS4OjjGslG2IlZdUzwGIYWRz/yGSvIJYUNM1i/3CpQ=; b=h6wcXgCmmooFOwtDiCponB85zohHucPGnq5DzIzMow/4Z46LKsG2TJR19MUGVovlFA ocZfujAVmBrK0hWkUZ85+++tk5DVLN/1t48Svc+L04KqCJGlmTeL+27VknbRsOzCKalK uFb47WTEcVvXH/l0/+RtJp2GlX5C/OtVWmCuVNinGGNUXhQKFAbZUSHd13EgP9JbTA+O HstQDAHEl8cO81VAT9hVFQ68BAM05TVboEYpRYgTWzHwBeO4P2NX5b8OLEAjSMa5ixD5 D9TF0qevTL8boYm3CfX/XOMZtPu6e5HFnaMw/l2HLdQR/BCRaSbTNZ/SCTdjMuVuwsVc y3Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744129871; x=1744734671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ItS4OjjGslG2IlZdUzwGIYWRz/yGSvIJYUNM1i/3CpQ=; b=qJ/HtiljaAQVe1fnGZMgEVqvMu9zX7k+ebeQozp4ZiX2jZZQjuBQJrEuXWLCcao+7A VuGvk7scby42eQW9QoTd6mnCcCoPHnD5+QbBveERzLnkugJqKfTkQ78x1jiOoyvNP9nI caQidw6ZjCFJblWo4XV+6isapceWGDJl7Mshm03ohGXt5vU0ImALVwdHvuS8KLMbdMmq gM6ezqNZ/nD6/6yiUhug8a0pPh+OJZFOC5Boidq7rFvKlpIX+xlNVKpwzWim5k6DHpuz lDY/Vcy4LrDWbVaxCtmcVcAikByXgVEFKaGu2oqyFrQ3kWatHgp8oQiwlHNYkgsQmXFl XPPg== X-Gm-Message-State: AOJu0YypuQY2ISzJscWvFEWZnm6IbkG2sBTyDF/k0wg9Ej1yohWFdS8j 3NHWc+cEUrnVv049B6YMBkH+ZYba2U6607oWi3rWUoqVryaZp+QHkKDGxm03ZyWfSg== X-Gm-Gg: ASbGncv/hHcwuXljAn1buEE2+HIjfY7NE+8/K2+0LE0VbqzJOrgT4G6YHAppVbxf1a/ GG21BLRtmEk/QyLRACQ3W2whxHEcBMQ8uyptMrR4jWa0gHklZ8hWBTs0TQoeWqqlI3BnbLgxp8b BaRfV2ovY0Un5CiuzXjlnv8Hlc+Pm/pTIGdBkFbDdJhnjoPVhF6B11xHVwJzfuiBbhmAopCcU2K VbdQD99rLmNCwVDzcyt9BgkF7q+5Suv5v2Ct6LVSf0EnWfdGUOZi5C3GaJB4w1Xuj509u7HADUm iee4ICsk9HV10DFYn89KQN0Uh2XUNPsqJCW15EwEyqD/jf7VLOowIeV/BH0W0v7Lguin8BuK5LD kncw1wM/WTSLZfeJKng== X-Google-Smtp-Source: AGHT+IG4Ac5lJ+nvoFHm0OQvdlh5IxPUdYuOjJPI62aDZCRjqvsvjCW5rGJgktXeFfi4j8w4mu+UfQ== X-Received: by 2002:a17:906:797:b0:ac8:1142:a9e5 with SMTP id a640c23a62f3a-ac81142b8c5mr482447666b.47.1744129870511; Tue, 08 Apr 2025 09:31:10 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 2/3] bhyve: argv2xml: support virtio-rnd devices Date: Tue, 8 Apr 2025 18:27:29 +0200 Message-ID: <20250408162730.67891-3-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408162730.67891-1-bogorodskiy@gmail.com> References: <20250408162730.67891-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: W76WC34GG2YWN3B6VU5SDCR6TT2EMCM2 X-Message-ID-Hash: W76WC34GG2YWN3B6VU5SDCR6TT2EMCM2 X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1744129971487019000 Content-Type: text/plain; charset="utf-8" Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_parse_command.c | 29 +++++++++++++++++++ .../bhyveargv2xml-virtio-rnd.args | 8 +++++ .../bhyveargv2xml-virtio-rnd.xml | 20 +++++++++++++ tests/bhyveargv2xmltest.c | 1 + 4 files changed, 58 insertions(+) create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-virtio-rnd.args create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-virtio-rnd.xml diff --git a/src/bhyve/bhyve_parse_command.c b/src/bhyve/bhyve_parse_comman= d.c index 29d3a678bf..7a4e48fbf8 100644 --- a/src/bhyve/bhyve_parse_command.c +++ b/src/bhyve/bhyve_parse_command.c @@ -5,6 +5,7 @@ * Copyright (C) 2006 Daniel P. Berrange * Copyright (c) 2011 NetApp, Inc. * Copyright (C) 2020 Fabian Freyer + * Copyright (C) 2025 The FreeBSD Foundation * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -639,6 +640,32 @@ bhyveParsePCIFbuf(virDomainDef *def, return -1; } =20 +static int +bhyveParsePCIRND(virDomainDef *def, + virDomainXMLOption *xmlopt G_GNUC_UNUSED, + unsigned caps G_GNUC_UNUSED, + unsigned bus, + unsigned slot, + unsigned function, + const char *config G_GNUC_UNUSED) +{ + /* -s slot,virtio-rnd */ + virDomainRNGDef *rng =3D g_new0(virDomainRNGDef, 1); + + rng->model =3D VIR_DOMAIN_RNG_MODEL_VIRTIO; + rng->backend =3D VIR_DOMAIN_RNG_BACKEND_RANDOM; + + rng->info.type =3D VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI; + rng->info.addr.pci.bus =3D bus; + rng->info.addr.pci.slot =3D slot; + rng->info.addr.pci.function =3D function; + rng->source.file =3D g_strdup("/dev/random"); + + VIR_APPEND_ELEMENT(def->rngs, def->nrngs, rng); + + return 0; +} + static int bhyveParseBhyvePCIArg(virDomainDef *def, virDomainXMLOption *xmlopt, @@ -703,6 +730,8 @@ bhyveParseBhyvePCIArg(virDomainDef *def, VIR_DOMAIN_NET_MODEL_E1000, conf); else if (STREQ(emulation, "fbuf")) bhyveParsePCIFbuf(def, xmlopt, caps, bus, slot, function, conf); + else if (STREQ(emulation, "virtio-rnd")) + bhyveParsePCIRND(def, xmlopt, caps, bus, slot, function, conf); =20 VIR_FREE(emulation); VIR_FREE(slotdef); diff --git a/tests/bhyveargv2xmldata/bhyveargv2xml-virtio-rnd.args b/tests/= bhyveargv2xmldata/bhyveargv2xml-virtio-rnd.args new file mode 100644 index 0000000000..7e4b27eb77 --- /dev/null +++ b/tests/bhyveargv2xmldata/bhyveargv2xml-virtio-rnd.args @@ -0,0 +1,8 @@ +/usr/sbin/bhyve \ +-c 1 \ +-m 214 \ +-H \ +-P \ +-s 0:0,hostbridge \ +-s 1:0,virtio-rnd \ +bhyve diff --git a/tests/bhyveargv2xmldata/bhyveargv2xml-virtio-rnd.xml b/tests/b= hyveargv2xmldata/bhyveargv2xml-virtio-rnd.xml new file mode 100644 index 0000000000..c6b2620f9e --- /dev/null +++ b/tests/bhyveargv2xmldata/bhyveargv2xml-virtio-rnd.xml @@ -0,0 +1,20 @@ + + bhyve + c7a5fdbd-edaf-9455-926a-d65c16db1809 + 219136 + 219136 + 1 + + hvm + + + destroy + destroy + destroy + + + /dev/random +
+ + + diff --git a/tests/bhyveargv2xmltest.c b/tests/bhyveargv2xmltest.c index 92189a2e58..82abce5b8f 100644 --- a/tests/bhyveargv2xmltest.c +++ b/tests/bhyveargv2xmltest.c @@ -188,6 +188,7 @@ mymain(void) DO_TEST("vnc-vga-io"); DO_TEST("vnc-resolution"); DO_TEST("vnc-password"); + DO_TEST("virtio-rnd"); =20 virObjectUnref(driver.caps); virObjectUnref(driver.xmlopt); --=20 2.49.0