From nobody Fri Dec 19 20:17:06 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1743071827; cv=none; d=zohomail.com; s=zohoarc; b=Ge+62DwOvWF4qXsqv+x8UTGbXmR3GPpYkNQ65UTD5vpCME2gWQMw+MvY32EeWIhoKXFJW9EA2IZnobE6TBP8zfIH3fJ51dvF+Y7xhSkfwjnUjKrXXlN52NTv+3+G3S4XQmGG7ojHiMzyJJPlJ3UmeFRkI0dfVViIZL5K1Vq00LU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743071827; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=DksX+CXp5Ag2TaAYWDDs7UYrrwEcCcfBd6Yt9f01UHA=; b=EsxG41VRiQ7R25PRj1P9V+ahDS6l7fp0eQWxp1ZMhPR+n1vwFPEvbSebDPZytzg7Z1tvuOWf2e1EdSIRS6gVyvBYytbONhaxUAaLq8nbbaM6YUvRnnUfHq6rNXBG3CQMsdFVxMcfJ7J8xGeoS8s/pOkD45gfav6l79R8Y7tZfDE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1743071827262977.4265367925886; Thu, 27 Mar 2025 03:37:07 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 50E1FD55; Thu, 27 Mar 2025 06:37:06 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id C06D213E4; Thu, 27 Mar 2025 06:35:30 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A425611B4; Thu, 27 Mar 2025 06:35:25 -0400 (EDT) Received: from relay.virtuozzo.com (relay.virtuozzo.com [130.117.225.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9363513D9 for ; Thu, 27 Mar 2025 06:35:19 -0400 (EDT) Received: from [130.117.225.5] (helo=vz9-barybin-2.ch-qa.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1txkHY-007ahx-2f; Thu, 27 Mar 2025 11:19:13 +0100 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=4vmeogWK8plENVuz/Z56gU9U1S7Jhk8mdBDVdA0mN5g=; b=nhrNy2VS+myK KHC2cq6q2xkgImVuEigWyX7l4Od+IKg7llXeqYIUSWrYB9VSnG0s/N2KtR0EgA+JpkLm8BPLM1umq Dq/sMWoJOADI8Hc08ox6mzfWqqPz807/5OENJrV2OGkf0A3TaCf2gv2ead+a6Nex7gJYz0yszfYnp B4Ib7faJogHuB6ZlgPlULDDleg2pF4OabK9ZdJ/IDDScxtlnkY02OVuQlh+NsRiPpGdVwHNmnjv+b MaJjoLh18cgsjUV4NWOjZMG+ywA/GfqqKXzyY1hgkhItgg2KLimKaq5O89DaT6hxtacLG0AkwVpIV khfogtzV4UyAMmmY+aviPg==; To: devel@lists.libvirt.org Subject: [PATCH 3/4] qemu: use configurable dump format in doCoreDumpToAutoDumpPath() Date: Thu, 27 Mar 2025 13:14:39 +0300 Message-ID: <20250327101903.199286-4-nikolai.barybin@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20250327101903.199286-1-nikolai.barybin@virtuozzo.com> References: <20250327101903.199286-1-nikolai.barybin@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: N4YRE3PF7JITU3JREATD2OZKN3A3U57I X-Message-ID-Hash: N4YRE3PF7JITU3JREATD2OZKN3A3U57I X-MailFrom: nikolai.barybin@virtuozzo.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: den@openvz.org, Nikolai Barybin X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Nikolai Barybin via Devel Reply-To: Nikolai Barybin X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1743071829408019100 Content-Type: text/plain; charset="utf-8" Instead of doing dump in raw format, let's use configurable vm->def->coredumpFormat, which is either way will be raw by default. Signed-off-by: Nikolai Barybin --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6ce949dd07..961e1eb2e8 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3470,7 +3470,7 @@ doCoreDumpToAutoDumpPath(virQEMUDriver *driver, =20 flags |=3D cfg->autoDumpBypassCache ? VIR_DUMP_BYPASS_CACHE: 0; if ((ret =3D doCoreDump(driver, vm, dumpfile, flags, - VIR_DOMAIN_CORE_DUMP_FORMAT_RAW)) < 0) + vm->def->coredumpFormat)) < 0) virReportError(VIR_ERR_OPERATION_FAILED, "%s", _("Dump failed")); return ret; --=20 2.43.5