[PATCH v2] qemu_domain_address: fix CCW virtio-mem hotplug

Boris Fiuczynski posted 1 patch 1 month, 1 week ago
src/qemu/qemu_domain_address.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH v2] qemu_domain_address: fix CCW virtio-mem hotplug
Posted by Boris Fiuczynski 1 month, 1 week ago
Since commit f23f8ff91a virtio-mem supports also CCW. When hotplugging a
virtio-mem device with a CCW address results in a PCI device getting
attached. The method qemuDomainAssignMemoryDeviceSlot is only
considering PCI as address type and overwriting the CCW address. Adding
support for address type CCW.

Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
---
 src/qemu/qemu_domain_address.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
index d38983bf63..5b94c27679 100644
--- a/src/qemu/qemu_domain_address.c
+++ b/src/qemu/qemu_domain_address.c
@@ -3067,6 +3067,7 @@ qemuDomainAssignMemoryDeviceSlot(virDomainObj *vm,
                                  virDomainMemoryDef *mem)
 {
     g_autoptr(virBitmap) slotmap = NULL;
+    bool releaseaddr = false;
     virDomainDeviceDef dev = {.type = VIR_DOMAIN_DEVICE_MEMORY, .data.memory = mem};
 
     switch (mem->model) {
@@ -3080,7 +3081,7 @@ qemuDomainAssignMemoryDeviceSlot(virDomainObj *vm,
 
     case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_PMEM:
     case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_MEM:
-        return qemuDomainEnsurePCIAddress(vm, &dev);
+        return qemuDomainEnsureVirtioAddress(&releaseaddr, vm, &dev);
         break;
 
     case VIR_DOMAIN_MEMORY_MODEL_SGX_EPC:
-- 
2.47.0
Re: [PATCH v2] qemu_domain_address: fix CCW virtio-mem hotplug
Posted by Ján Tomko via Devel 1 month, 1 week ago
On a Tuesday in 2025, Boris Fiuczynski wrote:
>Since commit f23f8ff91a virtio-mem supports also CCW. When hotplugging a
>virtio-mem device with a CCW address results in a PCI device getting
>attached. The method qemuDomainAssignMemoryDeviceSlot is only
>considering PCI as address type and overwriting the CCW address. Adding
>support for address type CCW.
>
>Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
>---
> src/qemu/qemu_domain_address.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano