rpm: Enable KVM for riscv64 on RHEL 10+

[PATCH] rpm: Enable KVM for riscv64 on RHEL 10+

Posted by Andrea Bolognani 1 month, 2 weeks ago

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 libvirt.spec.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index cb41ea1de1..9217820137 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -8,7 +8,9 @@
 
 %define arches_qemu_kvm         %{ix86} x86_64 %{power64} %{arm} aarch64 s390x riscv64
 %if 0%{?rhel}
-    %if 0%{?rhel} > 8
+    %if 0%{?rhel} >= 10
+        %define arches_qemu_kvm     x86_64 aarch64 s390x riscv64
+    %elif 0%{?rhel} >= 9
         %define arches_qemu_kvm     x86_64 aarch64 s390x
     %else
         %define arches_qemu_kvm     x86_64 %{power64} aarch64 s390x
-- 
2.48.1

Re: [PATCH] rpm: Enable KVM for riscv64 on RHEL 10+

Posted by Daniel P. Berrangé 1 month, 2 weeks ago

On Fri, Mar 14, 2025 at 11:01:21AM +0100, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  libvirt.spec.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index cb41ea1de1..9217820137 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -8,7 +8,9 @@
>  
>  %define arches_qemu_kvm         %{ix86} x86_64 %{power64} %{arm} aarch64 s390x riscv64
>  %if 0%{?rhel}
> -    %if 0%{?rhel} > 8
> +    %if 0%{?rhel} >= 10
> +        %define arches_qemu_kvm     x86_64 aarch64 s390x riscv64

AFAICT the qemu-kvm.spec in centos-stream still only has

  ExclusiveArch: x86_64 %{power64} aarch64 s390x

so adding this in libvirt is premature and would lead to unresolvable
dependencies until QEMU is built on riscv64.

> +    %elif 0%{?rhel} >= 9
>          %define arches_qemu_kvm     x86_64 aarch64 s390x
>      %else
>          %define arches_qemu_kvm     x86_64 %{power64} aarch64 s390x
> -- 
> 2.48.1
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH] rpm: Enable KVM for riscv64 on RHEL 10+

Posted by Andrea Bolognani via Devel 5 days, 1 hour ago

On Fri, Mar 14, 2025 at 10:13:49AM +0000, Daniel P. Berrangé wrote:
> On Fri, Mar 14, 2025 at 11:01:21AM +0100, Andrea Bolognani wrote:
> >  %define arches_qemu_kvm         %{ix86} x86_64 %{power64} %{arm} aarch64 s390x riscv64
> >  %if 0%{?rhel}
> > -    %if 0%{?rhel} > 8
> > +    %if 0%{?rhel} >= 10
> > +        %define arches_qemu_kvm     x86_64 aarch64 s390x riscv64
>
> AFAICT the qemu-kvm.spec in centos-stream still only has
>
>   ExclusiveArch: x86_64 %{power64} aarch64 s390x
>
> so adding this in libvirt is premature and would lead to unresolvable
> dependencies until QEMU is built on riscv64.

The CentOS Stream 10 package for qemu-kvm has been made buildable on
riscv64 as part of:

  https://gitlab.com/redhat/centos-stream/rpms/qemu-kvm/-/merge_requests/220

Earlier, the edk2 package had been handled with:

  https://gitlab.com/redhat/centos-stream/rpms/edk2/-/merge_requests/102

Can I go ahead with this change now?

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH] rpm: Enable KVM for riscv64 on RHEL 10+

Posted by Daniel P. Berrangé via Devel 4 days, 11 hours ago

On Wed, Apr 23, 2025 at 11:39:34AM -0700, Andrea Bolognani wrote:
> On Fri, Mar 14, 2025 at 10:13:49AM +0000, Daniel P. Berrangé wrote:
> > On Fri, Mar 14, 2025 at 11:01:21AM +0100, Andrea Bolognani wrote:
> > >  %define arches_qemu_kvm         %{ix86} x86_64 %{power64} %{arm} aarch64 s390x riscv64
> > >  %if 0%{?rhel}
> > > -    %if 0%{?rhel} > 8
> > > +    %if 0%{?rhel} >= 10
> > > +        %define arches_qemu_kvm     x86_64 aarch64 s390x riscv64
> >
> > AFAICT the qemu-kvm.spec in centos-stream still only has
> >
> >   ExclusiveArch: x86_64 %{power64} aarch64 s390x
> >
> > so adding this in libvirt is premature and would lead to unresolvable
> > dependencies until QEMU is built on riscv64.
> 
> The CentOS Stream 10 package for qemu-kvm has been made buildable on
> riscv64 as part of:
> 
>   https://gitlab.com/redhat/centos-stream/rpms/qemu-kvm/-/merge_requests/220
> 
> Earlier, the edk2 package had been handled with:
> 
>   https://gitlab.com/redhat/centos-stream/rpms/edk2/-/merge_requests/102
> 
> Can I go ahead with this change now?

Yep

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH] rpm: Enable KVM for riscv64 on RHEL 10+

Posted by Andrea Bolognani 1 month, 2 weeks ago

On Fri, Mar 14, 2025 at 10:13:49AM +0000, Daniel P. Berrangé wrote:
> On Fri, Mar 14, 2025 at 11:01:21AM +0100, Andrea Bolognani wrote:
> > Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> > ---
> >  libvirt.spec.in | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/libvirt.spec.in b/libvirt.spec.in
> > index cb41ea1de1..9217820137 100644
> > --- a/libvirt.spec.in
> > +++ b/libvirt.spec.in
> > @@ -8,7 +8,9 @@
> >
> >  %define arches_qemu_kvm         %{ix86} x86_64 %{power64} %{arm} aarch64 s390x riscv64
> >  %if 0%{?rhel}
> > -    %if 0%{?rhel} > 8
> > +    %if 0%{?rhel} >= 10
> > +        %define arches_qemu_kvm     x86_64 aarch64 s390x riscv64
>
> AFAICT the qemu-kvm.spec in centos-stream still only has
>
>   ExclusiveArch: x86_64 %{power64} aarch64 s390x
>
> so adding this in libvirt is premature and would lead to unresolvable
> dependencies until QEMU is built on riscv64.

We're working on several packages at once, so you can assume that
QEMU will have been handled by the time we get to boostrapping CentOS
Stream 10. Doing things in strict dependency order would only
introduce unnecessary complications and delays.

-- 
Andrea Bolognani / Red Hat / Virtualization