From nobody Wed Mar 12 17:38:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1741703919017251.6825331552684; Tue, 11 Mar 2025 07:38:39 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 0AE231EC6; Tue, 11 Mar 2025 10:38:38 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id ABF541E27; Tue, 11 Mar 2025 10:25:57 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id D63471D6B; Tue, 11 Mar 2025 10:25:49 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 692FA1DBC for ; Tue, 11 Mar 2025 10:25:13 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-175--Vs2M3jFMgqj-z-TF71bKQ-1; Tue, 11 Mar 2025 10:25:11 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 451AA180AF74 for ; Tue, 11 Mar 2025 14:25:10 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.44]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 214341955BCB; Tue, 11 Mar 2025 14:25:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741703112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C3hWad/8XIoujNF2SZkupl1HbxjQncaP1M2i5PdwlTw=; b=W5PYyfwsFs8QELunEUBVpAohQUOT1fK6dxwewESLiod+WEzznm+O2x5eNmaPYcSmIReA5t Vp1wIeBwY2bcOsKlMzE59NSfUiuEFxm4yvBOGtlZIL9W1XZcACstxbz0zVmo7vVohnzERd VH6qGGOQy+47bZXMJzHFHbcEj9SDLP0= X-MC-Unique: -Vs2M3jFMgqj-z-TF71bKQ-1 X-Mimecast-MFC-AGG-ID: -Vs2M3jFMgqj-z-TF71bKQ_1741703110 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH v2 23/23] src: expand docs for guest stats constant version handling Date: Tue, 11 Mar 2025 14:24:29 +0000 Message-ID: <20250311142429.1326816-24-berrange@redhat.com> In-Reply-To: <20250311142429.1326816-1-berrange@redhat.com> References: <20250311142429.1326816-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jMNZDxSJ82OXgx6fx02_oHbhiyitThFQ---oVMKbzZk_1741703110 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7GQUC5WEHPNFO7TJICGJAWO2RXQAYL2W X-Message-ID-Hash: 7GQUC5WEHPNFO7TJICGJAWO2RXQAYL2W X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1741703920165019100 Content-Type: text/plain; charset="utf-8" Explain that the 11.2.0 release dates are mostly reflecting when the constant was first added, not when the key was introduced. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- src/libvirt-domain.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 59fb923d10..a7a1c5ebd3 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -12440,6 +12440,13 @@ virConnectGetDomainCapabilities(virConnectPtr conn, * Which, when monindex=3D=3D3 and bankindex=3D=3D7, would result in the * key "cpu.cache.monitor.3.bank.7.bytes". * + * NB, for the VIR_DOMAIN_STATS_* constants, if the `Since` + * tag is set to `11.2.0` this is usually representing the + * release when the constant was first introduced to the public + * API. Most of these typed parameter keys will have been + * introduced in earlier libvirt releases, prior to the definition + * of the constants. + * * Returns the count of returned statistics structures on success, -1 on e= rror. * The requested data are returned in the @retStats parameter. The returned * array should be freed by the caller. See virDomainStatsRecordListFree. --=20 2.48.1