From nobody Wed Mar 12 17:57:48 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=fail (BodyHash is different from the expected one); dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1741393026937572.154509001063; Fri, 7 Mar 2025 16:17:06 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 51CFF18D6; Fri, 7 Mar 2025 19:17:06 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 7DFCD1882; Fri, 7 Mar 2025 19:15:30 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 14D5A1A5C; Fri, 7 Mar 2025 19:15:26 -0500 (EST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2083.outbound.protection.outlook.com [40.107.93.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8FD491962 for ; Fri, 7 Mar 2025 19:15:12 -0500 (EST) Received: from MW6PR12MB8897.namprd12.prod.outlook.com (2603:10b6:303:24a::19) by SJ0PR12MB5610.namprd12.prod.outlook.com (2603:10b6:a03:423::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.17; Sat, 8 Mar 2025 00:15:09 +0000 Received: from MW6PR12MB8897.namprd12.prod.outlook.com ([fe80::7c55:5a45:be80:e971]) by MW6PR12MB8897.namprd12.prod.outlook.com ([fe80::7c55:5a45:be80:e971%4]) with mapi id 15.20.8511.017; Sat, 8 Mar 2025 00:15:09 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, FORGED_SPF_HELO,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.4 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oRx8AMleemMnL7s6fDxY3tVVTfnwfjo2Uocf+MKUU9AuBf6DrrZoHMutaDM4bIQ7lXSah8uFq+/CzvAhzANlesnFWKdlCBLWtRWuDacAatsEryeCoRMBBpymzBjTT2A9zF+dtWQ13C1TpeyxgJ+7urCco8zdrOIthVflvjeoRrdDfqUmmpKH91Ta8M1NJZ6R1MXO6kC7btV/eA3kcGEMG2HMNlhnYHRl41+SIo6kdeII/eQanQ0xvA33RqKVPJoMXy5XTE0rc1kfKE1LCNIhQ0WMXB0/okSzVyYKhMv7C03wezqsTb5gSYkcIDlhALk8HoA1WXGjD/K9Iz0K1Gwa3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6+Ym5nsTotviv/YIBhJ/RzuRJ7rP+Gq6G3w7r6Apf80=; b=KdzLD3UEn4kLarQA2eL3fXxkZfoy96rS5BhbJPJ7eBsVIMS4nJLQ2KDARBaMMxbnRiOrij13jU7u5K0iHCfq7opuNFLhf+4WmkC9TIi1pwHyx6V53Uv/dDPlbHTvcWdylYyutjqRpy50s4wfMBcALVIuZgOykJElgM/hWnwkLtsa1XWTffHtXXbyUCcIdXdJb71ig6qFBbiEpg3OkDzd2ZxwODpzOFHpanGR+iOvAv9vRLY609lPpq0YJPaJV55mQ9w1UfgjOOr80/+R5GslFmHbEb8c5yq/XJuPIsnnBZhNJlwvbj7ID9eAxBRarYlpR69LEYpeWW+pIJ7QgDzW3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6+Ym5nsTotviv/YIBhJ/RzuRJ7rP+Gq6G3w7r6Apf80=; b=Ywr+BNGvKEOCDzTTvbpns2uZ1Aip2z/x2AbXySXZZvpQlAmKUVueUUQlmiv0vl5xBg8dreVKCd4rRdxyLFGtFOcX6SShS65zwVusXOA0QRl8Ud2erIxgs7UeHRN9YdMtQxU0CTKvIGfBxKGR6lpQeqddl6bndgdE9KFB6Z1yZqbcU2HJpOU6uqGylhmlW31FTALr1kqjGJVeLdIQn3lhFNv93Vl6cF5ZXlXWHTvll9pDnYzwUFomV5oh/3rJuysPo90n9pERIcozRzP+kgoDXrRpa2dXzq+/IJ2Td4KSJZ4rgpmVmm/yatbZLtpD84AYZD6rY+/4Db7odww3KVciTw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; To: devel@lists.libvirt.org Subject: [PATCH RESEND 6/6] tests: Add tests for machine PCI features Date: Fri, 7 Mar 2025 16:15:08 -0800 Message-ID: <20250308001508.1312871-1-mochs@nvidia.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20250308001331.1311347-1-mochs@nvidia.com> References: <20250308001331.1311347-1-mochs@nvidia.com> X-NVConfidentiality: public X-ClientProxiedBy: SJ0PR13CA0160.namprd13.prod.outlook.com (2603:10b6:a03:2c7::15) To MW6PR12MB8897.namprd12.prod.outlook.com (2603:10b6:303:24a::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW6PR12MB8897:EE_|SJ0PR12MB5610:EE_ X-MS-Office365-Filtering-Correlation-Id: f0f4dd07-838d-4b40-c8ce-08dd5dd6499c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Yu08KLNNwCcMRFSV6rFqYn5kIqIxearUXO7wQ7FQpKgVOHKNcPKYWcWmiR/X?= =?us-ascii?Q?FWtfRdRkg8qN/Cf7Jm8hTmkJT2pnaRbn/eeH+lp2DDdFNC2w9eZLrDpv+K3Z?= =?us-ascii?Q?KGF5xxFegyJoTEOLtBeAYL2W6Q4tXuGyNPOOqai7DIfWYNmKIHDxGoHkFsLY?= =?us-ascii?Q?BiVLi3xmjLjn2G9j32R3HFvZ4nhYhYLMbriIuImomvcQeETfTSa6GVrv9yrW?= =?us-ascii?Q?owymPPhokMGRumUbC3lbzBXYDXBlTbr+JU8646YY+gJJco6Cu8FyUMw44c0s?= =?us-ascii?Q?TEvEB1hfuUJK4RKPq629ZKfQkCa9QOZk8CL8xNZtrI2bhQ+A4voVDjzNIi6y?= =?us-ascii?Q?dT5NjGRbyWPlTedc+KXhAG1AybBzlgIMrAv8383/SbGFzvrY9/Oq5ucgxN3w?= =?us-ascii?Q?s4NNeKzp3uCf1ID90gFFoj0diWIAYDgpeqomcrg9nqvFhr0Fi9uQ5O3OALTl?= =?us-ascii?Q?oiGlQMc2bVBdZUb7ewjVVOMCtk/MFRyxlfobYZFbvTeXhzi4p2Af1LMGCGY9?= =?us-ascii?Q?SpzZCN83ArJFCAY2CbqLrjPFC2yYWdliJxs/Vd6Q1LMOC61WRaxZcMtDvPCz?= =?us-ascii?Q?ADT9Ef9vW+sZMqJgmR4UrQEwqnhoqk18Nkd43QMHdzhvOJvLHNw869b8kNKs?= =?us-ascii?Q?976Q0AEPUThGWMDl2I8nKMU/LORjHMKC8SQhkrvzQ3knWGh0f9MmvTAnHZJc?= =?us-ascii?Q?QYJZ5VQW10k16Yil9KuCfDXtD6onFVZDoYpFLyjQn+Mciz+InxJ4IgvqapxS?= =?us-ascii?Q?EGss8qh3+oYdaf0zi//OACgbyHFAUR1r3HWkQ1cdlLe5KLJAxdkiCCJFv/hs?= =?us-ascii?Q?SDPoqHfjPwLh3LyVy/MvQ3VSs5FCve9/weG7NS/lX9VhrS3X8zy7QEHUZCBA?= =?us-ascii?Q?yDBKYvrBA7Xle7SHF2bIrel4tBFNd8kjiKx7Yt9+Z3qQJjMYSdawAvLWOJxf?= =?us-ascii?Q?roZKtVM/Eq00OfsAAgp+TSCza1QDyHhU3Zj00lnoV4y1h51v62o6YupE5Aru?= =?us-ascii?Q?0PT6jOypssQS61lEFny1XkN4AzNtUKthft0qKjvVOl+XZuXTNzEPnNp1QKGs?= =?us-ascii?Q?Almaqjpwtybp2zmBpA4eqFiODq5gwjC7icekKSN7IWVaiPK5wvCGYk2jQDLK?= =?us-ascii?Q?TaNBJ66EOnEcxYTlU5dVozJ72nzU94m7pH71t29BZyJK/WePDH3sAdYX+w38?= =?us-ascii?Q?VQet+zhEEKl0egT41WmBDUjY4qQ0KmUlIL/Ye10hb0k/MsjQ9Amlq1nf9ym8?= =?us-ascii?Q?YLrZjPrhukbkRrpYlc7uAc2aV6Rbt2s5vULrMcJYUj8sBlpYokcX5kSAhiDC?= =?us-ascii?Q?HKteznQRWImhPO9x+XlZ33UejodiT4nWUl/X/G2fzTFbkRkzeLYU7MZ4q4ci?= =?us-ascii?Q?CqahFWpRrfVtgGOfQsj+/BxHuv67?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW6PR12MB8897.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y38VpdxyXepHDkzP3me5IYMO1PC5sTrD/PYGBLfmQ5u3EedE4u1hu7avIaMJ?= =?us-ascii?Q?Ak4GwaFVD6knhC6+nJLveguFtdmoXl7bXr9PmFOGVy7xn5qYC6aOWbBgLzGT?= =?us-ascii?Q?ETsOSImdWlVWZIVn8F55ul6OhA6vf1yACNev9e/gVrfH0sdqA0PDgHcRX7nS?= =?us-ascii?Q?PM5jcmO3ledEt+0OqHps/ftsQl2t0T+/d0WqdD2meXQ+AC6AvkVz9I5JqBOO?= =?us-ascii?Q?CCLeMcC4AcpUsEhBf5/xE3fbB+zfQYIfEPH9ICouDT7zRqZXd/MhXiVTBV5c?= =?us-ascii?Q?G5NEjPsU1vGsSqwZ5u+bOkDUxqIDtZ6EO5/rbj+AJTMiLy1CGIenfur2DUfT?= =?us-ascii?Q?ZOAcJx0nSzIQbsIL3Ok03FidkaOrTGfShZZKpXzqW8Dd+68pArJTT8EC0D4x?= =?us-ascii?Q?fzUy3aoRwlAorJCb9JsNC2tEFbLjq6TLBl5dxoh8gfuKb/UAVMOIYQ64tyqg?= =?us-ascii?Q?Y71zJLRvriXlOGOjHDEmKHoQmsslfpkSHiRox4yTovVigdqTbGEhrLyF+Vto?= =?us-ascii?Q?Kmnmruo6onseE9JmusWiQRgG6V2aKIih7jnsLxIKNK9rJROVSDRR0Gcfp7Xz?= =?us-ascii?Q?8/0FfDkj8/t/GwqCr2zO4vIfDLU9pZs6uxwdXtPu/RyPENgLj5fqFTmUScnb?= =?us-ascii?Q?1hYEMTFEj2A6Pz12vmBUeYkGQMb417rHjyQS/v8ZphM1JDk+TlXO7rK/Xvjv?= =?us-ascii?Q?vSCfy99U5jfvX/RLqIPYhucK0lfBVz84rn8dZR9gl+D/6nxRMzeCaCKoeu+f?= =?us-ascii?Q?FGhfU7paA+y85oeedD+zGrKnWVm1+LGx4rtsh9noX12LZVtAzB6IzRTEoB7H?= =?us-ascii?Q?xAvMDLkR6cHVfWU8uNejGhyDXsQx9qfwHVj4mw/3h0tQsMRCtgCWkU27YsbC?= =?us-ascii?Q?j6GtviJZ66jC3nYBLAxSHaTL8wAe5/91yDJ3w85+HNQCQU7wlygp/7s3oRDU?= =?us-ascii?Q?xDLAwoqJ4MtXLS/alRfRwvLHBlVazNePwJg4KrHozzBd8eqArfYE/85WRx8i?= =?us-ascii?Q?uT7wKAbkEcZjUTc4xQT8mPprDxvxvfEWqzaNwWB6Kab2XFMZDtWOUd2224uh?= =?us-ascii?Q?aUJYbCQYRgeTny4Lyf6fZyz/3AUWPdJda7yhwDda4CYqw6F/r+GtZZrX32Iu?= =?us-ascii?Q?Gsf2gh7CNIu7gw+wJsHFOwv1QTZ30vuQAmFMrI/iFXUZ0CG3XU2KVdCofJnW?= =?us-ascii?Q?OuHdDlu4W9Drmy2/XCnHje5rmiwjb2sLcr+aI01eqECQ68pV3yMkRBRBhTrQ?= =?us-ascii?Q?Vozdf0JJ7BI/2Si+4B7tpS6ByBfDHj9S3dH0DRTkVuTUJcidItxsYubZIioU?= =?us-ascii?Q?JmGZYKcfrGls1dLv59XInLLAruwk+KNeNbvfG4nPrrwzlgdgzFQLS72jBpLX?= =?us-ascii?Q?AaX3B+DO917Lj4QWqFrpluFjP4P7neLZ/4FPEtljA+CSPrxq1PGhxCV3lDM+?= =?us-ascii?Q?9LF6zAJPI74Vxj2kI+v80GR31BuprV4FGr+wNn4G6wFo019pj91BAPPysqAv?= =?us-ascii?Q?ARlCpVo23TZUdVwFJm1XUDesA9Ch905v+BfUlydRuxzWt6XU8J0uU9bSDYGe?= =?us-ascii?Q?U8OiwDRop0ICaFuFWH34ZPectn4/8PjblUpEoMzo?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0f4dd07-838d-4b40-c8ce-08dd5dd6499c X-MS-Exchange-CrossTenant-AuthSource: MW6PR12MB8897.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2025 00:15:09.6681 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 08YhUQoGG0n1haubVdPQP9Ez5zR2C38pDjBKyae2mKVNsUimf/H5o3U7fbsca9aM+e4ApmEvrmrSS3+kz+mouw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5610 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: WGFO6L7BY3ISUREYZMMSSLCFLU6E2KDQ X-Message-ID-Hash: WGFO6L7BY3ISUREYZMMSSLCFLU6E2KDQ X-MailFrom: mochs@nvidia.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: "Matthew R. Ochs via Devel" Reply-To: "Matthew R. Ochs" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1741393027713019000 Content-Type: text/plain; charset="utf-8" Add test coverage for machine-specific PCI features: - Add XML tests for aarch64 virt highmem-mmio-size - Add command line generation tests This ensures proper handling of machine-specific PCI features like the high memory MMIO window size configuration. Signed-off-by: Matthew R. Ochs --- ...rch64-virt-machine-pci.aarch64-latest.args | 31 +++++++++++++++++++ ...arch64-virt-machine-pci.aarch64-latest.xml | 30 ++++++++++++++++++ .../aarch64-virt-machine-pci.xml | 20 ++++++++++++ tests/qemuxmlconftest.c | 2 ++ 4 files changed, 83 insertions(+) create mode 100644 tests/qemuxmlconfdata/aarch64-virt-machine-pci.aarch64-= latest.args create mode 100644 tests/qemuxmlconfdata/aarch64-virt-machine-pci.aarch64-= latest.xml create mode 100644 tests/qemuxmlconfdata/aarch64-virt-machine-pci.xml diff --git a/tests/qemuxmlconfdata/aarch64-virt-machine-pci.aarch64-latest.= args b/tests/qemuxmlconfdata/aarch64-virt-machine-pci.aarch64-latest.args new file mode 100644 index 000000000000..7ab4e8bd624f --- /dev/null +++ b/tests/qemuxmlconfdata/aarch64-virt-machine-pci.aarch64-latest.args @@ -0,0 +1,31 @@ +LC_ALL=3DC \ +PATH=3D/bin \ +HOME=3D/var/lib/libvirt/qemu/domain--1-aarch64-virt-machine \ +USER=3Dtest \ +LOGNAME=3Dtest \ +XDG_DATA_HOME=3D/var/lib/libvirt/qemu/domain--1-aarch64-virt-machine/.loca= l/share \ +XDG_CACHE_HOME=3D/var/lib/libvirt/qemu/domain--1-aarch64-virt-machine/.cac= he \ +XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-aarch64-virt-machine/.co= nfig \ +/usr/bin/qemu-system-aarch64 \ +-name guest=3Daarch64-virt-machine-pci,debug-threads=3Don \ +-S \ +-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-aarch64-virt-machine/master-key.aes"}' \ +-machine virt,usb=3Doff,gic-version=3D2,highmem-mmio-size=3D512G,dump-gues= t-core=3Doff,memory-backend=3Dmach-virt.ram,acpi=3Doff \ +-accel tcg \ +-cpu cortex-a15 \ +-m size=3D1048576k \ +-object '{"qom-type":"memory-backend-ram","id":"mach-virt.ram","size":1073= 741824}' \ +-overcommit mem-lock=3Doff \ +-smp 1,sockets=3D1,cores=3D1,threads=3D1 \ +-uuid 6ba7b810-9dad-11d1-80b4-00c04fd430c8 \ +-display none \ +-no-user-config \ +-nodefaults \ +-chardev socket,id=3Dcharmonitor,fd=3D1729,server=3Don,wait=3Doff \ +-mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ +-rtc base=3Dutc \ +-no-shutdown \ +-boot strict=3Don \ +-audiodev '{"id":"audio1","driver":"none"}' \ +-sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ +-msg timestamp=3Don diff --git a/tests/qemuxmlconfdata/aarch64-virt-machine-pci.aarch64-latest.= xml b/tests/qemuxmlconfdata/aarch64-virt-machine-pci.aarch64-latest.xml new file mode 100644 index 000000000000..d19a23b17b70 --- /dev/null +++ b/tests/qemuxmlconfdata/aarch64-virt-machine-pci.aarch64-latest.xml @@ -0,0 +1,30 @@ + + aarch64-virt-machine-pci + 6ba7b810-9dad-11d1-80b4-00c04fd430c8 + 1048576 + 1048576 + 1 + + hvm + + + + + + 512 + + + + cortex-a15 + + + destroy + restart + destroy + + /usr/bin/qemu-system-aarch64 + + + diff --git a/tests/qemuxmlconfdata/aarch64-virt-machine-pci.xml b/tests/qem= uxmlconfdata/aarch64-virt-machine-pci.xml new file mode 100644 index 000000000000..42ebb4b304b5 --- /dev/null +++ b/tests/qemuxmlconfdata/aarch64-virt-machine-pci.xml @@ -0,0 +1,20 @@ + + aarch64-virt-machine-pci + 6ba7b810-9dad-11d1-80b4-00c04fd430c8 + 1048576 + 1048576 + 1 + + hvm + + + + 512 + + + + /usr/bin/qemu-system-aarch64 + + + + diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c index 1279b08c9627..5f1f6a7bb3c5 100644 --- a/tests/qemuxmlconftest.c +++ b/tests/qemuxmlconftest.c @@ -2665,6 +2665,8 @@ mymain(void) =20 DO_TEST_CAPS_ARCH_LATEST("clock-timer-armvtimer", "aarch64"); =20 + DO_TEST_CAPS_ARCH_LATEST("aarch64-virt-machine-pci", "aarch64"); + qemuTestSetHostArch(&driver, VIR_ARCH_NONE); =20 DO_TEST_CAPS_LATEST("kvm-pit-delay"); --=20 2.46.0