From nobody Wed Mar 12 16:21:31 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1741215211; cv=none; d=zohomail.com; s=zohoarc; b=BUQk9c69wfg6UyPxZSyKGz+pu0TfgHlwV4wZ1R/kBPzz+lvvZkAkkZw3gPOuD1B7hCYjzF6FPj8IwZnU+UKNSXG9UE9hVDj0Kg3r7RROYmKHD0FS/7o82lrqHBljBWgExaVN7VjMpxuau1FPcntGY27HQ0FJFranWcgIFukAP2Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1741215211; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=OEZbExuhgQbhPlw0q0CSJp75B1D1X2A6OD3LEoZ6vzo=; b=IkcNbbfZYJ/ztnp3Ys6VSKfTjfKN9oYF3XQxxgCQOeapzVHRZjzLDqbn/V0FUNZg3YoEak+MwMJ1eMQDN15eBNAYwEawYDpUtWZx4FMP8eJynHnuXTkfJ42kh6pToo5i7ZjaZs1gqBWA4URjS0qC6Acv3PpRyzNXW1BIVwMVxm8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1741215211075997.439918771549; Wed, 5 Mar 2025 14:53:31 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 6D7D61569; Wed, 5 Mar 2025 17:53:30 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id D5A37170D; Wed, 5 Mar 2025 17:50:34 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 4B7D115C9; Wed, 5 Mar 2025 17:50:29 -0500 (EST) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AE8A11537 for ; Wed, 5 Mar 2025 17:50:13 -0500 (EST) Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-abf48293ad0so8269466b.0 for ; Wed, 05 Mar 2025 14:50:13 -0800 (PST) Received: from localhost (205-201-32-8.scinternet.net. [205.201.32.8]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-2ff4e75ed7csm1861891a91.3.2025.03.05.14.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 14:50:11 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741215012; x=1741819812; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lkqbBuVhPkplvxwkBbESCJvcvuTpUMT2fWq79X15JGA=; b=MLm6Apb/iLEgG49WthmTxEMLzR0C84G2zqkk2e+c9s7as1eRd+/2RuMxEYpKWKDRtg BJqwrHA6SVjMOgXHEqWvbRwPUMxM2JkTen+6l4jqPHwc0hLI5Q51NPnLCPRdr+QKjh1K 9Pj5LlvAu9LCn4MA4P7vsoDizCoTGZoVvh5elMadQ6I4vMe3rl+MIN7Kt4w0GOxIzJTZ vmr0Ag6NiXj5vtYgTCaJivDxpLIPZ8OsWR+fSC/6Po73xsbhIdmY95MuTkmW9cWPVq6V z/xv19wd+t57BxZLvxMydO6NHsXZ4dYBAWGuFRplyFZVOw+Y/GGIQwGo4nVIhQ/7QQe3 9spQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741215012; x=1741819812; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lkqbBuVhPkplvxwkBbESCJvcvuTpUMT2fWq79X15JGA=; b=E9RuOks7GbENgcfgcmkhjZ825tnzeQM6CUa2eIzLceMJt904SR+dc6r3fcdBXHgOY6 O3GyQc1tYxmgk0Dk8qUMzjMD7idmm+oemo1h5ZDbwJEX2+TgQkKVJ4eFP9p97Jtb59Tu LBpYyR3rRnqG85Lg5Pv/Avp9npdhyWbPnQOPyTmPuzZqyDeL29H5+E739rYG8XLIxw92 spVv09PhzElmTiZLaEV+QdESTcWdczrKAzGEA4POjWxd50sjELZ1ICn8wsUfJzRxg0ZO z4Dm0U1ZzMeyZogpamjoJiZ7H3bEBZv3ASS50oBMHJRxGgcgELxcBqn7LL9rtss8oUub 78Vg== X-Gm-Message-State: AOJu0YzgIvjz6y2fsWHQmm0bS7fjQ/9K7t2WXLom7zayFr5cYoZW+cob 3QsiytdI3I83JU4QIos83BGplU8bwc0JVoFQy2XN/dLUD5qXDxNCpVxFQV0A9belZQnoTZRLu42 j X-Gm-Gg: ASbGncuChjQiEpVs9zo64CdW5l6CpxzQ0hG7Af4wCkb1j1BN7TWxPOmBVn3eNLnrQNy hQkBGFAyxA9uqzMnh4v/4rzvwTnqPPawL4XOZuSMr+QMhVEk/6DK22wxChQE2UWjXyedefJtURF pALMdcFmGqsZ11z1njHDH7xgknC07Qs19VslTv0RrZ6OOY7VetdmwU4S4fsxfM6Kgb0kLHk9dgs z6C0e0ZGC32ygNFBlXtXlBIvV9o0t91z8h4gJPDkKDkT8r+WJC/bnOk0pHAZWbobmx4G87hAciF AGbgOf/7v4zQjVRIDruapaTALUfK9n81qU79IA3xBYIRRxl6BnZJ0nh8/qlhEp8= X-Google-Smtp-Source: AGHT+IHPSIpQ2uIwkc59VXC0AXEmM5KoGxBZBMzpQgmKiFjbDetjSS//7FKKNpXMdIErcI20t1bGyg== X-Received: by 2002:a17:906:3896:b0:ac2:1c64:b26 with SMTP id a640c23a62f3a-ac21c641538mr261253866b.32.1741215012409; Wed, 05 Mar 2025 14:50:12 -0800 (PST) To: devel@lists.libvirt.org Subject: [PATCH V4 07/18] qemu_saveimage: add "sparse" to supported save image formats Date: Wed, 5 Mar 2025 15:48:16 -0700 Message-ID: <20250305224957.5369-8-jfehlig@suse.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250305224957.5369-1-jfehlig@suse.com> References: <20250305224957.5369-1-jfehlig@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: RIDN46UXQDD6X7BYSLB4GTT73FVRMEUQ X-Message-ID-Hash: RIDN46UXQDD6X7BYSLB4GTT73FVRMEUQ X-MailFrom: jfehlig@suse.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: farosas@suse.de X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Jim Fehlig via Devel Reply-To: Jim Fehlig X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1741215213061019000 Content-Type: text/plain; charset="utf-8" Extend the list of formats to include "sparse", which uses QEMU's mapped-ram stream format [1] to write guest memory blocks at fixed offsets in the save image file. [1] https://gitlab.com/qemu-project/qemu/-/blob/master/docs/devel/migration= /mapped-ram.rst?ref_type=3Dheads Signed-off-by: Jim Fehlig --- src/qemu/qemu.conf.in | 9 ++++++++- src/qemu/qemu_saveimage.c | 1 + src/qemu/qemu_saveimage.h | 1 + 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu.conf.in b/src/qemu/qemu.conf.in index 31172303dc..44ff658ad6 100644 --- a/src/qemu/qemu.conf.in +++ b/src/qemu/qemu.conf.in @@ -588,11 +588,18 @@ # disk space when saving large memory guests. Various compression formats = are # available for specifying a save image compressed by the named algorithm. # Supported compression formats are "zstd", "lzop", "gzip", "bzip2", and "= xz". +# The "sparse" format uses QEMU's mapped-ram stream format to write guest = memory +# blocks at fixed offsets in the save image file. =20 # save_image_format can be used to select the desired save format. "raw" is # the traditional format used by libvirt and is also the default. The # compression formats can be used to save disk space, although this typica= lly -# results in longer save and restore times. +# results in longer save and restore times. The "sparse" format results in= a +# save image file that is roughly the logical size of the guest's memory, +# although on-disk size is a function of guest memory usage. The "sparse" +# format is useful when a predictable maximum save image file size is +# needed. The other formats can result in a save image file much larger +# than guest memory if the guest runs a memory intensive workload. # # save_image_format is used with 'virsh save' or 'virsh managedsave'. It is # an error if the specified save_image_format is not valid, or cannot be diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c index d940bfb5c3..29b4e39879 100644 --- a/src/qemu/qemu_saveimage.c +++ b/src/qemu/qemu_saveimage.c @@ -45,6 +45,7 @@ VIR_ENUM_IMPL(qemuSaveFormat, "xz", "lzop", "zstd", + "sparse", ); =20 static inline void diff --git a/src/qemu/qemu_saveimage.h b/src/qemu/qemu_saveimage.h index 58f8252c8a..0411f3140a 100644 --- a/src/qemu/qemu_saveimage.h +++ b/src/qemu/qemu_saveimage.h @@ -42,6 +42,7 @@ typedef enum { QEMU_SAVE_FORMAT_XZ =3D 3, QEMU_SAVE_FORMAT_LZOP =3D 4, QEMU_SAVE_FORMAT_ZSTD =3D 5, + QEMU_SAVE_FORMAT_SPARSE =3D 6, /* Note: add new members only at the end. These values are used in the on-disk format. Do not change or re-use numbers. */ --=20 2.43.0