From nobody Wed Mar 12 17:33:30 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1741215187; cv=none; d=zohomail.com; s=zohoarc; b=gloyMEF/dKPsAIXdHxmzZ28DGdtwNEb6k4gpOwPNEFhjMRIAV5gOfDX4IDMwI+KBFpclyyg9skRvmEEqsSZ7RsjKpFFrFdanB2mLtPrj0WmMbnlKbhBaA9rlYOrNN3ny7Udc5xV6a0lQsSqQWzv2/zb2Qcr5S7haAlqPXRnoVeM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1741215187; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=llIES2+y3hsJA6ViI3nqu/iPgie595QugF5YAdcAFhY=; b=FPvQ0BcNpmAZSvqdUZT5ObaPw1jOLhSdHJiy1aOVZOwkiHHd3CmxD1kDZ/uJIl3kdr/G+oNkRaNaP7CZOc0QpXuARWL4wtnoAPkJhpifKJXB9sSp5ioOr9f1yt/UhUtmgAUadNbP1JobraTcg62b1wMvSdqMzNXEG1s1AnV0hr8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1741215187461896.5962417928058; Wed, 5 Mar 2025 14:53:07 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 5E95914E8; Wed, 5 Mar 2025 17:53:06 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 14E5316FB; Wed, 5 Mar 2025 17:50:33 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 72B441555; Wed, 5 Mar 2025 17:50:28 -0500 (EST) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D2228162E for ; Wed, 5 Mar 2025 17:50:11 -0500 (EST) Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5e53b3fa7daso6699631a12.2 for ; Wed, 05 Mar 2025 14:50:11 -0800 (PST) Received: from localhost (205-201-32-8.scinternet.net. [205.201.32.8]) by smtp.gmail.com with UTF8SMTPSA id 41be03b00d2f7-aee7ddf2b0asm12556745a12.9.2025.03.05.14.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 14:50:10 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741215011; x=1741819811; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Fh6SdXjmtp5cmhbl43dMX8xKhniM2ZKhsdDIFJMLMf8=; b=RXkVsGfVEEo5SIhy3AwiRgesyvm9EJHI+q/WVRTSXNsSh9LZtTWHfncRfusWl5iO2+ CZBnMUSWtMIq3/1QYpVe6WWR2+0RiKkY+LV8C12AeX6ohPLI+xLGUnZAqb+czbU2XIOL iaa6F1VvJLe1oy3tBFH60UvxlSR3Nd0CKGHeifcoJdLjyhaObpcC1iAfJh/Hfu4IJmop 8tXjWG8fafD3vY2Gjao6uXPJrkOyd/j1u0S/luWtdYNsrpAbZcQVIH47WMDZ9ER+OGfm SSPcaReIvx9fxoc8R6GEBwq0G1cZ1/84t7vbFhIQDo93wbP2r56kYFTuj5iog9pGxeVC QfEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741215011; x=1741819811; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fh6SdXjmtp5cmhbl43dMX8xKhniM2ZKhsdDIFJMLMf8=; b=EayY/yMl7j6B1RVNgL/4dJ27JvH0GlSeo1cwtW1x0gt48JvffCIcc2Ikvp8lsP+3NU frHdNkhgbgzeipIRlfGhs0IanzssmY6YlG75u6PqTx4Uz/nhilLalK3iZk16EY5Aqtgp Qa0qzrnd3hm04uIH0PV1aLOQI2il9vN4j8OuK0ZP9ebsyV5Fsf7BfugbuBhubd0Ae3fu iA2r9qlG6vKIs1++m2gIKGKUfOwntxtdb5Z2CHEDNAFJPfglz3oVN0CARsT6MF3pAML0 XtmtbG0yFQqPBro/+YoFqEhrKSLpkgOPr8jWBGcEt84f/QE7Q0CF9DBQdlEN093ulmsd +yDw== X-Gm-Message-State: AOJu0Yywqw2EYaeohIMZEa2pwTIlpLjp0sCistVKgeFYiPwf0tMPPNpn osMC9EQ8kJPbMj1D1sxRJnwKeK+4513PCnzp8iLBUhhCQkkL+novfzoCCg5fs3Egrkm8AfSKolC N X-Gm-Gg: ASbGncsBRTAH4H89kFP/7PeJOHqmKcuYrHmblgX3Uub3wwN3x/Hkoe84GpCGpGki8rE URhJ0LV16zS8s5dzzJHzdLHTXuUeoCO93zue0yYoYWY8JIkb9/ddy6RG/yY8/iQf9t2gWT30Bcf XFpueIolhORQqGlFn+YBOLLHwAYJkttva6SMl3Uq7f1T5wCuj69/3GqAilm1oWu2IKWjUiPlPC0 fLmyUs/l8Cz3FP+U1iKe0KubS678RSFBxUDEAeTt0xXfwX4b9IX/6/aknb580+MaileT4XsBGSq 77RfyO5Z8SXGKDiLE8WjtX0fVgQcdOtZLY9srEU44hRNUPHLwnyHJ1b8JpSuHeA= X-Google-Smtp-Source: AGHT+IFHOGb+iazn7Bhck0YszLCLkEXbm6wHFyh0iqHCUd0lJZ9q16T2pbM8edcA888u0cCR8bUSYA== X-Received: by 2002:a05:6402:90d:b0:5e0:60ed:f355 with SMTP id 4fb4d7f45d1cf-5e59f3eb5b9mr4982823a12.18.1741215010678; Wed, 05 Mar 2025 14:50:10 -0800 (PST) To: devel@lists.libvirt.org Subject: [PATCH V4 06/18] qemu: Add function to get migration params for save Date: Wed, 5 Mar 2025 15:48:15 -0700 Message-ID: <20250305224957.5369-7-jfehlig@suse.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250305224957.5369-1-jfehlig@suse.com> References: <20250305224957.5369-1-jfehlig@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: OOYR4YG24MIMIWQF3NEOO4JKZ7DNGD7G X-Message-ID-Hash: OOYR4YG24MIMIWQF3NEOO4JKZ7DNGD7G X-MailFrom: jfehlig@suse.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: farosas@suse.de X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Jim Fehlig via Devel Reply-To: Jim Fehlig X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1741215188874019100 Content-Type: text/plain; charset="utf-8" Introduce qemuMigrationParamsForSave() to create a qemuMigrationParams object initialized with appropriate migration capabilities and parameters for a save operation. Note that mapped-ram capability also requires the multifd capability. For now, the number of multifd channels is set to 1. Future work to support parallel save/restore can set the number of channels to a user-specified value. Signed-off-by: Jim Fehlig Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_migration.c | 2 +- src/qemu/qemu_migration_params.c | 21 +++++++++++++++++++++ src/qemu/qemu_migration_params.h | 3 +++ 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index e1399806d5..8753fb5358 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -7139,7 +7139,7 @@ qemuMigrationSrcToFile(virQEMUDriver *driver, virDoma= inObj *vm, =20 /* Increase migration bandwidth to unlimited since target is a file. * Failure to change migration speed is not fatal. */ - if (!(migParams =3D qemuMigrationParamsNew())) + if (!(migParams =3D qemuMigrationParamsForSave(false))) return -1; =20 if (qemuMigrationParamsSetULL(migParams, diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_par= ams.c index 4fc9199f1c..d48cdd5506 100644 --- a/src/qemu/qemu_migration_params.c +++ b/src/qemu/qemu_migration_params.c @@ -792,6 +792,27 @@ qemuMigrationParamsFromFlags(virTypedParameterPtr para= ms, } =20 =20 +qemuMigrationParams * +qemuMigrationParamsForSave(bool sparse) +{ + g_autoptr(qemuMigrationParams) saveParams =3D NULL; + + if (!(saveParams =3D qemuMigrationParamsNew())) + return NULL; + + if (sparse) { + if (virBitmapSetBit(saveParams->caps, QEMU_MIGRATION_CAP_MAPPED_RA= M) < 0) + return NULL; + if (virBitmapSetBit(saveParams->caps, QEMU_MIGRATION_CAP_MULTIFD) = < 0) + return NULL; + saveParams->params[QEMU_MIGRATION_PARAM_MULTIFD_CHANNELS].value.i = =3D 1; + saveParams->params[QEMU_MIGRATION_PARAM_MULTIFD_CHANNELS].set =3D = true; + } + + return g_steal_pointer(&saveParams); +} + + int qemuMigrationParamsDump(qemuMigrationParams *migParams, virTypedParameterPtr *params, diff --git a/src/qemu/qemu_migration_params.h b/src/qemu/qemu_migration_par= ams.h index 2379950ce9..88a1bc1a66 100644 --- a/src/qemu/qemu_migration_params.h +++ b/src/qemu/qemu_migration_params.h @@ -87,6 +87,9 @@ qemuMigrationParamsFromFlags(virTypedParameterPtr params, unsigned int flags, qemuMigrationParty party); =20 +qemuMigrationParams * +qemuMigrationParamsForSave(bool sparse); + int qemuMigrationParamsDump(qemuMigrationParams *migParams, virTypedParameterPtr *params, --=20 2.43.0