From nobody Wed Mar 12 17:52:18 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1741097686409167.3208593041685; Tue, 4 Mar 2025 06:14:46 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 602E814FE; Tue, 4 Mar 2025 09:14:45 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 3815C154E; Tue, 4 Mar 2025 09:05:20 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id B886314DC; Tue, 4 Mar 2025 09:05:11 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 956C61503 for ; Tue, 4 Mar 2025 09:04:49 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-125-MI-CJRWfPAqisa7nMg9pCQ-1; Tue, 04 Mar 2025 09:04:47 -0500 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2D4D11800986 for ; Tue, 4 Mar 2025 14:04:47 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.210]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 071F319560AB; Tue, 4 Mar 2025 14:04:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741097089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qiH6rHR+AzsfbhCI2uegn89gt22le1MPlHa0Vsmyj/Q=; b=fA17Jh6FB7MxuW0zGb/+emqwjsTRonLZ/a1UZZ5IWPX1IdJnFddydohrfe2E+l1IkWbrgO rdS1/C2JzdXxCEoJr739DvSuWCpUC6kAzDClzhgiXT7pg5K20is4xEodkRdiTO8EUqHxA1 ZlWZ6YRWLKPP6EtKI4lHqpKXfola0Eg= X-MC-Unique: MI-CJRWfPAqisa7nMg9pCQ-1 X-Mimecast-MFC-AGG-ID: MI-CJRWfPAqisa7nMg9pCQ_1741097087 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 18/19] src: add constants for domain stats 'dirtyrate.' parameters Date: Tue, 4 Mar 2025 14:04:13 +0000 Message-ID: <20250304140414.3695867-19-berrange@redhat.com> In-Reply-To: <20250304140414.3695867-1-berrange@redhat.com> References: <20250304140414.3695867-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: C36SNMK5v9-5xnvjhI7tm95YSVDe69R299lWtHJUzuE_1741097087 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CLZ6N5VCQKMZLJDQJMB4Y2JFIH54KHRT X-Message-ID-Hash: CLZ6N5VCQKMZLJDQJMB4Y2JFIH54KHRT X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1741097688753019100 Content-Type: text/plain; charset="utf-8" Contrary to most APIs returning typed parameters, there are no constants defined for the domain stats data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array indexes by simply defining the prefixes and suffixes as constants. The consuming code can then combine the constants with array index value. With this approach, it is practical to add constants for the domain stats API keys. Signed-off-by: Daniel P. Berrang=C3=A9 --- src/libvirt-domain.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 02fee7b5b9..aaa44ed3ef 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -12324,23 +12324,6 @@ virConnectGetDomainCapabilities(virConnectPtr conn, * The VIR_DOMAIN_STATS_DIRTYRATE_* constants define the known typed * parameter keys. * - * "dirtyrate.calc_status" - the status of last memory dirty rate calc= ulation, - * returned as int from virDomainDirtyRateSt= atus - * enum. - * "dirtyrate.calc_start_time" - the start time of last memory dirty r= ate - * calculation as long long. - * "dirtyrate.calc_period" - the period of last memory dirty rate calc= ulation - * as int. - * "dirtyrate.megabytes_per_second" - the calculated memory dirty rate= in - * MiB/s as long long. It is produc= ed - * only if the calc_status is measu= red. - * "dirtyrate.calc_mode" - the calculation mode used last measurement,= either - * of these 3 'page-sampling,dirty-bitmap,dirt= y-ring' - * values returned. - * "dirtyrate.vcpu..megabytes_per_second" - the calculated memory= dirty - * rate for a virtual cp= u as - * unsigned long long. - * * VIR_DOMAIN_STATS_VM: * Return hypervisor-specific statistics. Note that the naming and mea= ning * of the fields is entirely hypervisor dependent. --=20 2.48.1