From nobody Mon Feb 9 07:09:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1740601173916959.6864853519885; Wed, 26 Feb 2025 12:19:33 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id ED3DB194E; Wed, 26 Feb 2025 15:19:32 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 792691936; Wed, 26 Feb 2025 15:17:01 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id BF0461717; Wed, 26 Feb 2025 15:16:54 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8784C1941 for ; Wed, 26 Feb 2025 15:16:39 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-H6DgCMegNEaQpNPUTAJdjQ-1; Wed, 26 Feb 2025 15:16:35 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E0E231979057 for ; Wed, 26 Feb 2025 20:16:34 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.44.33.32]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 75EC5300018D; Wed, 26 Feb 2025 20:16:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740600999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UpwbJopCw1GvNNSPTTZteqraK7dn8n4pJufAUni/XLY=; b=IvtfIkZE1PV2EmU7vdM1YfwoVJsVQa3aimAfC/M1wFF03R7ETpPZPrKRLzf3PKpF3TvAs7 /zaN/Y0nzMHPxHTDZq+Ksit4Hbq2Vb9H/lOlvyUkaMYWuMegg/beTcZtGEAQxNvtLObuRx ATPBUbKU/fFHV+Slj5j42oIUq5ZJ8Gs= X-MC-Unique: H6DgCMegNEaQpNPUTAJdjQ-1 X-Mimecast-MFC-AGG-ID: H6DgCMegNEaQpNPUTAJdjQ_1740600995 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Subject: [PATCH v2 5/7] libxl: support 'rawset' ACPI table type Date: Wed, 26 Feb 2025 20:16:17 +0000 Message-ID: <20250226201619.2730066-6-berrange@redhat.com> In-Reply-To: <20250226201619.2730066-1-berrange@redhat.com> References: <20250226201619.2730066-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Q3pkcssDI7FXQIGc9pxKTHcMGyibJT-Cmt61j4RE6kU_1740600995 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: PNR3P3NSS7UONBVISEHLNX3OJHFGOGTE X-Message-ID-Hash: PNR3P3NSS7UONBVISEHLNX3OJHFGOGTE X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Victor Toso X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1740601175645019100 Content-Type: text/plain; charset="utf-8" This fixes representation of the 'acpi_firmware' config in the Xen driver, which repesents a concatenation of tables of any type. Use of 'type=3Dslic' is accepted on input for backwards compatibility. Signed-off-by: Daniel P. Berrang=C3=A9 --- src/libxl/libxl_domain.c | 5 +++-- src/libxl/xen_xl.c | 2 +- tests/xlconfigdata/test-fullvirt-acpi-slic.xml | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index e564d9e5fe..e31d92d903 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -333,11 +333,12 @@ libxlDomainDefValidate(const virDomainDef *def, =20 for (i =3D 0; i < def->os.nacpiTables; i++) { switch (def->os.acpiTables[i]->type) { - case VIR_DOMAIN_OS_ACPI_TABLE_TYPE_SLIC: + case VIR_DOMAIN_OS_ACPI_TABLE_TYPE_SLIC: /* Back compat for histor= ical mistake, + * functionally the same = as 'rawset' */ + case VIR_DOMAIN_OS_ACPI_TABLE_TYPE_RAWSET: break; =20 case VIR_DOMAIN_OS_ACPI_TABLE_TYPE_RAW: - case VIR_DOMAIN_OS_ACPI_TABLE_TYPE_RAWSET: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("ACPI table type '%1$s' is not supported"), virDomainOsACPITableTypeToString(def->os.acpiTa= bles[i]->type)); diff --git a/src/libxl/xen_xl.c b/src/libxl/xen_xl.c index 062b753cea..9d06315661 100644 --- a/src/libxl/xen_xl.c +++ b/src/libxl/xen_xl.c @@ -140,7 +140,7 @@ xenParseXLOS(virConf *conf, virDomainDef *def, virCaps = *caps) def->os.nacpiTables =3D 1; def->os.acpiTables =3D g_new0(virDomainOSACPITableDef *, 1); def->os.acpiTables[0] =3D g_new0(virDomainOSACPITableDef, 1); - def->os.acpiTables[0]->type =3D VIR_DOMAIN_OS_ACPI_TABLE_TYPE_= SLIC; + def->os.acpiTables[0]->type =3D VIR_DOMAIN_OS_ACPI_TABLE_TYPE_= RAWSET; def->os.acpiTables[0]->path =3D g_steal_pointer(&slic); } =20 diff --git a/tests/xlconfigdata/test-fullvirt-acpi-slic.xml b/tests/xlconfi= gdata/test-fullvirt-acpi-slic.xml index 366d877624..bf617e5e05 100644 --- a/tests/xlconfigdata/test-fullvirt-acpi-slic.xml +++ b/tests/xlconfigdata/test-fullvirt-acpi-slic.xml @@ -8,7 +8,7 @@ hvm /usr/lib/xen/boot/hvmloader - /sys/firmware/acpi/tables/SLIC
+ /sys/firmware/acpi/tables/SLIC
 --=20 2.47.1