From nobody Fri Dec 19 15:49:45 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1739852731335836.3170058115386; Mon, 17 Feb 2025 20:25:31 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 123B61789; Mon, 17 Feb 2025 23:25:30 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 165641796; Mon, 17 Feb 2025 23:25:14 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 70BB11775; Mon, 17 Feb 2025 23:25:10 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B84291478 for ; Mon, 17 Feb 2025 23:25:09 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-213-bMziazkCPzy2reYXv8ocTA-1; Mon, 17 Feb 2025 23:25:07 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AD05C1800876 for ; Tue, 18 Feb 2025 04:25:06 +0000 (UTC) Received: from tilapia.redhat.com (unknown [10.22.64.13]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1C0E8180035F for ; Tue, 18 Feb 2025 04:25:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739852709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bBJ8B2J2H+h4Ko2+EmYNE4mxoKoM9Ds5ryQvcMvFs6Q=; b=e1YIjDj9XSyKt9G+8HqmsczWEvGlaiugnj1KGR9GHRg5DlfwlukGOr5kJu8zhNmIDy4u5W 0Y5QAOS6xtLA+J9E+LPFz2WC2RySff7/EoLguYcD1HxqFjERCd9nD87X7x4zs/kwWz3wnZ tYzEtu2Oz7Zq3/F1QPmGU7kiVQTk2+k= X-MC-Unique: bMziazkCPzy2reYXv8ocTA-1 X-Mimecast-MFC-AGG-ID: bMziazkCPzy2reYXv8ocTA_1739852707 From: Laine Stump To: devel@lists.libvirt.org Subject: [PATCH] util: fix compile warning in virsystemd.c during mingw builds Date: Mon, 17 Feb 2025 23:23:01 -0500 Message-ID: <20250218042505.2248969-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _R3Va5dhqi7xXr_tXVyfMdJLcs-YvMlCpsRQDMtYq34_1739852707 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: TCEH3BYYFXEGFTIQ3PKRUBRIWZOCNNB2 X-Message-ID-Hash: TCEH3BYYFXEGFTIQ3PKRUBRIWZOCNNB2 X-MailFrom: laine@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1739852733527019100 Content-Type: text/plain; charset="utf-8"; x-default="true" A function was changed from having no arguments to having a single argument, but the entire body of the function was #ifdefed out for windows builds, leaving that new argument unused. Surprisingly this didn't cause the build to fail, but I happened to notice it flit by during an rpm build. Fixes: 785cd56e5803fbbf60715fb6c7536360df5b4b9e Signed-off-by: Laine Stump --- I'm pushing this as trivial (technically it's not a build breaker, since the build still continues even with the warning :-P) src/util/virsystemd.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index 57fe409c57..92d2890360 100644 --- a/src/util/virsystemd.c +++ b/src/util/virsystemd.c @@ -624,10 +624,15 @@ int virSystemdTerminateMachine(const char *name) return 0; } =20 +#ifdef WIN32 +static void +virSystemdNotify(const char *msg G_GNUC_UNUSED) +{ +} +#else static void virSystemdNotify(const char *msg) { -#ifndef WIN32 const char *path; int fd; struct sockaddr_un un =3D { @@ -672,8 +677,8 @@ virSystemdNotify(const char *msg) VIR_WARN("Failed to notify systemd"); =20 VIR_FORCE_CLOSE(fd); -#endif /* !WIN32 */ } +#endif /* !WIN32 */ =20 void virSystemdNotifyReady(void) { --=20 2.47.1