From nobody Fri Dec 19 21:50:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1739589345; cv=none; d=zohomail.com; s=zohoarc; b=iySrovOXek4SUI3tW0Dkq5GOLa7VLRi2jODLMqxa8PN6FVVvIO624r/gv9BokYTQrkeDYCsvszwHUML0dwzHWPK4cIZTGxal2umxUwCjQBBmaHVoxDaY2OILdWDneckXvS9VZOUqpfWMiUuvl7WpBndW/lDgNJztwSQXNJBGax8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1739589345; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=GKgrCfvAdg0kArGMtADlyN1VztrcCQreLsKYlh39sEg=; b=Jmq3QKalGmFYnkMWwNHP8pDFrxOValLgd7kIauoOHd+uf9PvePTGghDOPcXi7/tZj1R2OXilSNWmdmWkZ7Y+0+ow7jFML4aDxHi8/a59Rup/wP+8KKMhb3RRl/SY/JKmOt+1Pahj+k+n8FmrGQZPXX2RTxwKKV69miMb1G1nL5U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1739589345706439.76728054751345; Fri, 14 Feb 2025 19:15:45 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 9E2701C32; Fri, 14 Feb 2025 22:15:44 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 28C931C34; Fri, 14 Feb 2025 22:14:58 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 344521BC7; Fri, 14 Feb 2025 22:14:52 -0500 (EST) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 93BC019A5 for ; Fri, 14 Feb 2025 22:14:51 -0500 (EST) Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4395a06cf43so17018805e9.2 for ; Fri, 14 Feb 2025 19:14:51 -0800 (PST) Received: from localhost (75-169-8-111.slkc.qwest.net. [75.169.8.111]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-220d556dd64sm36048735ad.189.2025.02.14.19.14.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2025 19:14:50 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1739589290; x=1740194090; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=WK1/26Gg6VLozFACR/GEH7MEqsxdhvqwSq0Pu0q22oU=; b=aOQVxo1myOm1kD0kWwTsU8vkSA5mE7hC0iyqUnoigeD8AhGto9y6G7YutIjawnU3h9 9vRCyiwngiptDYrNmmmFw/if3lC9wsTQpqqqBYiTdmliZyM0pFWvsM+DI4n7fqb+Xzgw pdfveTSbdPt0aPyPzb3I7K9wv21slRqOXkMzfbBX7hUhLBS5uCRAYLxYoU6ug6gP56uP 4eml5UMvo/s3zrWEj0cCjtAnLPrz9LwOG+p2gPVyFLAGciT2ENYfbJC8+Pz7MVF/XpkP nyh9q7sKa5GP0Af6KdLnFBrjPP2GDFLzUiFNb1bnJS/gSOiEcU1mqU1zgtU3ve2ZjHga 3BvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739589290; x=1740194090; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WK1/26Gg6VLozFACR/GEH7MEqsxdhvqwSq0Pu0q22oU=; b=dIuESr8FK8qrEVt1boqchp7UYTl5CfCFEQfzndjEiSflgA8UODGH/G0Er5/0xm3rAp kYYY7G+sY+17Qb/ZE3ofB9BQqxXORDdpAGzZLFJ3hjbjGqH28gvR3fu57teb8HRdJxaa +kq8ggmfVJgQurUQM7gifSvAXUT7tszs15rf2iw31rkLpk9j64tzaUGLarkpEKX0M8Cm IDmxLGf/uM7eaRdvh8xZQifAxPhObAEGpkl9i+zsiTITKKb1aUF5YX3a6YSj7dsecgFf dZ4XwxKcx96Sxy0zl9OPlIv5uM6LN3nUdBkAIdfD0JPUO9yfFFJHRS+6W/NOQTt/Q6CY 8/Hw== X-Gm-Message-State: AOJu0YzslmnH1PK57QfYhJ3iAZ+ZhpdR48zaZPpt+7QzUeeRPhwkBSKO fszvgrZVqalNtyWcKZ9kDG88rLGSI6VCrqK6J62G2vwbYWMg+2Hy6aTMIGU0fyowxC9CMuApGPo g X-Gm-Gg: ASbGncvE84oF0hzwZph8n8IyWOztEfqA2iN1qna0qX1AZSCQ81vU4AznE8wIY0LO6pH jIimm5CE5ITN7Cr1UKZi2U451jqMKjmRnviocv3w/f3digpHtG/i/J+dYjVF436qSXc/kaq6Hnx 0Rnuy5BavJNq+z0/lyWtecDSovieUKVfXYCkU/Y/fRoeiwwfm9vGUur4uNrtnz65fW7upIqLTeO VXrW49DEJH80AXzAdGm4gS6NCHQmwwGvH4SgG46Yhp4JayZmyHmTKEhmkMiwUZfR0V2lJyagRIc R+5vTYl6MkFEMK65vRHz3eUSDebS5msoFw== X-Google-Smtp-Source: AGHT+IGtjKdvQt3AY5Pd5bdKHyGjP9IMGMPPIN5ZrYKKSfSAD586Ih8NYdk6Qk9HVM/Ppe3ob0tQBg== X-Received: by 2002:a05:6000:156c:b0:38f:3009:61c1 with SMTP id ffacd0b85a97d-38f33f50a65mr1229620f8f.26.1739589290515; Fri, 14 Feb 2025 19:14:50 -0800 (PST) To: devel@lists.libvirt.org Subject: [PATCH 2/2] qemu: Add support for 'image_format' typed parameter Date: Fri, 14 Feb 2025 20:03:10 -0700 Message-ID: <20250215031444.23337-3-jfehlig@suse.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250215031444.23337-1-jfehlig@suse.com> References: <20250215031444.23337-1-jfehlig@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: REHZWE244JLXTLQ6TLPPVCZPQE7JEMVY X-Message-ID-Hash: REHZWE244JLXTLQ6TLPPVCZPQE7JEMVY X-MailFrom: jfehlig@suse.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Jim Fehlig via Devel Reply-To: Jim Fehlig X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1739589348293019100 Content-Type: text/plain; charset="utf-8" Add support for the 'image_format' typed parameter in virDomainSaveParams. The parameter overrides the 'save_image_format' setting in qemu.conf. Signed-off-by: Jim Fehlig --- src/qemu/qemu_driver.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a868cca72c..41f547de19 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2821,6 +2821,7 @@ qemuDomainSaveParams(virDomainPtr dom, g_autoptr(virCommand) compressor =3D NULL; const char *to =3D NULL; const char *dxml =3D NULL; + const char *formatstr =3D NULL; int format =3D QEMU_SAVE_FORMAT_RAW; int ret =3D -1; =20 @@ -2833,6 +2834,8 @@ qemuDomainSaveParams(virDomainPtr dom, VIR_TYPED_PARAM_STRING, VIR_DOMAIN_SAVE_PARAM_DXML, VIR_TYPED_PARAM_STRING, + VIR_DOMAIN_SAVE_PARAM_IMAGE_FORMAT, + VIR_TYPED_PARAM_STRING, NULL) < 0) return -1; =20 @@ -2842,6 +2845,9 @@ qemuDomainSaveParams(virDomainPtr dom, if (virTypedParamsGetString(params, nparams, VIR_DOMAIN_SAVE_PARAM_DXML, &dxml) < 0) return -1; + if (virTypedParamsGetString(params, nparams, + VIR_DOMAIN_SAVE_PARAM_IMAGE_FORMAT, &forma= tstr) < 0) + return -1; =20 if (!(vm =3D qemuDomainObjFromDomain(dom))) goto cleanup; @@ -2855,8 +2861,10 @@ qemuDomainSaveParams(virDomainPtr dom, } =20 cfg =3D virQEMUDriverGetConfig(driver); - if (cfg->saveImageFormat && - (format =3D qemuSaveFormatTypeFromString(cfg->saveImageFormat)) < = 0) + if (formatstr =3D=3D NULL) + formatstr =3D cfg->saveImageFormat; + + if (formatstr && (format =3D qemuSaveFormatTypeFromString(formatstr)) = < 0) goto cleanup; =20 if (qemuSaveImageGetCompressionProgram(format, &compressor, "save") < = 0) --=20 2.43.0