From nobody Thu Dec 18 06:14:40 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1739375261609525.5010809896617; Wed, 12 Feb 2025 07:47:41 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 16E7418A4; Wed, 12 Feb 2025 10:47:41 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 2F749199D; Wed, 12 Feb 2025 10:46:58 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id BD2DE11E3; Wed, 12 Feb 2025 10:46:53 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 47765167A for ; Wed, 12 Feb 2025 10:46:53 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-91-BLPheEZTNzuK8F3N-vYokA-1; Wed, 12 Feb 2025 10:46:51 -0500 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DD4201801A0D for ; Wed, 12 Feb 2025 15:46:50 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.45.224.110]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9F4461955F1B; Wed, 12 Feb 2025 15:46:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739375213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4V1ZpT9YDuXpwNymYY82UbfSEVKfMK8SUUjAwSg0At0=; b=erbJxnoD1PLkSxLMa8UTvaQUEiFCQpwmDj4ZQqD2qk2L5+034lxfJeOZXM929T0Y+8Hxxx bASGDBLbTgsbDOA98PL1Lacrn2sSYXx76dUaPUnob86rS49974i3J5+fGQOe57VgvtJhzp cq78T6+7B0hXI7J0F5zusr6VjjUDVbQ= X-MC-Unique: BLPheEZTNzuK8F3N-vYokA-1 X-Mimecast-MFC-AGG-ID: BLPheEZTNzuK8F3N-vYokA_1739375211 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH v2 1/8] bhyve: add 'driver' to bhyveProcessStart method Date: Wed, 12 Feb 2025 15:46:39 +0000 Message-ID: <20250212154646.913282-2-berrange@redhat.com> In-Reply-To: <20250212154646.913282-1-berrange@redhat.com> References: <20250212154646.913282-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: k5DZ6iGx7z-1OTkh42-AX8U7NSAMQXGhFfiJgZYvcWg_1739375211 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: V4D43AIZHRDMOPWMDYEBBEWY3GUF2VGB X-Message-ID-Hash: V4D43AIZHRDMOPWMDYEBBEWY3GUF2VGB X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1739375262266019000 Content-Type: text/plain; charset="utf-8" This allows for passinga NULL connection object in cases where domain autodestroy is not required. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- src/bhyve/bhyve_driver.c | 6 +++--- src/bhyve/bhyve_process.c | 5 ++--- src/bhyve/bhyve_process.h | 3 ++- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 8f97ac032c..ea5a9be4fb 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -79,7 +79,7 @@ bhyveAutostartDomain(virDomainObj *vm, void *opaque) =20 if (vm->autostart && !virDomainObjIsActive(vm)) { virResetLastError(); - ret =3D virBhyveProcessStart(data->conn, vm, + ret =3D virBhyveProcessStart(bhyve_driver, data->conn, vm, VIR_DOMAIN_RUNNING_BOOTED, 0); if (ret < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, @@ -834,7 +834,7 @@ bhyveDomainCreateWithFlags(virDomainPtr dom, goto cleanup; } =20 - ret =3D virBhyveProcessStart(dom->conn, vm, + ret =3D virBhyveProcessStart(privconn, dom->conn, vm, VIR_DOMAIN_RUNNING_BOOTED, start_flags); =20 @@ -892,7 +892,7 @@ bhyveDomainCreateXML(virConnectPtr conn, VIR_DOMAIN_OBJ_LIST_ADD_CHECK_LIVE, NUL= L))) goto cleanup; =20 - if (virBhyveProcessStart(conn, vm, + if (virBhyveProcessStart(privconn, conn, vm, VIR_DOMAIN_RUNNING_BOOTED, start_flags) < 0) { /* If domain is not persistent, remove its data */ diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index 41feabcbe7..3e6f678cf5 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/bhyve/bhyve_process.c @@ -270,13 +270,12 @@ bhyveProcessPrepareDomain(bhyveConn *driver, } =20 int -virBhyveProcessStart(virConnectPtr conn, +virBhyveProcessStart(bhyveConn *driver, + virConnectPtr conn, virDomainObj *vm, virDomainRunningReason reason, unsigned int flags) { - struct _bhyveConn *driver =3D conn->privateData; - /* Run an early hook to setup missing devices. */ if (bhyveProcessStartHook(driver, vm, VIR_HOOK_BHYVE_OP_PREPARE) < 0) return -1; diff --git a/src/bhyve/bhyve_process.h b/src/bhyve/bhyve_process.h index 668411db57..e69db41fc2 100644 --- a/src/bhyve/bhyve_process.h +++ b/src/bhyve/bhyve_process.h @@ -28,7 +28,8 @@ bhyveProcessPrepareDomain(bhyveConn *driver, virDomainObj *vm, unsigned int flags); =20 -int virBhyveProcessStart(virConnect *conn, +int virBhyveProcessStart(bhyveConn *driver, + virConnectPtr conn, virDomainObj *vm, virDomainRunningReason reason, unsigned int flags); --=20 2.47.1