From nobody Fri Dec 19 07:49:55 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1739334757915570.8856588518629; Tue, 11 Feb 2025 20:32:37 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id E7C7A1492; Tue, 11 Feb 2025 23:32:36 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 8652C170E; Tue, 11 Feb 2025 23:29:33 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 527A91499; Tue, 11 Feb 2025 23:29:20 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B7CAF1301 for ; Tue, 11 Feb 2025 23:29:19 -0500 (EST) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-YHMo9OCVM5ehQgdh22AYww-1; Tue, 11 Feb 2025 23:29:17 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0007D1955DD0 for ; Wed, 12 Feb 2025 04:29:16 +0000 (UTC) Received: from vhost3.router.laine.org (unknown [10.22.64.63]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7E35B1800570 for ; Wed, 12 Feb 2025 04:29:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739334559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fmn6oiLnUi4psRdCb38V7jNZH90WqZ2oiaM+X1FwnoA=; b=aT1LCjofl33YZQUFZ0ZrEiZfNrTopjebTSx0XEIRoIImfxwRmIbFmM2c6G/CQ9myGeejlS FpoYiVMhxMmSXouYL3km6S1PXv2l/Us4o/xr07QNCQJu8+HAgQ30r2VL9M2jJiz+WCoHvX Vu5MOnqmhHw3o7NUSPHVHcG7FKN3VhY= X-MC-Unique: YHMo9OCVM5ehQgdh22AYww-1 X-Mimecast-MFC-AGG-ID: YHMo9OCVM5ehQgdh22AYww From: Laine Stump To: devel@lists.libvirt.org Subject: [PATCH 07/17] conf: change qemuDomainDefAddImplicitInputDevice() to return void Date: Tue, 11 Feb 2025 23:29:00 -0500 Message-ID: <20250212042910.548504-8-laine@redhat.com> In-Reply-To: <20250212042910.548504-1-laine@redhat.com> References: <20250212042910.548504-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DeboG36daxegG-vdwMm1Xb_4hHJZCGzYeRQCCd59MOM_1739334557 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 234PCSU33N2DF4HKFJA5VT3L343NSYAD X-Message-ID-Hash: 234PCSU33N2DF4HKFJA5VT3L343NSYAD X-MailFrom: laine@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1739334759326019100 Content-Type: text/plain; charset="utf-8"; x-default="true" It can't fail. Signed-off-by: Laine Stump Reviewed-by: Martin Kletzander --- src/qemu/qemu_postparse.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_postparse.c b/src/qemu/qemu_postparse.c index 53151eef75..0de48916f4 100644 --- a/src/qemu/qemu_postparse.c +++ b/src/qemu/qemu_postparse.c @@ -1089,7 +1089,7 @@ qemuDomainDefBootPostParse(virDomainDef *def, } =20 =20 -static int +static void qemuDomainDefAddImplicitInputDevice(virDomainDef *def, virQEMUCaps *qemuCaps) { @@ -1098,8 +1098,6 @@ qemuDomainDefAddImplicitInputDevice(virDomainDef *def, virDomainDefMaybeAddInput(def, VIR_DOMAIN_INPUT_TYPE_MOUSE, VIR_DO= MAIN_INPUT_BUS_PS2); virDomainDefMaybeAddInput(def, VIR_DOMAIN_INPUT_TYPE_KBD, VIR_DOMA= IN_INPUT_BUS_PS2); } - - return 0; } =20 =20 @@ -1194,8 +1192,7 @@ qemuDomainDefAddDefaultDevices(virQEMUDriver *driver, bool addIOMMU =3D false; =20 /* add implicit input devices */ - if (qemuDomainDefAddImplicitInputDevice(def, qemuCaps) < 0) - return -1; + qemuDomainDefAddImplicitInputDevice(def, qemuCaps); =20 /* Add implicit PCI root controller if the machine has one */ switch (def->os.arch) { --=20 2.47.1