From nobody Mon Feb 9 00:04:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=reject dis=none) header.from=linux.ibm.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1738689286178508.72214570792846; Tue, 4 Feb 2025 09:14:46 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 86E041BE8; Tue, 4 Feb 2025 12:13:01 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 001751DD9; Tue, 4 Feb 2025 12:11:56 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 427091B9C; Tue, 4 Feb 2025 12:11:50 -0500 (EST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 935E91B5C for ; Tue, 4 Feb 2025 12:11:49 -0500 (EST) Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 514GEmtb023148 for ; Tue, 4 Feb 2025 17:11:48 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44kn62gpmq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 04 Feb 2025 17:11:48 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 514E0fTF021483 for ; Tue, 4 Feb 2025 17:11:47 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 44j0n1c77m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 04 Feb 2025 17:11:47 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 514HBiPX42598742 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 4 Feb 2025 17:11:44 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4BB9E200B5; Tue, 4 Feb 2025 17:11:44 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3A55C200BB; Tue, 4 Feb 2025 17:11:44 +0000 (GMT) Received: from fiuczyvm.. (unknown [9.152.222.247]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 4 Feb 2025 17:11:44 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=zERniW45UUpnAdS4P KtpNlcRE62z3zG52II5bVswYjs=; b=e0gVIezLUoia3biDVhO9qG58CqtXvjRTf /FdBiXtN3PACvpFa/XXxbPXLbo2i36IWFX91jeJxA5U+5cBEPQCgt8z2j9buWN1l L/hKjbAfNEsWatGFGRSEwWDwN4YgspTSF5oK+cpF7J1ZF+TjRW/leuzHMjcZukGn CcaxHz0mCzKGIFUBApNAHFX7EHwkWeAffi1aTQBmvzf1B0zR1k11eT49Mi4dFVqf 16fOzCf4T1Mu259OPVasfWLAxvftnYczk7COTDF/kPKco5MD0RrvjQoePIcQ9tN4 EysRBOJ8oljXC9+/5atI6R3CUBLPoUt6kQqGw4qy6/VACuHYnE2NA== From: Boris Fiuczynski To: devel@lists.libvirt.org Subject: [PATCH 3/8] nodedev: remove virNodeDeviceCapCCWDefFormat Date: Tue, 4 Feb 2025 18:11:38 +0100 Message-ID: <20250204171143.93141-4-fiuczy@linux.ibm.com> X-Mailer: git-send-email 2.48.0 In-Reply-To: <20250204171143.93141-1-fiuczy@linux.ibm.com> References: <20250204171143.93141-1-fiuczy@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: g1vnl6PTGSF46SdFLAknQirBQbgnkXpG X-Proofpoint-ORIG-GUID: g1vnl6PTGSF46SdFLAknQirBQbgnkXpG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-04_08,2025-02-04_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 priorityscore=1501 suspectscore=0 impostorscore=0 bulkscore=0 mlxlogscore=893 spamscore=0 lowpriorityscore=0 phishscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502040131 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: VWS3JAAY2XBTR2TR5LCNKR6JERLYKG4I X-Message-ID-Hash: VWS3JAAY2XBTR2TR5LCNKR6JERLYKG4I X-MailFrom: fiuczy@linux.ibm.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Boris Fiuczynski X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1738689297871019100 Content-Type: text/plain; charset="utf-8" Directly use virCCWDeviceAddressFormat. Reviewed-by: Marc Hartmayer Signed-off-by: Boris Fiuczynski --- src/conf/node_device_conf.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 85effb7d78..433334511f 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -636,21 +636,13 @@ virCCWDeviceAddressFormat(virBuffer *buf, } =20 =20 -static void -virNodeDeviceCapCCWDefFormat(virBuffer *buf, - const virNodeDevCapData *data) -{ - virCCWDeviceAddressFormat(buf, data->ccw_dev.dev_addr); -} - - static void virNodeDeviceCapCSSDefFormat(virBuffer *buf, const virNodeDevCapData *data) { virNodeDevCapCCW ccw_dev =3D data->ccw_dev; =20 - virNodeDeviceCapCCWDefFormat(buf, data); + virCCWDeviceAddressFormat(buf, ccw_dev.dev_addr); =20 if (ccw_dev.channel_dev_addr) { virBufferAddLit(buf, "\n"); @@ -758,7 +750,7 @@ virNodeDeviceDefFormat(const virNodeDeviceDef *def, uns= igned int flags) const char *state =3D virNodeDevCCWStateTypeToString(data-= >ccw_dev.state); virBufferEscapeString(&buf, "%s\n", state); } - virNodeDeviceCapCCWDefFormat(&buf, data); + virCCWDeviceAddressFormat(&buf, data->ccw_dev.dev_addr); break; case VIR_NODE_DEV_CAP_CSS_DEV: virNodeDeviceCapCSSDefFormat(&buf, data); --=20 2.47.0