From nobody Tue Sep 9 23:53:10 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1738158177813133.8188957034481; Wed, 29 Jan 2025 05:42:57 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 9FD1917B3; Wed, 29 Jan 2025 08:42:57 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id DB5B7176F; Wed, 29 Jan 2025 08:41:32 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id BAB551500; Wed, 29 Jan 2025 08:41:27 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 13A7114D2 for ; Wed, 29 Jan 2025 08:41:14 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-580-7jBXGvxzO5-Wu9K3GpM-yg-1; Wed, 29 Jan 2025 08:41:12 -0500 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 383FD18009FD for ; Wed, 29 Jan 2025 13:41:11 +0000 (UTC) Received: from localhost (unknown [10.39.208.35]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id ABD4219560AA; Wed, 29 Jan 2025 13:41:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738158073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GhcMdCCwupmOv4dV8veseqp8e5fOZblw/uzFpoi57hU=; b=b2Jz83u8emvuakeVtNM2yYLD8X6Nwoi77J3n+SB7mqbhEabY3GTAmLDRBmBDjAMqrcNLIH BChAaY1mzMZ+SHLfDrYOqz8KWXz8r+poj9wRGs/ap3iyCeDhg9ik+HFcR6/erLVVSKCCqP amPS86KBwq1KimBCaPjfwwPQvgAx2q8= X-MC-Unique: 7jBXGvxzO5-Wu9K3GpM-yg-1 X-Mimecast-MFC-AGG-ID: 7jBXGvxzO5-Wu9K3GpM-yg From: marcandre.lureau@redhat.com To: devel@lists.libvirt.org Subject: [PATCH 04/19] util: add conn != NULL precondition in virGDBusCallMethod() Date: Wed, 29 Jan 2025 17:40:26 +0400 Message-ID: <20250129134042.1282472-5-marcandre.lureau@redhat.com> In-Reply-To: <20250129134042.1282472-1-marcandre.lureau@redhat.com> References: <20250129134042.1282472-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: o2FfnWr8DJx_Wv65v1DwheANS3ilMc4bagLfV8nbusI_1738158071 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: HT6HNB77EUSNCBSR2P7VRILJY2U6DKCG X-Message-ID-Hash: HT6HNB77EUSNCBSR2P7VRILJY2U6DKCG X-MailFrom: marcandre.lureau@redhat.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 CC: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1738158179950019000 Content-Type: text/plain; charset="utf-8" From: Marc-Andr=C3=A9 Lureau Helps avoid/debug a potential SEGV if conn is NULL, since gio will not set the "gerror" in that case and we will crash later at: virReportError(VIR_ERR_DBUS_SERVICE, "%s", gerror->message); Signed-off-by: Marc-Andr=C3=A9 Lureau --- src/util/virgdbus.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/util/virgdbus.c b/src/util/virgdbus.c index 71ca3cd43b..5e11a95106 100644 --- a/src/util/virgdbus.c +++ b/src/util/virgdbus.c @@ -213,6 +213,8 @@ virGDBusCallMethod(GDBusConnection *conn, g_autoptr(GVariant) ret =3D NULL; g_autoptr(GError) gerror =3D NULL; =20 + g_return_val_if_fail(conn !=3D NULL, -1); + if (error) memset(error, 0, sizeof(*error)); =20 @@ -268,6 +270,8 @@ virGDBusCallMethodWithFD(GDBusConnection *conn, g_autoptr(GVariant) ret =3D NULL; g_autoptr(GError) gerror =3D NULL; =20 + g_return_val_if_fail(conn !=3D NULL, -1); + if (error) memset(error, 0, sizeof(*error)); =20 --=20 2.47.0