From nobody Tue Sep 9 23:58:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1737559156503980.0837569686308; Wed, 22 Jan 2025 07:19:16 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id ED53412D0; Wed, 22 Jan 2025 10:19:15 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 37FD7165A; Wed, 22 Jan 2025 10:17:34 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id D0BBB15F4; Wed, 22 Jan 2025 10:17:30 -0500 (EST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 046D215B6 for ; Wed, 22 Jan 2025 10:17:18 -0500 (EST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-21c2f1b610dso124483935ad.0 for ; Wed, 22 Jan 2025 07:17:17 -0800 (PST) Received: from grind.. ([191.202.238.10]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21c2d402f7dsm96059215ad.216.2025.01.22.07.17.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jan 2025 07:17:14 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1737559036; x=1738163836; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GH75Ca+Cb2yr7TGbw9h1xQ7lauvGD6n7YyCa7+VNWQ4=; b=CM86Jer9vuvU4lPtiDSTgXNYWGdeNEbcfF1999OQZNJO/dWzBrH/NsbR+JIqkiaPxO 1XYXnYc3H4XHSPPjyhp6/Ye11bZK1aqXkwsKiOiNN7kbKiV81240sz7L8hk1a8tbIK2d zzPXtdWnKIiSd/fNoMA6eY9aBHf1tK4Mvfmu4JBBm/GTxsvMCUuoXJ8jPncXWG23jKIh 9NHUijdGEpfxAKgIKKH2iYCcMKD6p6lNYB7TEX7stzaWTtEgiLM3O2tMIXXvKsTFfSsh JRxOsucwvd2TU66UoTQsAS2VWiOup28Vc8GML0mVeSAVciAp6ORJB7CXH0/PYyAR2KcT IdJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737559036; x=1738163836; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GH75Ca+Cb2yr7TGbw9h1xQ7lauvGD6n7YyCa7+VNWQ4=; b=r7XXjBbc1h/2/8yreCGa6K7UbGXzMVR8JGsRc50iMSK0YsuncLRWh2EZah3VF0M+d3 E+N5VJK6tkCVxgszDtqOU2J7Q71gg8v1kx1Jpim1az3rc5mJTSudrCPtSyMW+6ScU+RZ qpfZLUXDgBN+/ge4JBiNyaR2IEORdDpSh6bwWXtsfcmaDdSkJlKaktDD50dqCfZK3ZMc uQuECWbXhxwJBkcDzLAec67T4d9I/Hw8Wfpb86rVlUMdDmCk8sepIO7KL9+JBtTcuUOD fX7CchVucgf7HhDkwq7T/n0Mp97eFjD/0p0oN/X2ueSLyImorXlAwRWP6aYgP4mA0yCf kRVg== X-Gm-Message-State: AOJu0YxSC8aQNwn48ROtehxn2cZMA2tnsLgk5oYg4dZ3ao5EIvzEJbb7 MCQ+Q8OKqzcB4mx+p/B2Mdr2BJiQSekD0GTfz2xeFBO9qJKy1W94749EVb7JROXrLRBJ/Df6rKq s X-Gm-Gg: ASbGncv6JUYQT/XKfX8VUjShU+ZGrChe9pmQRXmzx1BVTJ+a8nfPYPW497R5rgg/Wew A8kPAHzCluFx2rL+DGEF0BsjLQgozZUPWuMuPsuo5DjcXb1gvyguYyN7AHZ+7DU4mGg3tlxj4Gg m9MUW3OJoexs0ohYW0QezR47Gv1ILUSB57sXPdk/TlaJr6fumfOUvy7LuClLz4ZYRbVZfn3pI80 VIKQvRvZyZKQLkvyU0Agn1mIlIkf/1vUjIh8/F2ZVxxKjsDHjUg0+ugSbJP5nW4qE8W7RHA X-Google-Smtp-Source: AGHT+IFdPzl+/px4cMPM2ivTncgkZ3DwUORuoVhQZhNYR7+mXzH6+ZyOBQVPMREgFVs0FCtnFxJsZg== X-Received: by 2002:a17:902:e74a:b0:216:56c7:98a7 with SMTP id d9443c01a7336-21c35618995mr351780105ad.53.1737559034860; Wed, 22 Jan 2025 07:17:14 -0800 (PST) From: Daniel Henrique Barboza To: devel@lists.libvirt.org Subject: [PATCH v2 3/3] qemu: add RISC-V 'aia' command line Date: Wed, 22 Jan 2025 12:17:02 -0300 Message-ID: <20250122151702.95617-5-dbarboza@ventanamicro.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250122151702.95617-1-dbarboza@ventanamicro.com> References: <20250122151702.95617-1-dbarboza@ventanamicro.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: OEBKC6W2TJYSQAKUVIOBV7P52QCARMNE X-Message-ID-Hash: OEBKC6W2TJYSQAKUVIOBV7P52QCARMNE X-MailFrom: dbarboza@ventanamicro.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: dbarboza@ventanamicro.com X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1737559158528019000 Content-Type: text/plain; charset="utf-8" The 'aia' feature is added as a machine type option for the 'virt' RISC-V machine, e.g. "-machine virt,aia=3D". Signed-off-by: Daniel Henrique Barboza Reviewed-by: Martin Kletzander --- src/qemu/qemu_command.c | 5 +++ ...cv64-virt-features-aia.riscv64-latest.args | 31 +++++++++++++++++++ ...scv64-virt-features-aia.riscv64-latest.xml | 1 + .../riscv64-virt-features-aia.xml | 27 ++++++++++++++++ tests/qemuxmlconftest.c | 2 ++ 5 files changed, 66 insertions(+) create mode 100644 tests/qemuxmlconfdata/riscv64-virt-features-aia.riscv64= -latest.args create mode 120000 tests/qemuxmlconfdata/riscv64-virt-features-aia.riscv64= -latest.xml create mode 100644 tests/qemuxmlconfdata/riscv64-virt-features-aia.xml diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 1f28de6194..1f20189e89 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6741,6 +6741,11 @@ qemuAppendDomainFeaturesMachineParam(virBuffer *buf, virBufferAsprintf(buf, ",i8042=3D%s", str); } =20 + if (def->features[VIR_DOMAIN_FEATURE_AIA] !=3D VIR_DOMAIN_AIA_DEFAULT)= { + const char *str =3D virDomainAIATypeToString(def->features[VIR_DOM= AIN_FEATURE_AIA]); + virBufferAsprintf(buf, ",aia=3D%s", str); + } + return 0; } =20 diff --git a/tests/qemuxmlconfdata/riscv64-virt-features-aia.riscv64-latest= .args b/tests/qemuxmlconfdata/riscv64-virt-features-aia.riscv64-latest.args new file mode 100644 index 0000000000..0256026ba4 --- /dev/null +++ b/tests/qemuxmlconfdata/riscv64-virt-features-aia.riscv64-latest.args @@ -0,0 +1,31 @@ +LC_ALL=3DC \ +PATH=3D/bin \ +HOME=3D/var/lib/libvirt/qemu/domain--1-guest \ +USER=3Dtest \ +LOGNAME=3Dtest \ +XDG_DATA_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.local/share \ +XDG_CACHE_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.cache \ +XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.config \ +/usr/bin/qemu-system-riscv64 \ +-name guest=3Dguest,debug-threads=3Don \ +-S \ +-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ +-machine virt,usb=3Doff,aia=3Dnone,dump-guest-core=3Doff,memory-backend=3D= riscv_virt_board.ram,acpi=3Doff \ +-accel tcg \ +-cpu rv64 \ +-m size=3D4194304k \ +-object '{"qom-type":"memory-backend-ram","id":"riscv_virt_board.ram","siz= e":4294967296}' \ +-overcommit mem-lock=3Doff \ +-smp 4,sockets=3D4,cores=3D1,threads=3D1 \ +-uuid 1ccfd97d-5eb4-478a-bbe6-88d254c16db7 \ +-display none \ +-no-user-config \ +-nodefaults \ +-chardev socket,id=3Dcharmonitor,fd=3D1729,server=3Don,wait=3Doff \ +-mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ +-rtc base=3Dutc \ +-no-shutdown \ +-boot strict=3Don \ +-audiodev '{"id":"audio1","driver":"none"}' \ +-sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ +-msg timestamp=3Don diff --git a/tests/qemuxmlconfdata/riscv64-virt-features-aia.riscv64-latest= .xml b/tests/qemuxmlconfdata/riscv64-virt-features-aia.riscv64-latest.xml new file mode 120000 index 0000000000..1ab55fc10e --- /dev/null +++ b/tests/qemuxmlconfdata/riscv64-virt-features-aia.riscv64-latest.xml @@ -0,0 +1 @@ +riscv64-virt-features-aia.xml \ No newline at end of file diff --git a/tests/qemuxmlconfdata/riscv64-virt-features-aia.xml b/tests/qe= muxmlconfdata/riscv64-virt-features-aia.xml new file mode 100644 index 0000000000..60bbb82c74 --- /dev/null +++ b/tests/qemuxmlconfdata/riscv64-virt-features-aia.xml @@ -0,0 +1,27 @@ + + guest + 1ccfd97d-5eb4-478a-bbe6-88d254c16db7 + 4194304 + 4194304 + 4 + + hvm + + + + + + + rv64 + + + destroy + restart + destroy + + /usr/bin/qemu-system-riscv64 + + + diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c index 5c95a49116..34d38f2c4b 100644 --- a/tests/qemuxmlconftest.c +++ b/tests/qemuxmlconftest.c @@ -2930,6 +2930,8 @@ mymain(void) DO_TEST_CAPS_ARCH_LATEST("x86_64-default-cpu-tcg-q35-4.2", "x86_64"); DO_TEST_CAPS_ARCH_LATEST("x86_64-default-cpu-tcg-features", "x86_64"); =20 + DO_TEST_CAPS_ARCH_LATEST("riscv64-virt-features-aia", "riscv64"); + DO_TEST_CAPS_LATEST("virtio-9p-multidevs"); DO_TEST_CAPS_LATEST("virtio-9p-createmode"); =20 --=20 2.48.1