From nobody Tue Jan 21 07:24:00 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1736365839452715.610367748418; Wed, 8 Jan 2025 11:50:39 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 8181C14D9; Wed, 8 Jan 2025 14:50:38 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 60FFC14A3; Wed, 8 Jan 2025 14:44:00 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 3079614A6; Wed, 8 Jan 2025 14:43:50 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 2AC7913EE for ; Wed, 8 Jan 2025 14:43:21 -0500 (EST) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-103-aXFCPnjHPKu3ovnoRA_oYw-1; Wed, 08 Jan 2025 14:43:19 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E7CF91956087 for ; Wed, 8 Jan 2025 19:43:18 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.103]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F31A4300018D; Wed, 8 Jan 2025 19:43:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736365400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IhD+6cAloA6UdqtrRjS3ePK+gjjyxAbRitWZ0wI3uGo=; b=fq5zpB6WHaJ1JjNgCqcqQ/Nanb9bjW6hmUl2sNzGD31v9vdhkO1e3Hj2Nb86/UxW+nTMgf QWnD6Ra4X2MqzMQsZEgSn/9GMsr9eZSLB5hNl5A0va1X9Y3+lvWgzqr0JlCRQ6754gKF4U 8/x338PFaX+484frK/ul8+/LATaStc0= X-MC-Unique: aXFCPnjHPKu3ovnoRA_oYw-1 X-Mimecast-MFC-AGG-ID: aXFCPnjHPKu3ovnoRA_oYw From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 14/26] hypervisor: support bypassing cache for managed save Date: Wed, 8 Jan 2025 19:42:47 +0000 Message-ID: <20250108194259.1171990-15-berrange@redhat.com> In-Reply-To: <20250108194259.1171990-1-berrange@redhat.com> References: <20250108194259.1171990-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: sGyxtaGTIM27e6gRP-yaZygu4dPuGFkm7NUWsllKVuM_1736365399 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 6WK5NL2WPO3JDICNZGWZVNZDFFQTQZBW X-Message-ID-Hash: 6WK5NL2WPO3JDICNZGWZVNZDFFQTQZBW X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1736365840886116600 Content-Type: text/plain; charset="utf-8" Bypassing cache can make save performance more predictable and avoids trashing the OS cache with data that will not be read again. Signed-off-by: Daniel P. Berrang=C3=A9 --- src/hypervisor/domain_driver.c | 7 +++++-- src/hypervisor/domain_driver.h | 1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/hypervisor/domain_driver.c b/src/hypervisor/domain_driver.c index 4fecaf7e5c..867ee1ae2a 100644 --- a/src/hypervisor/domain_driver.c +++ b/src/hypervisor/domain_driver.c @@ -725,9 +725,9 @@ virDomainDriverAutoShutdown(virDomainDriverAutoShutdown= Config *cfg) g_autofree bool *transient =3D NULL; =20 VIR_DEBUG("Run autoshutdown uri=3D%s trySave=3D%d tryShutdown=3D%d pow= eroff=3D%d" - "waitShutdownSecs=3D%d", + "waitShutdownSecs=3D%d saveBypassCache=3D%d", cfg->uri, cfg->trySave, cfg->tryShutdown, cfg->poweroff, - cfg->waitShutdownSecs); + cfg->waitShutdownSecs, cfg->saveBypassCache); =20 /* * Ideally guests will shutdown in a few seconds, but it would @@ -784,6 +784,9 @@ virDomainDriverAutoShutdown(virDomainDriverAutoShutdown= Config *cfg) if (state =3D=3D VIR_DOMAIN_PAUSED) flags[i] =3D VIR_DOMAIN_SAVE_PAUSED; } + if (cfg->saveBypassCache) + flags[i] |=3D VIR_DOMAIN_SAVE_BYPASS_CACHE; + virDomainSuspend(domains[i]); } =20 diff --git a/src/hypervisor/domain_driver.h b/src/hypervisor/domain_driver.h index acb7a41b5d..16832f2449 100644 --- a/src/hypervisor/domain_driver.h +++ b/src/hypervisor/domain_driver.h @@ -108,6 +108,7 @@ typedef struct _virDomainDriverAutoShutdownConfig { virDomainDriverAutoShutdownScope tryShutdown; virDomainDriverAutoShutdownScope poweroff; int waitShutdownSecs; + bool saveBypassCache; } virDomainDriverAutoShutdownConfig; =20 void virDomainDriverAutoShutdown(virDomainDriverAutoShutdownConfig *cfg); --=20 2.47.1