From nobody Thu Nov 21 16:52:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 17308119790741002.5828357831507; Tue, 5 Nov 2024 05:06:19 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 0F08711D1; Tue, 5 Nov 2024 08:06:18 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 4488311EE; Tue, 5 Nov 2024 08:05:34 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 96A3D11AA; Tue, 5 Nov 2024 08:05:29 -0500 (EST) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3E4C311AA for ; Tue, 5 Nov 2024 08:05:08 -0500 (EST) Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-431616c23b5so33968105e9.0 for ; Tue, 05 Nov 2024 05:05:08 -0800 (PST) Received: from localhost.localdomain (86.red-88-29-160.dynamicip.rima-tde.net. [88.29.160.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c113e687sm16288378f8f.84.2024.11.05.05.05.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 05 Nov 2024 05:05:06 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730811907; x=1731416707; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iDSm43fdf8jLcDNMuepzzXNnXrf+Cwp4vQFZzGV7m7k=; b=bZaDyfYXpgFg29DRAgpb45+tcir5exOGuMTVBknuCDtqgsQc3xTKy1c9qVDGremIhH 24PpY+RE6iC99L3t9eS5LrPqI2fsF8cTtCz1mZ1IaDXvW7tEcwFBBJJeEXxLnLZCbgKH lExVRNNNiw0bYQC8RzAEqwWxIqv70FrwxegD2tiFXpIdBwF0tKbeOPOqG62X8wCZrbrE NCIGGE1ydQgrkEsEig37nVkJ5Bj4mk5iMsTWgDTr5XA/hLIr3+u6nvovjRUQk9nTilWL u1nHlVeEkoK2je+dmgSy/Dz9z0Iasb3rB/WdzuZGQT2cNRByieGNx8NbcuKt0FIFYksf HPQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730811907; x=1731416707; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iDSm43fdf8jLcDNMuepzzXNnXrf+Cwp4vQFZzGV7m7k=; b=UGTCRQO4dzkTo3G9B3G+MkxUjR7tZ1mm6RoUUY9Vgnkun7OlqgpsvrEUhW9CB8Tfzv cu1gA+i6WxNpQcPmouPEH8zRgxEnjmFIP+ouwv2Xb/zRNepfwVyyiYZLJR3+OdKRVGYc 3kf7nd+sYauQf87ajplf+zBtm3YueRf2ftVaAMXDUZQpGM0FLUoA9jP87H0rC3j16nEP jSALnkLyH5QvDVZBijQcs8g/MDWyMipbStX01AJedsfxMm6T2aqQpZZUoI3iRpEiChcN R49tVpEHjUjmsPN9djB1Q0mgu8QjE8KOGpPEUzwapmirLALComJRsc9i7r3Ou/EO6aQe +qhA== X-Forwarded-Encrypted: i=1; AJvYcCXpI4R+RSU13KzN7T6HmQfNztq6I6JbgVTbiu2l9XtMVn+EhBwdjnyBVGDGGLPLsKXbdSnppw==@lists.libvirt.org X-Gm-Message-State: AOJu0Ywq49wbSHo+Uk7rRDTuP6DGvpjkyfOvhaykNmmxtzMfIzbLvRLa WhOniXUMiXPcql0bSNp7Hsi6XcXJWAtgGOxEmmzovJBmxC0Zlusx0NBloZI+CYs= X-Google-Smtp-Source: AGHT+IEiZ+IDWk575+v438vJMAhRsdBUOU98Ww81Y2HZMPtHqqxfIeUMIqmHOKdx/eypJcQFCkf2Gg== X-Received: by 2002:a05:600c:4ed4:b0:428:b4a:7001 with SMTP id 5b1f17b1804b1-43288c32703mr112566525e9.15.1730811906941; Tue, 05 Nov 2024 05:05:06 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Anton Johansson Subject: [PATCH 03/19] hw/microblaze/s3adsp1800: Explicit CPU endianness Date: Tue, 5 Nov 2024 14:04:15 +0100 Message-ID: <20241105130431.22564-4-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241105130431.22564-1-philmd@linaro.org> References: <20241105130431.22564-1-philmd@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: WN7OEXI6QUOI3EJF4AGM6NDTWRP6DCSK X-Message-ID-Hash: WN7OEXI6QUOI3EJF4AGM6NDTWRP6DCSK X-MailFrom: philmd@linaro.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 CC: "Edgar E. Iglesias" , Peter Maydell , Alistair Francis , Thomas Huth , qemu-arm@nongnu.org, devel@lists.libvirt.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Jason Wang , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1730811979956116600 Content-Type: text/plain; charset="utf-8" By default the machine's CPU endianness is 'big' order ('little-endian' property set to %false). This corresponds to the default when this machine was added; see commits 6a8b1ae2020 "microblaze: Add petalogix s3a1800dsp MMU linux ref-design." and 72b675caacf "microblaze: Hook into the build-system." which added: [ "$target_cpu" =3D "microblaze" ] && target_bigendian=3Dyes Later commit 877fdc12b1a ("microblaze: Allow targeting little-endian mb") added little-endian support, forgetting to set the CPU endianness to little-endian. Not an issue since this property was never used, but we will use it soon, so explicit the endianness to get the expected behavior. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Alistair Francis Reviewed-by: Edgar E. Iglesias Reviewed-by: Richard Henderson --- hw/microblaze/petalogix_s3adsp1800_mmu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/microblaze/petalogix_s3adsp1800_mmu.c b/hw/microblaze/petal= ogix_s3adsp1800_mmu.c index dad46bd7f98..37e9a05a62a 100644 --- a/hw/microblaze/petalogix_s3adsp1800_mmu.c +++ b/hw/microblaze/petalogix_s3adsp1800_mmu.c @@ -71,6 +71,8 @@ petalogix_s3adsp1800_init(MachineState *machine) =20 cpu =3D MICROBLAZE_CPU(object_new(TYPE_MICROBLAZE_CPU)); object_property_set_str(OBJECT(cpu), "version", "7.10.d", &error_abort= ); + object_property_set_bool(OBJECT(cpu), "little-endian", + !TARGET_BIG_ENDIAN, &error_abort); qdev_realize(DEVICE(cpu), NULL, &error_abort); =20 /* Attach emulated BRAM through the LMB. */ --=20 2.45.2