From nobody Thu Nov 21 16:34:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1730811950879684.2860519588352; Tue, 5 Nov 2024 05:05:50 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id BA6421172; Tue, 5 Nov 2024 08:05:49 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 0BFE912E6; Tue, 5 Nov 2024 08:05:11 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 2192D1185; Tue, 5 Nov 2024 08:05:06 -0500 (EST) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9818D11CB for ; Tue, 5 Nov 2024 08:04:58 -0500 (EST) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4315eac969aso33815725e9.1 for ; Tue, 05 Nov 2024 05:04:58 -0800 (PST) Received: from localhost.localdomain (86.red-88-29-160.dynamicip.rima-tde.net. [88.29.160.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c10e725dsm16182932f8f.56.2024.11.05.05.04.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 05 Nov 2024 05:04:56 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730811897; x=1731416697; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LoKTIjDa3J8vyZOU7wutUHSCN+Guhec+PI65dsartdI=; b=b6XLALDBC98dL9fKc0jodxjv3e9HmfRAZ/B4AIxSMd1QwWh+YxIYrgAvkaNsiZXuIh FacC3IueBtISb5jKKTKIlG3wo4nX9O0KWmTBhAijB3eeoOHgo0Lupvw5dWEsmrUoMHXS qyaS2d2zWlN62lbHsKP8ljGPWGjDoBaIpsLInyPRhfRcJ/3agisiWnAKOjmn/3HHWYhD b1xBUMtqZfGQ7vZtn7YdugAQUcDQpQkMlhR3KUavrHMUHshKV6trzN2Ho/U/JuYYYBI3 8ok7hVTf4b+prKcS4pulhbj15NUiWBgGN0JC2zfjS6C636lNybnRlXwncy/UXTg1LZH/ X9eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730811897; x=1731416697; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LoKTIjDa3J8vyZOU7wutUHSCN+Guhec+PI65dsartdI=; b=GLJJnOk7ibxZBSKF54Fk74YQdrweH53cWejXtXLvyebCSzjlKDvH7xOs1Hk5UKmerf DBX9Xp3b5rdMHq7WYA0M9t6/LQTrChzvSnmsZLZC++EfbKViOe6gNN+EZHWjsy4lFlo+ 5SXzid2+fPsR4Sod4ZuMhiX14TCh543wWBqhiLJ0ZkhvizqrF6goc89R9dLVBfUk9LA/ U7+bH8WXEjl9556mGdoVbBS/kqhRnXBFjuYKJGIDWTvNQ+QzG3N4kL3j6zaAWsoi9l6C j18qlRPeRzG4KoVkB/rFzENykISUaDOK0j1Ql0548VRQnAFEjr8DBSkA2dD9YDh91U9m WngQ== X-Forwarded-Encrypted: i=1; AJvYcCVa9w4sZY2Urd2izv502zcZMhZ7+zvcdHuCRvFyGkQ4e450BOAtP+aHsj07NuZBa7o9S9KjqQ==@lists.libvirt.org X-Gm-Message-State: AOJu0YxGuI6jAkqwHAx62pBGdvGQLa1MfKtjqhYYnsT9JXhCquyLs3SN iFSMzN5uX9vltV2OLvByTqxTSr4b9BSt9t+PD/dzykOkm8itg/w4vztf7VVe07c= X-Google-Smtp-Source: AGHT+IHMG75IgJ3W30Wrb+bRlTmmQ3nd9qq/2bzCUnlhNdzY1PB5IZLXC2a/K1d9WiUKPd3QEhHqcw== X-Received: by 2002:a05:600c:460f:b0:426:5e32:4857 with SMTP id 5b1f17b1804b1-4327d840fdemr148920265e9.0.1730811897231; Tue, 05 Nov 2024 05:04:57 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Anton Johansson Subject: [PATCH 02/19] hw/microblaze: Deprecate big-endian petalogix-ml605 & xlnx-zynqmp-pmu Date: Tue, 5 Nov 2024 14:04:14 +0100 Message-ID: <20241105130431.22564-3-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241105130431.22564-1-philmd@linaro.org> References: <20241105130431.22564-1-philmd@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 3YRXZOSXCX4HWLDUPPIWRSYITWDFJF7R X-Message-ID-Hash: 3YRXZOSXCX4HWLDUPPIWRSYITWDFJF7R X-MailFrom: philmd@linaro.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 CC: "Edgar E. Iglesias" , Peter Maydell , Alistair Francis , Thomas Huth , qemu-arm@nongnu.org, devel@lists.libvirt.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Jason Wang , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1730811951863116600 Content-Type: text/plain; charset="utf-8" The petalogix-ml605 machine was explicitly added as little-endian only machine in commit 00914b7d970 ("microblaze: Add PetaLogix ml605 MMU little-endian ref design"). Mark the big-endian version as deprecated. When the xlnx-zynqmp-pmu machine's CPU was added in commit 133d23b3ad1 ("xlnx-zynqmp-pmu: Add the CPU and memory"), its 'endianness' property was set to %true, thus wired in little endianness. Both machine are included in the big-endian system binary, while their CPU is working in little-endian. Unlikely to work as it. Deprecate now as broken config so we can remove soon. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Alistair Francis Reviewed-by: Anton Johansson Reviewed-by: Edgar E. Iglesias --- docs/about/deprecated.rst | 6 ++++++ configs/devices/microblaze-softmmu/default.mak | 2 -- configs/devices/microblazeel-softmmu/default.mak | 5 ++++- hw/microblaze/petalogix_ml605_mmu.c | 7 ++++++- hw/microblaze/xlnx-zynqmp-pmu.c | 8 ++++++-- 5 files changed, 22 insertions(+), 6 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index ff404d44f85..e1c8829e1a4 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -279,6 +279,12 @@ BMC and a witherspoon like OpenPOWER system. It was us= ed for bring up of the AST2600 SoC in labs. It can be easily replaced by the ``rainier-bmc`` machine which is a real product. =20 +Big-Endian variants of MicroBlaze ``petalogix-ml605`` and ``xlnx-zynqmp-pm= u`` machines (since 9.2) +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''= '''''''''''''''''''''''' + +Both ``petalogix-ml605`` and ``xlnx-zynqmp-pmu`` were added for little end= ian +CPUs. Big endian support is not tested. + Backend options --------------- =20 diff --git a/configs/devices/microblaze-softmmu/default.mak b/configs/devic= es/microblaze-softmmu/default.mak index 583e3959bb7..78941064655 100644 --- a/configs/devices/microblaze-softmmu/default.mak +++ b/configs/devices/microblaze-softmmu/default.mak @@ -2,5 +2,3 @@ =20 # Boards are selected by default, uncomment to keep out of the build. # CONFIG_PETALOGIX_S3ADSP1800=3Dn -# CONFIG_PETALOGIX_ML605=3Dn -# CONFIG_XLNX_ZYNQMP_PMU=3Dn diff --git a/configs/devices/microblazeel-softmmu/default.mak b/configs/dev= ices/microblazeel-softmmu/default.mak index 29f7f13816c..4c1086435bf 100644 --- a/configs/devices/microblazeel-softmmu/default.mak +++ b/configs/devices/microblazeel-softmmu/default.mak @@ -1,3 +1,6 @@ # Default configuration for microblazeel-softmmu =20 -include ../microblaze-softmmu/default.mak +# Boards are selected by default, uncomment to keep out of the build. +# CONFIG_PETALOGIX_S3ADSP1800=3Dn +# CONFIG_PETALOGIX_ML605=3Dn +# CONFIG_XLNX_ZYNQMP_PMU=3Dn diff --git a/hw/microblaze/petalogix_ml605_mmu.c b/hw/microblaze/petalogix_= ml605_mmu.c index df808ac323e..61e47d83988 100644 --- a/hw/microblaze/petalogix_ml605_mmu.c +++ b/hw/microblaze/petalogix_ml605_mmu.c @@ -213,7 +213,12 @@ petalogix_ml605_init(MachineState *machine) =20 static void petalogix_ml605_machine_init(MachineClass *mc) { - mc->desc =3D "PetaLogix linux refdesign for xilinx ml605 little endian= "; +#if TARGET_BIG_ENDIAN + mc->desc =3D "PetaLogix linux refdesign for xilinx ml605 (big endian)"; + mc->deprecation_reason =3D "big endian support is not tested"; +#else + mc->desc =3D "PetaLogix linux refdesign for xilinx ml605 (little endia= n)"; +#endif mc->init =3D petalogix_ml605_init; } =20 diff --git a/hw/microblaze/xlnx-zynqmp-pmu.c b/hw/microblaze/xlnx-zynqmp-pm= u.c index 43608c2dca4..567aad47bfc 100644 --- a/hw/microblaze/xlnx-zynqmp-pmu.c +++ b/hw/microblaze/xlnx-zynqmp-pmu.c @@ -181,9 +181,13 @@ static void xlnx_zynqmp_pmu_init(MachineState *machine) =20 static void xlnx_zynqmp_pmu_machine_init(MachineClass *mc) { - mc->desc =3D "Xilinx ZynqMP PMU machine"; +#if TARGET_BIG_ENDIAN + mc->desc =3D "Xilinx ZynqMP PMU machine (big endian)"; + mc->deprecation_reason =3D "big endian support is not tested"; +#else + mc->desc =3D "Xilinx ZynqMP PMU machine (little endian)"; +#endif mc->init =3D xlnx_zynqmp_pmu_init; } =20 DEFINE_MACHINE("xlnx-zynqmp-pmu", xlnx_zynqmp_pmu_machine_init) - --=20 2.45.2