From nobody Sat Feb 7 12:45:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1728992106624195.56591482368253; Tue, 15 Oct 2024 04:35:06 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 97566E75; Tue, 15 Oct 2024 07:35:05 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id E8A961873; Tue, 15 Oct 2024 07:23:07 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9C051186E; Tue, 15 Oct 2024 07:23:04 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 44AE3180C for ; Tue, 15 Oct 2024 07:19:42 -0400 (EDT) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-4pwIxfU2MquejcNkTHmvVw-1; Tue, 15 Oct 2024 07:19:35 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0B5F519560AD for ; Tue, 15 Oct 2024 11:19:35 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.118]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 20B823000198; Tue, 15 Oct 2024 11:19:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: *** X-Spam-Status: No, score=3.0 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728991182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UGzMAcIp2hCxWqaO+NM+j124nIugRmnP4fqIK0FGoUc=; b=aBCcFTVd26imPVvz9x1YtmzxXRtc11ULC7HcaP+OQ0UutGmDFzK55uNlnXylRKB6wzFRi2 OXO7/Y3AMtkYVTjIb9nrbtiNJACWWQDiLP1AKiE3+DcdHteMZOUL6/KbvXLWIUA/OH3euG 3StqMPgqPidfE1mbqOcrgv1etmZh7hM= X-MC-Unique: 4pwIxfU2MquejcNkTHmvVw-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 4/5] wireshark: drop gmodule.h include to avoid glib warnings Date: Tue, 15 Oct 2024 12:19:23 +0100 Message-ID: <20241015111924.212483-5-berrange@redhat.com> In-Reply-To: <20241015111924.212483-1-berrange@redhat.com> References: <20241015111924.212483-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: NPLHJQSPCHP4STWWOMCD35R7PNBCGRUV X-Message-ID-Hash: NPLHJQSPCHP4STWWOMCD35R7PNBCGRUV X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1728992107433116600 Content-Type: text/plain; charset="utf-8" The wireshark address.h header uses 'g_memdup2' but this triggers warnings under clang due to the max version cap: In file included from ../tools/wireshark/src/plugin.c:27: In file included from /usr/include/wireshark/epan/proto.h:30: In file included from /usr/include/wireshark/epan/packet_info.h:15: /usr/include/wireshark/epan/address.h:107:18: error: 'g_memdup2' is dep= recated: Not available before 2.68 [-Werror,-Wdeprecated-declarations] 107 | addr->priv =3D g_memdup2(&val, sizeof(val)); | ^ /usr/include/glib-2.0/glib/gstrfuncs.h:341:1: note: 'g_memdup2' has bee= n explicitly marked deprecated here 341 | GLIB_AVAILABLE_IN_2_68 | ^ /usr/include/glib-2.0/glib/glib-visibility.h:771:32: note: expanded fro= m macro 'GLIB_AVAILABLE_IN_2_68' 771 | #define GLIB_AVAILABLE_IN_2_68 GLIB_UNAVAILABLE (2, 68) | ^ /usr/include/glib-2.0/glib/glib-visibility.h:32:35: note: expanded from= macro 'GLIB_UNAVAILABLE' 32 | #define GLIB_UNAVAILABLE(maj,min) G_UNAVAILABLE(maj,min) _GLIB_= EXTERN | ^ /usr/include/glib-2.0/glib/gmacros.h:1285:47: note: expanded from macro= 'G_UNAVAILABLE' 1285 | #define G_UNAVAILABLE(maj,min) __attribute__((deprecated("Not a= vailable before " #maj "." #min))) | ^ 1 error generated. It is unclear why clang warns, but gcc does not. Our plugin doesn't actually use the inline helper in address.h that references g_memdup2, but we get the warning regardless. Interestingly removing the 'gmodule.h' include avoids the warning. Since there is nothing in plugin.c that appears to need gmodule.h, removing it should be safe & done regardless. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- tools/wireshark/src/plugin.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/wireshark/src/plugin.c b/tools/wireshark/src/plugin.c index 13af1b6a73..9a83f2ca07 100644 --- a/tools/wireshark/src/plugin.c +++ b/tools/wireshark/src/plugin.c @@ -12,8 +12,6 @@ =20 #include =20 -#include - #ifdef WITH_WS_VERSION # include #else --=20 2.46.0