From nobody Sat Feb 7 17:49:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1728991590563736.9623906113806; Tue, 15 Oct 2024 04:26:30 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9820A13A8; Tue, 15 Oct 2024 07:26:29 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 7372D17F9; Tue, 15 Oct 2024 07:19:35 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 49687136C; Tue, 15 Oct 2024 07:19:32 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id CFD8C1371 for ; Tue, 15 Oct 2024 07:19:31 -0400 (EDT) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-497-O8ETNLUfPkaRIcdYs46MLg-1; Tue, 15 Oct 2024 07:19:30 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B03F719560BC for ; Tue, 15 Oct 2024 11:19:29 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.118]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8135B3000198; Tue, 15 Oct 2024 11:19:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: *** X-Spam-Status: No, score=3.0 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728991171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SnaqKqk2BeC3yJ9l5eYXWlu904ljPK/7YhXGxUhO19M=; b=XRDWrKC/eLUjIAkSrUBw5ebd3snmY+/pvzdmZ7/ww7C1QzIuQ8eCZqzqUBv8JntyrzJHCq w5xaQSXEqEnM6t+LdPzmpJ+Kg4U/1NE35t1sAFT2n+VsG9/e9oqLmdgvT7JV9eS7X5cg8v GfHDCBziMY/BDdswWwzXRILQiJiE1LY= X-MC-Unique: O8ETNLUfPkaRIcdYs46MLg-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 1/5] meson: unconditionally enable polkit on non-Windows Date: Tue, 15 Oct 2024 12:19:20 +0100 Message-ID: <20241015111924.212483-2-berrange@redhat.com> In-Reply-To: <20241015111924.212483-1-berrange@redhat.com> References: <20241015111924.212483-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BZC2QLFEUHI3GK6ZAEIUITTOC35XYYYZ X-Message-ID-Hash: BZC2QLFEUHI3GK6ZAEIUITTOC35XYYYZ X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1728991591557116600 Content-Type: text/plain; charset="utf-8" The polkit code does not have a build time dependancy on any system headers or libraries. It can be safely enabled on any non-Windows platform. Signed-off-by: Daniel P. Berrang=C3=A9 --- meson.build | 5 ----- 1 file changed, 5 deletions(-) diff --git a/meson.build b/meson.build index 5eb3f24181..2ce8fac4a1 100644 --- a/meson.build +++ b/meson.build @@ -1433,11 +1433,6 @@ endif if not get_option('polkit').disabled() polkit_enable =3D true =20 - if get_option('polkit').auto() - pkcheck_prog =3D find_program('pkcheck', required: false, dirs: libvir= t_sbin_path) - polkit_enable =3D pkcheck_prog.found() - endif - if host_machine.system() =3D=3D 'windows' polkit_enable =3D false if get_option('polkit').enabled() --=20 2.46.0