From nobody Sat Feb 7 12:20:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1728670448441980.1925568322955; Fri, 11 Oct 2024 11:14:08 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 45EF417D6; Fri, 11 Oct 2024 14:14:07 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 441C1179C; Fri, 11 Oct 2024 14:13:21 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 6D4A013A8; Fri, 11 Oct 2024 14:13:16 -0400 (EDT) Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B312F148E for ; Fri, 11 Oct 2024 14:13:15 -0400 (EDT) Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-287b8444ff3so963875fac.1 for ; Fri, 11 Oct 2024 11:13:15 -0700 (PDT) Received: from home.. ([2603:8081:c640:1::1003]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2885844a8b7sm1047097fac.58.2024.10.11.11.13.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 11:13:13 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728670394; x=1729275194; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NlLopCpjk2vdsEKGOx0kNYZMZne0cxOpaDSsCLU5G30=; b=jldmlukLlIkuTDscBouOH3HZS904dEXPLEFLBHFNnbKJOM0sk/Cdty01fFEmfWIFb+ BEMfYhJtTx82lFayzKxnVvvGg8JV+c1XzgIyBUVR/qI9a+BCzy7mS6Ts2e7vpZ8OIJNn ztAxOeHoYulZ/vkRywVHh4RQkiHV45efK5lZ9umnh9yrYx5D0TVXa18LkjRgOVswuYig ph5v/blAx7SMjWWW5SR92p6zCdzAnPTJKapQDMToX9+gDnawMjjseeAwYghE2Vq6fk0l KN99olKrH5nkqc/pdsX4yuVKPr/yQPpfZtvUZl2ohoOnWtyWvEJMbqKId8Xo3tMYI2jT p/vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728670394; x=1729275194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NlLopCpjk2vdsEKGOx0kNYZMZne0cxOpaDSsCLU5G30=; b=BfBy5RmQ4nUANpEFVLEdlsn2WhqLtUgLC5LbPeR1sWan/OcT32N182Womyk+EXSAyU BmouGAfiqf8gD8opVi/+/7MLuuuEvysqbsf/zxz0qqe9Fh9241rI8lTQE8tWWZ8fZFtF jNxQt9ZogLj/+FjCU9+8T7OACkMrfB2wTxx3qSRhu2+9fUIw5LdyuaeD+krft5H8lV/S zp/As8mas0IdgKh3Jd1M0nTWvCLqdWTDCty+ZwMibeu/aI6p6OIRwnGn8JkHcRm2ZH2I /J5aAZ4AZKFUDr6ejbYkkOJe48zlHFueLRNzNgDD9IyJhUy+syhtpfkVqde7MnPKMXTy qmeA== X-Gm-Message-State: AOJu0YyFKL6AIO7UOFwOl0sGmDiIcRj3jN7Q18o6jqTVJvAlON4aweHw MdPh7H/nGTovTrgeX7g21pkq0ltL0VoDUdv7JQG+2xuQfp+s6GHjVuweQw== X-Google-Smtp-Source: AGHT+IF1ZHinfES4dN8mBDhWzzTPwm5v9xj8jcJhZvjAOjtlpF/M1uUw4ODKe+pp9CZNt3/Osrw/mQ== X-Received: by 2002:a05:6870:798:b0:287:ce7:7c4a with SMTP id 586e51a60fabf-2886e00f920mr3252083fac.38.1728670394577; Fri, 11 Oct 2024 11:13:14 -0700 (PDT) From: Praveen K Paladugu X-Google-Original-From: Praveen K Paladugu To: devel@lists.libvirt.org Subject: [PATCH 01/10] hypervisor: move HostdevNeedsVFIO to hypervisor Date: Fri, 11 Oct 2024 13:13:02 -0500 Message-ID: <20241011181311.6813-2-prapal@linux.microsoft.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20241011181311.6813-1-prapal@linux.microsoft.com> References: <20241011181311.6813-1-prapal@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: SWWRWG6WAMPQIDQSZCCOT4LDAEVYLGOY X-Message-ID-Hash: SWWRWG6WAMPQIDQSZCCOT4LDAEVYLGOY X-MailFrom: praveenkpaladugu@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: liuwe@microsoft.com X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1728670449666116600 Content-Type: text/plain; charset="utf-8" Move HostdevNeedsVFIO method to hypervisor to be reused between qemu and ch drivers. Signed-off-by: Praveen K Paladugu --- src/hypervisor/virhostdev.c | 7 +++++++ src/hypervisor/virhostdev.h | 3 +++ src/libvirt_private.syms | 1 + src/qemu/qemu_cgroup.c | 5 +++-- src/qemu/qemu_hostdev.c | 8 -------- src/qemu/qemu_hostdev.h | 2 -- src/qemu/qemu_namespace.c | 2 +- 7 files changed, 15 insertions(+), 13 deletions(-) diff --git a/src/hypervisor/virhostdev.c b/src/hypervisor/virhostdev.c index 185ec2ca50..4b06e74894 100644 --- a/src/hypervisor/virhostdev.c +++ b/src/hypervisor/virhostdev.c @@ -2512,3 +2512,10 @@ virHostdevUpdateActiveNVMeDevices(virHostdevManager = *hostdev_mgr, } goto cleanup; } + +bool +virHostdevNeedsVFIO(const virDomainHostdevDef *hostdev) +{ + return virHostdevIsPCIDevice(hostdev) || + virHostdevIsMdevDevice(hostdev); +} diff --git a/src/hypervisor/virhostdev.h b/src/hypervisor/virhostdev.h index 22ec3068db..b9e6108816 100644 --- a/src/hypervisor/virhostdev.h +++ b/src/hypervisor/virhostdev.h @@ -232,3 +232,6 @@ virHostdevUpdateActiveNVMeDevices(virHostdevManager *ho= stdev_mgr, const char *dom_name, virDomainDiskDef **disks, size_t ndisks); + +bool +virHostdevNeedsVFIO(const virDomainHostdevDef *hostdev); diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index e09fb98596..cca071f866 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1670,6 +1670,7 @@ virCloseCallbacksDomainRunForConn; # hypervisor/virhostdev.h virHostdevFindUSBDevice; virHostdevManagerGetDefault; +virHostdevNeedsVFIO; virHostdevPCINodeDeviceDetach; virHostdevPCINodeDeviceReAttach; virHostdevPCINodeDeviceReset; diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 23b7e6b4e8..be4b9a38ff 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -32,6 +32,7 @@ #include "virfile.h" #include "virdevmapper.h" #include "virglibutil.h" +#include "virhostdev.h" =20 #define VIR_FROM_THIS VIR_FROM_QEMU =20 @@ -481,7 +482,7 @@ qemuSetupHostdevCgroup(virDomainObj *vm, return -1; } =20 - if (qemuHostdevNeedsVFIO(dev) && + if (virHostdevNeedsVFIO(dev) && qemuCgroupAllowDevicePath(vm, QEMU_DEV_VFIO, VIR_CGROUP_DEVICE_RW, false) < 0) { return -1; @@ -530,7 +531,7 @@ qemuTeardownHostdevCgroup(virDomainObj *vm, return -1; } =20 - if (qemuHostdevNeedsVFIO(dev) && + if (virHostdevNeedsVFIO(dev) && !qemuDomainNeedsVFIO(vm->def) && qemuCgroupDenyDevicePath(vm, QEMU_DEV_VFIO, VIR_CGROUP_DEVICE_RWM, false) < 0) { diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 15b543dbff..f25ccaf1a4 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -130,14 +130,6 @@ qemuHostdevUpdateActiveDomainDevices(virQEMUDriver *dr= iver, } =20 =20 -bool -qemuHostdevNeedsVFIO(const virDomainHostdevDef *hostdev) -{ - return virHostdevIsPCIDevice(hostdev) || - virHostdevIsMdevDevice(hostdev); -} - - bool qemuHostdevHostSupportsPassthroughVFIO(void) { diff --git a/src/qemu/qemu_hostdev.h b/src/qemu/qemu_hostdev.h index 3e9adc57a9..bbf7bb11e7 100644 --- a/src/qemu/qemu_hostdev.h +++ b/src/qemu/qemu_hostdev.h @@ -23,8 +23,6 @@ =20 #include "qemu_conf.h" =20 -bool qemuHostdevNeedsVFIO(const virDomainHostdevDef *hostdev); - bool qemuHostdevHostSupportsPassthroughVFIO(void); =20 int qemuHostdevUpdateActiveNVMeDisks(virQEMUDriver *driver, diff --git a/src/qemu/qemu_namespace.c b/src/qemu/qemu_namespace.c index bbe3d5a1f7..5c92b5547e 100644 --- a/src/qemu/qemu_namespace.c +++ b/src/qemu/qemu_namespace.c @@ -339,7 +339,7 @@ qemuDomainSetupHostdev(virDomainObj *vm, if (path) *paths =3D g_slist_prepend(*paths, g_steal_pointer(&path)); =20 - if (qemuHostdevNeedsVFIO(hostdev) && + if (virHostdevNeedsVFIO(hostdev) && (!hotplug || !qemuDomainNeedsVFIO(vm->def))) *paths =3D g_slist_prepend(*paths, g_strdup(QEMU_DEV_VFIO)); =20 --=20 2.44.0