From nobody Fri Dec 19 15:59:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1728424168; cv=none; d=zohomail.com; s=zohoarc; b=mgcOMSrQHNEz5eOTJmbw7ULbDC93PmnqrIDEXqPgPuIC3T0tCyB5vyt15S+BtNB8+fll3gs1+PLYMO2TGrtC/xfp1LnQNemZWbCvTK1JeztqtUctC/v1qWt/lxCEhuzFdI9HAeAl/FHkjESb7Q6CX/J8SvGwZ9sj6EzT7R67Tak= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728424168; h=Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=Ns0NbaJodyEJy3XyylpSre4i+IYkSLb57vc4XIa+Rgo=; b=GGQuxPZm0Dt8J+516saDFaAM0XMmaUrTih7mriQo972EVtihT/UYh7pLbx83oQXFVmddVdnqG1KitJ7MnDe7KqOcU0MqsQQrqCWC8D0WN4Ndw/cxunB1JCMRyQlW2cr6rZqSBOkqkHtRlmcct0AHCBHbNo+2KZhDjWJFbdRHQgQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1728424168776122.1336335369449; Tue, 8 Oct 2024 14:49:28 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 8865A15F8; Tue, 8 Oct 2024 17:49:27 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id AABEE15B8; Tue, 8 Oct 2024 17:49:09 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 4CB9D1576; Tue, 8 Oct 2024 17:49:06 -0400 (EDT) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3B21F1560 for ; Tue, 8 Oct 2024 17:49:05 -0400 (EDT) Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-42f56ad2afaso82428265e9.1 for ; Tue, 08 Oct 2024 14:49:05 -0700 (PDT) Received: from localhost ([192.150.159.191]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-83503b3087csm188985939f.54.2024.10.08.14.49.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 14:49:02 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1728424144; x=1729028944; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=/mOeJt+imIQfWsFOZaAEU7EXglfbHyBsBf942Eu8AtE=; b=UuaLolmVudVif57xggZTGZDJkNPhnazPvoNxg4fJsFauwxJeDtYHsYfXpxvu9/Al9n 8K2G9WZzhF7DQ1kaokSTLJJU7ImlwrCC9leVAG8UMKjxUKJ+T9aqPUNYxdtfKS5LeFuL DYUVDzDzaOh0HPOttxCsbq/6qU8KIizLjFQplNwNVlmKJbvl1ZzdgqTIif7SLSCYqVY/ 4TkoIy1xm7yB2x0TsoOdkDkwuRETTZiAVn21ILHIO8Q1vEWgAVftKpZh8ynbaktFb4A+ nYE/opQDOoKoTd15qJ6laGw+tOwkRmLQ5/alXEnaQ9iXmM3BZ8+JmmwmwxbHZcWeP+Ps jEJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728424144; x=1729028944; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/mOeJt+imIQfWsFOZaAEU7EXglfbHyBsBf942Eu8AtE=; b=JhA5HleLK+eQHZl33Xb6J7XVUgumQd9xoNnMgvg8GA4MfxBwgfvqiXcSe6J4iMuaHU k/YqNp0GbOoNKBrzeF9IFcH3ZXAwyCkCda7nldLNEEoor6XhVCBwfdx1kwV9ES5xmfGG TUFVPZtL9kgQyDO2eh1531w2X8a0nB4XqcHZ9j8UmkwQO0/EoTtnBNClzeWu/S3ULI2x TCkJiRoDv5TVAAtLqetuF8B6wUxQuOV/2aL1v5LL08oCflJTd2cbyOE8Je8E02PGv9OJ z2MQug9vSEV2ExvsbSXfdBE1WYUqjsc6cOR+2aUtEM/lYX4q8Cxm3pwS26+pZYlquzBx dXtg== X-Gm-Message-State: AOJu0YwKZdIi3aJzDXb9B/vhasj5M0S8PNRx8Q75LF2E8wlwehmej2uN BvWbZCVAFm1ArmUJnXaWen6IRD5BcjePFg+NUYiL4N2D4SmAzqe2kd4DLCgMzON8ji5bLeM7GaA J1g1JPQ== X-Google-Smtp-Source: AGHT+IHyufOV7u5V5fUoWt/Lr/sXWyezGoZpxKiM+BIDJGl6T5Ow1XAALtGSPoc2IQ3QlkOepI3aYA== X-Received: by 2002:a05:600c:3551:b0:430:570b:4554 with SMTP id 5b1f17b1804b1-430ccf04213mr1523125e9.3.1728424143919; Tue, 08 Oct 2024 14:49:03 -0700 (PDT) To: devel@lists.libvirt.org Subject: [PATCH V3] libxl: Reject VM config referencing nwfilters Date: Tue, 8 Oct 2024 15:49:00 -0600 Message-Id: <20241008214900.30187-1-jfehlig@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: GIJDXE3454HSRV3CXY35APPALN2HPTRH X-Message-ID-Hash: GIJDXE3454HSRV3CXY35APPALN2HPTRH X-MailFrom: jfehlig@suse.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Jim Fehlig via Devel Reply-To: Jim Fehlig X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1728424171078116600 Content-Type: text/plain; charset="utf-8" The Xen libxl driver does not support nwfilter. Introduce a deviceValidateCallback function with a check for nwfilters, returning VIR_ERR_CONFIG_UNSUPPORTED if any are found. Also fail to start any existing VMs referencing nwfilters. Drivers generally ignore unrecognized XML configuration, but ignoring a user's request to filter VM network traffic can be viewed as a security issue. Signed-off-by: Jim Fehlig Reviewed-by: Martin Kletzander --- V2: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/UHG= 4TMYRRHTHQSYAVDOB46KHZ6QPIT4O/ Changes in V3: When starting a VM, use virDomainDefValidate to validate the def instead of duplicating the checks. Note: With the change in V3, the validation is only done when starting a new VM. Validation is skipped if restoring a managed saved VM. src/libxl/libxl_domain.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 0f129ec69c..029b12fa3b 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -356,12 +356,30 @@ libxlDomainDefValidate(const virDomainDef *def, return 0; } =20 +static int +libxlDomainDeviceDefValidate(const virDomainDeviceDef *dev, + const virDomainDef *def, + void *opaque G_GNUC_UNUSED, + void *parseOpaque G_GNUC_UNUSED) +{ + if (dev->type =3D=3D VIR_DOMAIN_DEVICE_NET && dev->data.net->filter) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("filterref is not supported in %1$s"), + virDomainVirtTypeToString(def->virtType)); + return -1; + } + + return 0; +} + + virDomainDefParserConfig libxlDomainDefParserConfig =3D { .macPrefix =3D { 0x00, 0x16, 0x3e }, .netPrefix =3D LIBXL_GENERATED_PREFIX_XEN, .devicesPostParseCallback =3D libxlDomainDeviceDefPostParse, .domainPostParseCallback =3D libxlDomainDefPostParse, .domainValidateCallback =3D libxlDomainDefValidate, + .deviceValidateCallback =3D libxlDomainDeviceDefValidate, =20 .features =3D VIR_DOMAIN_DEF_FEATURE_USER_ALIAS | VIR_DOMAIN_DEF_FEATURE_FW_AUTOSELECT | @@ -1460,6 +1478,10 @@ libxlDomainStartNew(libxlDriverPrivate *driver, managed_save_path); =20 vm->hasManagedSave =3D false; + } else { + /* Validate configuration if starting a new VM */ + if (virDomainDefValidate(vm->def, 0, driver->xmlopt, NULL) < 0) + goto cleanup; } =20 ret =3D libxlDomainStart(driver, vm, start_paused, restore_fd, restore= _ver); --=20 2.35.3