[PATCH] NEWS: add blurbs about a couple of bugs I fixed this month

Laine Stump posted 1 patch 6 days, 2 hours ago
NEWS.rst | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
[PATCH] NEWS: add blurbs about a couple of bugs I fixed this month
Posted by Laine Stump 6 days, 2 hours ago
Signed-off-by: Laine Stump <laine@redhat.com>
---

 NEWS.rst | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/NEWS.rst b/NEWS.rst
index beea8221e1..617af915b3 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -19,6 +19,19 @@ v10.8.0 (unreleased)
 
 * **Improvements**
 
+  * network: make networks with <forward mode='open'/> more useful
+
+    It is now permissable to have a <forward mode='open'> network that
+    has no IP address assigned to the host's port of the bridge. This
+    is the only way to create a libvirt network where guests are
+    unreachable from the host (and vice versa) and also 0 firewall
+    rules are added on the host.
+
+    It is now also possible for a <forward mode='open'/> network to
+    use the "zone" attribute of <bridge> to set the firewalld zone of
+    the bridge interface (normally it would not be set, as is done
+    with other forward modes).
+
 * **Bug fixes**
 
   * virsh: Fix script-friedly output of ``virsh list --uuid``
@@ -32,6 +45,18 @@ v10.8.0 (unreleased)
     Note that this also broke the ``libvirt-guests`` script. The bug was
     introduced in `v10.7.0 (2024-09-02)`_.
 
+  * network/qemu: fix some cases where device-update of a network
+    interface was failing:
+
+    * If the interface was connected to a libvirt network that was
+      providing a pool of VFs to be used with macvtap passthrough
+      mode, then *any* update to the interface would fail, even
+      changing the link state. Updating (the updateable parts of) a
+      macvtap passthrough interface will now succeed.
+
+    * It previously was not possible to move an interface from a Linux
+      host bridge to an OVS bridge. This (and the opposite direction)
+      now works.
 
 v10.7.0 (2024-09-02)
 ====================
-- 
2.46.1
Re: [PATCH] NEWS: add blurbs about a couple of bugs I fixed this month
Posted by Peter Krempa 5 days, 15 hours ago
On Sun, Sep 29, 2024 at 16:04:12 -0400, Laine Stump wrote:
> Signed-off-by: Laine Stump <laine@redhat.com>
> ---
> 
>  NEWS.rst | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/NEWS.rst b/NEWS.rst
> index beea8221e1..617af915b3 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -19,6 +19,19 @@ v10.8.0 (unreleased)
>  
>  * **Improvements**
>  
> +  * network: make networks with <forward mode='open'/> more useful

Please put the XML element in double-backticks  ``<asdf>`` to make them
monospace/code in the output in the few instances below.

> +
> +    It is now permissable to have a <forward mode='open'> network that
> +    has no IP address assigned to the host's port of the bridge. This
> +    is the only way to create a libvirt network where guests are
> +    unreachable from the host (and vice versa) and also 0 firewall
> +    rules are added on the host.
> +
> +    It is now also possible for a <forward mode='open'/> network to
> +    use the "zone" attribute of <bridge> to set the firewalld zone of
> +    the bridge interface (normally it would not be set, as is done
> +    with other forward modes).
Re: [PATCH] NEWS: add blurbs about a couple of bugs I fixed this month
Posted by Peter Krempa 5 days, 10 hours ago
On Mon, Sep 30, 2024 at 09:05:33 +0200, Peter Krempa wrote:
> On Sun, Sep 29, 2024 at 16:04:12 -0400, Laine Stump wrote:
> > Signed-off-by: Laine Stump <laine@redhat.com>
> > ---
> > 
> >  NEWS.rst | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> > 
> > diff --git a/NEWS.rst b/NEWS.rst
> > index beea8221e1..617af915b3 100644
> > --- a/NEWS.rst
> > +++ b/NEWS.rst
> > @@ -19,6 +19,19 @@ v10.8.0 (unreleased)
> >  
> >  * **Improvements**
> >  
> > +  * network: make networks with <forward mode='open'/> more useful
> 
> Please put the XML element in double-backticks  ``<asdf>`` to make them
> monospace/code in the output in the few instances below.

FYI I've done these changes and pushed your patch as others are waiting
to get news in.
Re: [PATCH] NEWS: add blurbs about a couple of bugs I fixed this month
Posted by Laine Stump 5 days, 7 hours ago
On 9/30/24 8:22 AM, Peter Krempa wrote:
> On Mon, Sep 30, 2024 at 09:05:33 +0200, Peter Krempa wrote:
>> On Sun, Sep 29, 2024 at 16:04:12 -0400, Laine Stump wrote:
>>> Signed-off-by: Laine Stump <laine@redhat.com>
>>> ---
>>>
>>>   NEWS.rst | 25 +++++++++++++++++++++++++
>>>   1 file changed, 25 insertions(+)
>>>
>>> diff --git a/NEWS.rst b/NEWS.rst
>>> index beea8221e1..617af915b3 100644
>>> --- a/NEWS.rst
>>> +++ b/NEWS.rst
>>> @@ -19,6 +19,19 @@ v10.8.0 (unreleased)
>>>   
>>>   * **Improvements**
>>>   
>>> +  * network: make networks with <forward mode='open'/> more useful
>>
>> Please put the XML element in double-backticks  ``<asdf>`` to make them
>> monospace/code in the output in the few instances below.
> 
> FYI I've done these changes and pushed your patch as others are waiting
> to get news in.


Thanks! I remember thinking "don't I have to do something extra for < 
and >?" as I was writing it, but then had forgotten within a few seconds :-/
Re: [PATCH] NEWS: add blurbs about a couple of bugs I fixed this month
Posted by Peter Krempa 5 days, 15 hours ago
On Sun, Sep 29, 2024 at 16:04:12 -0400, Laine Stump wrote:
> Signed-off-by: Laine Stump <laine@redhat.com>
> ---
> 
>  NEWS.rst | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>