From nobody Sun Dec 22 06:07:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1727443302598835.8951602936704; Fri, 27 Sep 2024 06:21:42 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 703B912CC; Fri, 27 Sep 2024 09:21:41 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 147ED131A; Fri, 27 Sep 2024 09:21:27 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 01D5E12D1; Fri, 27 Sep 2024 09:21:24 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 5F61612D6 for ; Fri, 27 Sep 2024 09:21:23 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-360-xvjPF1zOPJ-88ojFI2KhDA-1; Fri, 27 Sep 2024 09:21:21 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 038991896E3E for ; Fri, 27 Sep 2024 13:21:21 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.45.224.221]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 39B4E1954B10 for ; Fri, 27 Sep 2024 13:21:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727443283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DeDwQcnRt94zsikqSFhofGukaD9FZBO0R2A9+bbW2rU=; b=I9rr/B5haGGF5WdLCT0OONKvYw9FOSh5wulRb9kmIbawKXlXtm+Ry4OpQN7/wF9rGWiwWb pbRfIgLazc8o86pqDhoUdRq8trQJbRvGGncWDKTiBbcJGP5QbYyYD9x8i4up3TZtLqrtnw VRerA5RxsmTVXJ46IU+SrnCCxZosR6o= X-MC-Unique: xvjPF1zOPJ-88ojFI2KhDA-1 From: Andrea Bolognani To: devel@lists.libvirt.org Subject: [PATCH] qemu: Look for qemu-bridge-helper in more directories Date: Fri, 27 Sep 2024 15:21:17 +0200 Message-ID: <20240927132117.88226-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: VKVWZMN7GEVX67DYXSVSKRWSTSFMRKBQ X-Message-ID-Hash: VKVWZMN7GEVX67DYXSVSKRWSTSFMRKBQ X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1727443304896116600 Content-Type: text/plain; charset="utf-8"; x-default="true" Commit 0caacf47d7b423db9126660fb0382ed56cd077c1 recently made it so the new path used for qemu-bridge-helper in Debian would be allowed, but the logic used to actually figure out the complete path for the helper was not updated accordingly. https://bugs.debian.org/1082530 Signed-off-by: Andrea Bolognani Reviewed-by: Martin Kletzander --- src/hypervisor/domain_interface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/hypervisor/domain_interface.c b/src/hypervisor/domain_inte= rface.c index 5cdba279fa..5bc698d272 100644 --- a/src/hypervisor/domain_interface.c +++ b/src/hypervisor/domain_interface.c @@ -541,6 +541,7 @@ virDomainCreateInBridgePortWithHelper(const char *bridg= eHelperName, unsigned int flags) { const char *const bridgeHelperDirs[] =3D { + "/usr/libexec/qemu", "/usr/libexec", "/usr/lib/qemu", "/usr/lib", --=20 2.46.1