From nobody Sat Dec 21 14:57:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=fail (BodyHash is different from the expected one); dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1726673760489271.8010588254915; Wed, 18 Sep 2024 08:36:00 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A5ABB131B; Wed, 18 Sep 2024 11:35:58 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 68B1B134F; Wed, 18 Sep 2024 11:35:39 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 46B961524; Wed, 18 Sep 2024 07:04:16 -0400 (EDT) Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11021094.outbound.protection.outlook.com [52.101.70.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 97EF5153C for ; Wed, 18 Sep 2024 07:04:15 -0400 (EDT) Received: from DU0PR03MB9635.eurprd03.prod.outlook.com (2603:10a6:10:42d::16) by VI2PR03MB10763.eurprd03.prod.outlook.com (2603:10a6:800:276::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.16; Wed, 18 Sep 2024 11:04:10 +0000 Received: from DU0PR03MB9635.eurprd03.prod.outlook.com ([fe80::867f:29ba:5bb:56c6]) by DU0PR03MB9635.eurprd03.prod.outlook.com ([fe80::867f:29ba:5bb:56c6%4]) with mapi id 15.20.7962.022; Wed, 18 Sep 2024 11:04:10 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, FORGED_SPF_HELO,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WYkA/DHkTEwvy6YpNqUxLiFw6p0ugs17xX9qslQLwN9DEvpulev/p8H8bUYUOiTaMBNWG6MNmf6FOXuBplmZpX9E49T5PIM0+oODMo4CsHs68158sK0QjaYyaxGwGEjl4mydLNAZlJytV9I0iqIMMZ7GCVhSLJkQ4kYSP43Map0/ErclMAVb0yFdl7cfsFa72iyzRNX8GjBdwkD93FOZP6xrFAiQqB87/JVGraUcDlWGs6vXisItINOPdBh3afjlC4tb1VwkdMNyMOR20bq30vRc9+8tKBFAzkt3ALGnRAgQKryjv6ESx02jVm+NUE9i46pgBk3reKVzD9f1X6Ex+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TgrLe4W0MUcuBYOIdlOUSgot0ry57k8I0F2se54UcHA=; b=eXSFw4JcNVktuhxbrDDNdL1vFuHuQ21Hiv989eChgRbyjgoyt/jzD+iIt80/s7GPF49yC4Qvx64ho+Ol8WvCUFy8omVsTxLrzxcLWLDJTvnenVAlcL2RMkr7uqaBu1OTsRcN2TWDDLK879vdA6umkcDPQON1oCwpphtoyG/nsMt1EJlxRHjtEzle8nGZP6enVTkipGzATs8FPTIvYZnK4MjBJR8TM9HFrIZyhhuPf6h9otPqBGUIcC0pWUpTisXoW7RDpsJIcHf+XcasI/SDaYqu9aRTkdI2XEYebzP1FRVdpg1IE6VaoM/OSpZrO3bw0P+D0fMX3D/7f/AvzsV3pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=identity.pt; dmarc=pass action=none header.from=identity.pt; dkim=pass header.d=identity.pt; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=identity.pt; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TgrLe4W0MUcuBYOIdlOUSgot0ry57k8I0F2se54UcHA=; b=opyupEB2k/NTfKEhK+QU4GfeVZ2wJNvsBUdBjJhe2sGNcug9XUazfXLbdUwwXQdSX6GAuJ3MwxoOzvSPorxEOC5dscetrV2eiUoWNXOyNVlsoSHNynZq9pFx31wJgmHs6EQgIYLRHWjDuYGOJDvoqJ2QNDhhIj0SegtO1VIAF5Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=identity.pt; To: devel@lists.libvirt.org Subject: [PATCH] vmx: support HPET timers configuration Date: Wed, 18 Sep 2024 12:03:57 +0100 Message-Id: <20240918110357.3036-1-joao.ribeiro@identity.pt> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: PR1P264CA0072.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2cc::14) To DU0PR03MB9635.eurprd03.prod.outlook.com (2603:10a6:10:42d::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR03MB9635:EE_|VI2PR03MB10763:EE_ X-MS-Office365-Filtering-Correlation-Id: f66dbf64-bbc2-4b9b-4577-08dcd7d19f57 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TEtRRFdoeFNQZUd2aXIvQnBmbkYxQkhIL25FdDRqbjJZWHQxM1JqYzdXaVhi?= =?utf-8?B?aEM4ZmRWR2g0WjR0VzBSdmh4OU1JeGxnZWt1TWFqeFlXeE4yazNSVzlQa2xH?= =?utf-8?B?d3dsaFY3MWoxZVdkckpoVlhtZzNpb2hyNUh4dFZhQXUrYzI2SnYwVFBxWjFt?= =?utf-8?B?UXFJZDBnWFp4UVg0Wlpmc0JibUhVTTMvWXdUbVdTVlRoM1VhM3dVUnpaNVlT?= =?utf-8?B?QVppR0NXeS8wM0FWMnhoYllBQVhlOXFSb3pmZ25MTkFLcnIzajg1U0g4WnJh?= =?utf-8?B?b0IvajQ0T1dPemgrdjJJemw3djJ2c3JiYTA4c2lQT2dDQ3hOempGWURTOUxQ?= =?utf-8?B?ZzhGckdwTXpvSFNpQk1FdExiNTVnVXFSdU0zMjE2djg2NEJtb1M4a01Ua3lw?= =?utf-8?B?OGpXSXZuS1kyRVZRWGR1Y2YrRW9LWmlkV3M0eWhwWm4rUlkyL1cxRFNvMXhM?= =?utf-8?B?cWxaSkdHWVVIOElETzc5bjZQcGdLVml4dmdPY0J3elRubk1LcXFWYzB3d3FN?= =?utf-8?B?enVHK1JIYi9Pb0NiWDdwMGFMUGpwTUQ2S2RISm9kTnpOS1MzaTVRRTNxbGh5?= =?utf-8?B?VU9xRWZsMExIZlorbUx5SlhLK2tLS1VsUENCKzZHQXhpRUIxUWFxdVhLV3ph?= =?utf-8?B?ZGo2WS9HMWhZcy9FajdWaU9KL0lUZ0loQkMxTWM0bTFSNVpTSExSNE52RVhs?= =?utf-8?B?bHJFV2szUGFidGJ5V1JsS1lFNllRM0lPWHZUdWYxQU5vTEt5S1FkVkNxaWo5?= =?utf-8?B?YWNuQVVIeVlBMTBVQW1sRjF4Rk1vRHNPMGR6VXhUQjYyRm1SanQwbTdmU29J?= =?utf-8?B?U085ait3OUhZUTVuMjNET09TSDNSeTR3RzJKY1hoelZvTDBBWFU4UklqWk96?= =?utf-8?B?VlNHMFJZQ2lwaE5zZVFoclZoREFRYVFobVY5b1c5RDFhTTR1K3ZnV1lHbXlo?= =?utf-8?B?Z3lIWHpOTDdpZjI4YWZxZ0VXMklyOWltcCtWRnB2U2ZKRy9Hb0cvRlJxOEtR?= =?utf-8?B?Q1NVM0Z5RitOdzgrMXFaWVgyREVXeXpCS1NUUThNNHN0MmZvM2gvY09FRWZB?= =?utf-8?B?OEJTYVJJUW1QRjE0b3N2Z1BZcWZrN2ZKZ0ZkZ1VFQmVpUWlmajhmbDQ0RTZ3?= =?utf-8?B?MFhaSnNpeHlCZUEwQnh3V2hEdUR6R3BEWVdpTHpvYklBYXcvNW0vbjJSbkdy?= =?utf-8?B?dS9NTWJGYUN2c2swRlBrWnpYTDJwN3RZZmVUb29aVW1Pak1mdXcvVTFEK3Z4?= =?utf-8?B?cnQzandKYzlqTEZYOVc3NnhScVpDRHh3c3BlbW9HU3RtWFIvNnJmRXNQUEpV?= =?utf-8?B?aWxXY0hTeGlPek1peFFoeHM2bitSd3Ryd0M1SDU0L1dLNkkwc1BNMVVCaHJW?= =?utf-8?B?QW1wU08xN0xnOTBSbW1RV1FLVzdkbGUxUTJwNDlsWTNXaWJ3YTJrcjFYUFQz?= =?utf-8?B?cVZaQ3JLVytwT2QwL3o5WTFxbm5NOGZYYiszS1d2Vmp4TWpxaHlUUkQ0dXNt?= =?utf-8?B?QnZsc3VSOUxnNE5jREtaRnRpNm0wSFdMSlRBQUdFclZtTk5aK1FKSlliY2Iy?= =?utf-8?B?Y2VMcTdlODBlUWZ6N1gvTXhIQ0x1YS82bXM5cXhMR3d4dkc1djFLbWJxWmN6?= =?utf-8?B?N3dHT29pM0Z6Mllhc0NITDR1U1ltUWsyRExmUmRyQWFuM2JhMmlWa1YvajB1?= =?utf-8?B?eVpwS2hkUkZhVGk1cUNsdkY3cFJJZUdJY2VrdjcrNlF5bzFwN3dvSDZIdzVX?= =?utf-8?B?UGZ6blhld0dpeFN6S0h1MjhkNlNqVEZ6UjRSbG93QjgySGJNK0phYWIzaGZz?= =?utf-8?B?dG5mSVlIR3RkWUJYL2U4YzRpN1pPWWc1amFpM1l6K3lBVWVURVN5dXA2dFpV?= =?utf-8?B?NmFyVmJPbGZneXFGZXhLVEtNU3UvVXJhdmk0L29Mb1dxZHc9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR03MB9635.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWtyV1JhSGUvZkovWEJzYU1xVDNxNG5iWGpFV2FDb2lMbmR2T1dNL0hsY2JK?= =?utf-8?B?SHVsU2RGbjVIbElTSDRJNVp2YmVxV2IvNnl6RE9wTEttc1ZELzdlWEhaalAw?= =?utf-8?B?THR1OXJhWTdURnF3eXJSZ1VPYlczYi9vZUhSWkhnTnp3SWZxRmhKUFZ3MGFP?= =?utf-8?B?ZXdxaVhQd1RZU3MwWXZxL29TU1F3TWVoR3FoRFE1dWkvNVRyWFNPWXVkNito?= =?utf-8?B?U1BNN0IxVHVWaGV2UzRyQzJkMVRENllwMHVlN0d4TWhIWTdXWmFRTVgwWWow?= =?utf-8?B?MnU1RTBlQ2xzeVJWWlVmMEpGUWNublZTTlVNTjFteHRFcEpQMUU0VjhZa2tu?= =?utf-8?B?MHM3dUlHRTdlbVduRWhvR2s1SzBhQ25GMGsvK0ZmTHQ5NFdZNERicW5SY28v?= =?utf-8?B?RUE2aUIvK1EwRzR1Zk56RnlNL2FPMktBS3o5N3VET0cwQUtFcjA3U2djb3Mx?= =?utf-8?B?VXpBNlA3OG5qN1JQcFYvRktvZTZtU0lZRzFWT2V0S1NXYm13aGw3aXEyWDRI?= =?utf-8?B?ZGM5bUQwUlNlSi9kbHI2eXk5dEduc2NPRWtmeHJmVE1jRVZjeTI5VnBQR2Er?= =?utf-8?B?aldGK1B3a3MvWk9SL09YbEc1dkNGcUxyK0w2R2Rid0lOWWF4RkxFckV2eG1a?= =?utf-8?B?RTQ5bExWRGdLWHlMYjdxMjV1akk2d2tTVkhTa1JaQ1JlK1paY3owNnJ4eVA4?= =?utf-8?B?ZmVZNS8rZzhlUGFrcG5pR2J0bWxwVEgvbXEycmh3anh3ZXgzR0tUNHBrSXIr?= =?utf-8?B?c21SSWFndXhKS2lEYlBicThvbHcrYm9POUE4Y0dBbC9TSDJPcXhHeUYzOEVy?= =?utf-8?B?bTVOQ1J4cCtvRGRZMUR4MzRybFlxQy91K0RxYzhQelRTby9hL1F4TzRBcTh4?= =?utf-8?B?bVhEdkEyenlRREFIcXVJL1BnTEZXdnNYV3JiQkxqajlXS1lMZytyZmFoVWVR?= =?utf-8?B?N2IwTUpvYjZTM3JkcDJtSExzbG5zUXlSSDZCYTlpVkhjQXphUStYd1BvR0V5?= =?utf-8?B?RUJTN2FoQ01CY2NnUStoUXBxNm5QUzVzR3I4aFlrR3hRWXVOZ2xzNWxJcmhq?= =?utf-8?B?U0lha3hxWTQ3QXFVS016QXZZdFo3ZG4xbm9iNDZRb1BxL0ZNbmlEZ1c2S1Er?= =?utf-8?B?ZCtyT2lhd1RMakFpZVJacGY2RGxWbVlJUStKd1RpS0pZb3NOWWRUbGx4V0hY?= =?utf-8?B?RzJEaExneHg4QU4zWWVacDR1SWtRV2JOY2hZeEUycjN4ZWZLZkF1V2FwVmNa?= =?utf-8?B?S0ZkL3RtYlVTbjh3Ri8xVkNhSGxaY29UYVRKUHFDNXlRWSsvRytwN0tBYitx?= =?utf-8?B?WGM0U0lxcFJpYmFSQmZxQjdjVjVHRFJqaEpsdURjYVJOKzc1dVNWalZRQmFn?= =?utf-8?B?UVpkVUZoNmQyL1VlY01maVAvTjNBYUd5YXhUWkdXYzYzaDdYTGJtMGQyMjds?= =?utf-8?B?ZWsvZXUwZXF3WjRWaW9ZTmM1K0QrUnNjY3dsVDBZbjk4bmZEQ0Z4bGU0MWla?= =?utf-8?B?d2JVY2NOc2g3U04rVXBrQ005TVRaUVd5TFk3L0FRWDg1TXhEa25Md3ZTOUxV?= =?utf-8?B?V3ZrTkxRdWdPbHlHdk82bUZCLzhuS2lsL0VGSnJlLzFPby8xNkcreHFTd2JD?= =?utf-8?B?SGtNY3RWV1cxMCtBZ2NJSmcydTNpUUJXY2VGelNLMjROTm95d29FaXpXRWVD?= =?utf-8?B?QkIxck9POEtQbUhxK0ZtaVdhM0FtVU41MGMwaWhIYUdKaFZ3WUhFUFU4ZHY3?= =?utf-8?B?ZmYzZFhET3ZNOTRET1Y1NjFST1hXbTlBTzFtZi9vU2hKUmNPbUNGNTBzc0J6?= =?utf-8?B?MjY3b0Nzd2kyYkFjT2N0aUZxRkd5dTUvVnZuaXU2RURHM2h0TXJRcnJLTTZu?= =?utf-8?B?RWx3bnhuL29tZVB6OG9vRXptTXAwbVQ1bDNVS0Nxb2xvMkE3Z1pqL1ZCNmJN?= =?utf-8?B?K3RGMjdQY0szNGpjRlFXSWtzaU9kYmRzSXVzcVRYUmswSXQxTnM3ZHFXY3dP?= =?utf-8?B?a2RYZ2VyNUN0Ti8rbVBHcHN0Uy9qQmJGNVE2bkNpQXJhNmF5K0JOYVhBK2RN?= =?utf-8?B?eWYvVjR5ZUpod2dFSmxEc245Z1BZMTBIYnI1cnl6dmNmcDVHeVJKN1MvOXRn?= =?utf-8?Q?jbAA58UoSiIDPGfmPnkP9psZH?= X-OriginatorOrg: identity.pt X-MS-Exchange-CrossTenant-Network-Message-Id: f66dbf64-bbc2-4b9b-4577-08dcd7d19f57 X-MS-Exchange-CrossTenant-AuthSource: DU0PR03MB9635.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2024 11:04:10.2747 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a8ad7d8-375c-4938-8554-e308b3a7f550 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9LDPXdBey1mRDaMI4ik9ohEMtdLtCDsTC4Ng6lmmh6QjTAtVIOgkfqhXAeBlntvFvhs2hxrhRAW5ogfZTvF5YQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR03MB10763 Content-Transfer-Encoding: quoted-printable X-MailFrom: Joao.Ribeiro@identity.pt X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 Message-ID-Hash: JPGBVQWH4QE2RLJVYA7S74CFVHD7WIBX X-Message-ID-Hash: JPGBVQWH4QE2RLJVYA7S74CFVHD7WIBX X-Mailman-Approved-At: Wed, 18 Sep 2024 15:35:36 -0400 CC: =?UTF-8?q?Jo=C3=A3o=20Sena=20Ribeiro?= X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Jo=C3=A3o_Sena_Ribeiro_via_Devel?= Reply-To: =?UTF-8?q?Jo=C3=A3o=20Sena=20Ribeiro?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1726673761483116600 Content-Type: text/plain; charset="utf-8" All VMs are being created with no hpet timer defined. Check if the VM definition XML file enables HPET and reflect that on the VMX file. Signed-off-by: Jo=C3=A3o Sena Ribeiro --- src/vmx/vmx.c | 31 ++++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index de16c1f634..d7e116dd07 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -65,7 +65,7 @@ def->maxvcpus =3D <=3D> numvcpus =3D = "" def->cpumask =3D <=3D> sched.cpu.affinity =3D "" def->cputune.shares =3D <=3D> sched.cpu.shares =3D ""= # with handling for special values = # "high", "normal", "low" - +def->ntimers <=3D> hpet.present =3D "" = # "true", "false" =20 =20 ##########################################################################= ###### @@ -3496,6 +3496,35 @@ virVMXFormatConfig(virVMXContext *ctx, virDomainXMLO= ption *xmlopt, virDomainDef } } =20 + /* def:clock.ntimers */ + for (i =3D 0; i < def->clock.ntimers; i++) { + switch ((virDomainTimerNameType)def->clock.timers[i]->name) { + case VIR_DOMAIN_TIMER_NAME_HPET: + if (def->clock.timers[i]->present =3D=3D VIR_TRISTATE_BOOL_YES= ) { + virBufferAddLit(&buffer, "hpet0.present =3D \"true\"\n"); + } else if (def->clock.timers[i]->present =3D=3D VIR_TRISTATE_B= OOL_NO) { + virBufferAddLit(&buffer, "hpet0.present =3D \"false\"\n"); + } + break; + + case VIR_DOMAIN_TIMER_NAME_TSC: + case VIR_DOMAIN_TIMER_NAME_PLATFORM: + case VIR_DOMAIN_TIMER_NAME_KVMCLOCK: + case VIR_DOMAIN_TIMER_NAME_HYPERVCLOCK: + case VIR_DOMAIN_TIMER_NAME_RTC: + case VIR_DOMAIN_TIMER_NAME_PIT: + case VIR_DOMAIN_TIMER_NAME_ARMVTIMER: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("unsupported timer type (name) '%1$s'"), + virDomainTimerNameTypeToString(def->clock.timer= s[i]->name)); + goto cleanup; + + case VIR_DOMAIN_TIMER_NAME_LAST: + break; + + } + } + /* def:graphics */ for (i =3D 0; i < def->ngraphics; ++i) { switch (def->graphics[i]->type) { --=20 2.34.1