From nobody Sat Dec 21 16:59:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1726147617131726.9918767659358; Thu, 12 Sep 2024 06:26:57 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 11667D43; Thu, 12 Sep 2024 09:26:56 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 79E43145A; Thu, 12 Sep 2024 09:26:39 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id ABF5513C8; Thu, 12 Sep 2024 09:26:36 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3D04B139C for ; Thu, 12 Sep 2024 09:26:36 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-113-nLF4SApyP7C2WZjeHTQ1ZQ-1; Thu, 12 Sep 2024 09:26:34 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2D30519560B5 for ; Thu, 12 Sep 2024 13:26:34 +0000 (UTC) Received: from szobal-thinkpadt14sgen2i.tpb.com (unknown [10.22.16.75]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 064AE30001AB for ; Thu, 12 Sep 2024 13:26:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726147596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YYMhU9xq2Gnva9V9LpmkRW8QcgyyWGcWq3j5gFa7Jgk=; b=fpBtiaoDwcU+wqrwVaAPOyqyX/yqPGkBGXNTS7iIy+SIS9+71mcJP/mlTwpw104VyP9l16 yzv4NZwTie8kWtPS7ir/ybyglzbrAUF3ZwulX6bQPJxjURAQYDnGnWwxNHnRpmdN8zfFsW 37OWnFp14pjSjFBRPkNfogapx//M9Xk= X-MC-Unique: nLF4SApyP7C2WZjeHTQ1ZQ-1 From: Stepan Zobal To: devel@lists.libvirt.org Subject: [PATCH v2] documentation: untrue statement in GetVersion() method description Date: Thu, 12 Sep 2024 15:26:27 +0200 Message-ID: <20240912132627.45732-1-szobal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: VZK6H7SCTBBF6GMSXDABVBQ6KQKIZSJF X-Message-ID-Hash: VZK6H7SCTBBF6GMSXDABVBQ6KQKIZSJF X-MailFrom: szobal@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1726147619743116600 Content-Type: text/plain; charset="utf-8"; x-default="true" In the end of virConnectGetVersion() description there is written: "not wit= h a Read-Only connection" which isn't true after I tried virConnectOpenReadOnly() with virConnectGetV= ersion() and it clearly shows the version correctly. Signed-off-by: Stepan Zobal Reviewed-by: Martin Kletzander --- Removed another unnecessary comment about virConnectGetVersion() method. src/libvirt-host.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/libvirt-host.c b/src/libvirt-host.c index e67b36812e..b3a6421a7f 100644 --- a/src/libvirt-host.c +++ b/src/libvirt-host.c @@ -179,9 +179,7 @@ virConnectGetType(virConnectPtr conn) * @conn: pointer to the hypervisor connection * @hvVer: return value for the version of the running hypervisor (OUT) * - * Get the version level of the Hypervisor running. This may work only with - * hypervisor call, i.e. with privileged access to the hypervisor, not - * with a Read-Only connection. + * Get the version level of the Hypervisor running. * * Returns -1 in case of error, 0 otherwise. if the version can't be * extracted by lack of capacities returns 0 and @hvVer is 0, otherwise --=20 2.46.0