[v2] Adapt to latest libxml2

[PATCH v2 0/2] Adapt to latest libxml2

Posted by Jakub Palacky 9 months, 1 week ago

I noticed a couple deprecation errors when trying to build libvirt
with the latest libxml2 version from the master branch. These patches
fix the deprecated fields.

Both functions used are available in the oldest libxml2 version
required by libvirt, so there is no need to bump it.

Changes in v2:
  - Save return value of xmlCtxtGetLastError for later use
  - Check that xmlCtxtGetLastError doesn't return NULL

Jakub Palacky (2):
  util/virxml: use xmlCtxtGetLastError when applicable
  vmx: use xmlBufferDetach() when applicable

 src/util/virxml.c | 19 ++++++++++---------
 src/vmx/vmx.c     |  2 +-
 2 files changed, 11 insertions(+), 10 deletions(-)

-- 
2.46.0

Re: [PATCH v2 0/2] Adapt to latest libxml2

Posted by Ján Tomko 9 months, 1 week ago

On a Thursday in 2024, Jakub Palacky wrote:
>I noticed a couple deprecation errors when trying to build libvirt
>with the latest libxml2 version from the master branch. These patches
>fix the deprecated fields.
>
>Both functions used are available in the oldest libxml2 version
>required by libvirt, so there is no need to bump it.
>
>Changes in v2:
>  - Save return value of xmlCtxtGetLastError for later use
>  - Check that xmlCtxtGetLastError doesn't return NULL
>
>Jakub Palacky (2):
>  util/virxml: use xmlCtxtGetLastError when applicable
>  vmx: use xmlBufferDetach() when applicable
>
> src/util/virxml.c | 19 ++++++++++---------
> src/vmx/vmx.c     |  2 +-
> 2 files changed, 11 insertions(+), 10 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

I will push it after the pipeline suceeds:
https://gitlab.com/janotomko/libvirt/-/pipelines/1450732527

Jano