From nobody Sun Feb 8 17:07:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1725556140500616.5884782954737; Thu, 5 Sep 2024 10:09:00 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 71D2F175B; Thu, 5 Sep 2024 13:08:59 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id C91FB17E8; Thu, 5 Sep 2024 13:08:10 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 6A04E1752; Thu, 5 Sep 2024 13:08:05 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id CB6001751 for ; Thu, 5 Sep 2024 13:08:04 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-156-cnxw63baM62LL6m8aGlO7Q-1; Thu, 05 Sep 2024 13:08:02 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 21C5019560AB for ; Thu, 5 Sep 2024 17:08:02 +0000 (UTC) Received: from vhost3.router.laine.org (unknown [10.22.16.247]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 969A01956094 for ; Thu, 5 Sep 2024 17:08:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: *** X-Spam-Status: No, score=3.0 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725556084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xn/y6lvuGnrka1pu3dtgDzublL/uU40jFjhyxBvvLl8=; b=iq2d3mx6oF5DKasMSKOLViBqRflANJeh70BRlgwHwQjYDkITehwFLJyyId/e79Q96BZoSJ Ygr5q6VW5gfPqKtOFtvK4mG4hg1gKaP+SWkW6+ahyK6d6NL/nQkCVcU8TUvhLq2B+n/fle OfWvW7Jnz/GsRTpiyxcWVyfniv3jTj8= X-MC-Unique: cnxw63baM62LL6m8aGlO7Q-1 From: Laine Stump To: devel@lists.libvirt.org Subject: [PATCH 2/5] network: belatedly update an error message Date: Thu, 5 Sep 2024 13:07:56 -0400 Message-ID: <20240905170759.864299-3-laine@redhat.com> In-Reply-To: <20240905170759.864299-1-laine@redhat.com> References: <20240905170759.864299-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: W3DSVYSMQLYTZYX6BSUIATLMC3Q4WJFO X-Message-ID-Hash: W3DSVYSMQLYTZYX6BSUIATLMC3Q4WJFO X-MailFrom: laine@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1725556141277116600 Content-Type: text/plain; charset="utf-8"; x-default="true" The 'open' forward type probably hadn't yet been added when this message was written. Signed-off-by: Laine Stump Reviewed-by: Martin Kletzander --- src/conf/network_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 3383906c58..5fadaf35e9 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -1851,7 +1851,7 @@ virNetworkDefParseXML(xmlXPathContextPtr ctxt, case VIR_NETWORK_FORWARD_BRIDGE: if (def->delay || stp || def->bridgeZone) { virReportError(VIR_ERR_XML_ERROR, - _("bridge delay/stp/zone options only allowed i= n route, nat, and isolated mode, not in %1$s (network '%2$s')"), + _("bridge delay/stp/zone options only allowed i= n open, route, nat, and isolated mode, not in %1$s (network '%2$s')"), virNetworkForwardTypeToString(def->forward.type= ), def->name); return NULL; --=20 2.46.0