From nobody Sat Feb 7 16:15:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1720042906112982.2433211923098; Wed, 3 Jul 2024 14:41:46 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 6A128145D; Wed, 3 Jul 2024 17:41:44 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 52FA012AE; Wed, 3 Jul 2024 17:41:14 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 416B71275; Wed, 3 Jul 2024 17:41:11 -0400 (EDT) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id F2C8F1261 for ; Wed, 3 Jul 2024 17:41:09 -0400 (EDT) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2c8517aab46so25155a91.1 for ; Wed, 03 Jul 2024 14:41:09 -0700 (PDT) Received: from localhost.localdomain ([49.47.192.165]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c91ce1f18dsm11456349a91.1.2024.07.03.14.41.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jul 2024 14:41:08 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720042868; x=1720647668; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1VzyAJ/Ud1Ps005QSWWdVyegRW5fjOnvGJ6Gbon77As=; b=b7jA9HKq1LD7IUYjQDyAfd6P4cxUJNjUClaxTBMU4wcNCoy2FFqsZeCWuhsiQPLYhz nn5w5b9TKIm8GdUqtz1+8M0to9L/OlISsFgsjQw04xZRRZTtGUtrpPHwJQGNUDOMKNhZ Llycn2EvTk44R46pOpsjghLA5Rn0Ayu7qbEYHxt504OZOsP2fo9qMftHhGDpGhKYGs2R jf44PiC29MQ+oAGUcb60Jn8EkjE8o+QNHcwfVFB/btq0KwMcgKY0lC2w3G0oyTc6Lr95 U499s9mDOmeYENeu0K4JjF4LYumYa2Q/khYE2loTlr+5cahrIioeS5443mmAYCOZZYN5 tCkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720042868; x=1720647668; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1VzyAJ/Ud1Ps005QSWWdVyegRW5fjOnvGJ6Gbon77As=; b=vwm7uhBJ9sbIje3Q0iQAvWsL2f9AuHYncFP9/ZiBMdlfDuzg/do8iuer+nqsdlvwX7 uAspSHP1p4DFEU51J7fAgRh6G1FYxfMVcrHd9xRj2hnvtB/7EL4kD1rEzb5iBQZdHnIT dvicplbUKHRLU6CpiLy5bNUfjxdkNyzPf3E1bwx2pSTJhCFlvVnyA1MhOZFYOUp+NEQk R8A9eqVyNY88+LWi1aErM9Z9WUp8JyGE2Ny0gqPVByOlxOHnJijrJT3d0iBea0KU5YcJ clFpg9aO4LGMuNVE7l42oZ/8BZtpAjv44Uz3YcbTSwNPe5sxH0d9X7V34XEf2PA8gZCa e+vA== X-Gm-Message-State: AOJu0YwzZ/NvbC/4MjaL5hBXP1QN14O8p3WCq1UN6XipLXNYojE+5LYu dPpeDP4eviMytzmff+pPGM8kKmCz6jBrZGuokQnZrIsMEY3IF1y1c4YvlQ== X-Google-Smtp-Source: AGHT+IFZSGmShawUx8mgpdYeExInX0gSy2wQui9aPf/za4eeD2ks2qn1ByGCtYc0MQMEmLNbFCkyuA== X-Received: by 2002:a17:90b:234b:b0:2c9:6920:d2c1 with SMTP id 98e67ed59e1d1-2c96920d57cmr4027173a91.10.1720042868410; Wed, 03 Jul 2024 14:41:08 -0700 (PDT) From: Rayhan Faizel To: devel@lists.libvirt.org Subject: [PATCH v2] tests: Move domainEventState initialization to qemuTestDriverInit Date: Thu, 4 Jul 2024 03:10:13 +0530 Message-Id: <20240703214013.7230-1-rayhan.faizel@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: RU7EJINKQMQWSCVXVML7EEKYYDCI4VF7 X-Message-ID-Hash: RU7EJINKQMQWSCVXVML7EEKYYDCI4VF7 X-MailFrom: rayhan.faizel@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Rayhan Faizel X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1720042908535100001 Content-Type: text/plain; charset="utf-8" Under the test environment, driver->domainEventState is uninitialized. If a disk gets dropped, it will attempt to queue an event which will cause a segmentation fault. This crash does not occur during normal use. This patch moves driver->domainEventState initialization from qemuhotplugte= st to qemuTestDriverInit in testutilsqemu (Credit goes to Michal Privoznik as = he had already provided the diff). An additional test case is added to test dropping of disks with startupPoli= cy set as optional. Signed-off-by: Rayhan Faizel Reviewed-by: Michal Privoznik --- As the patch title has completely changed, v1: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/= 4476AKGV4MWNSTUR4DAJVZSVOQEINVJK/#4476AKGV4MWNSTUR4DAJVZSVOQEINVJK [Changes in v2] - Move domainEventState initialization instead of adding a NULL check tests/qemuhotplugtest.c | 3 -- ...tuppolicy-optional-drop.x86_64-latest.args | 33 ++++++++++++++++ ...rtuppolicy-optional-drop.x86_64-latest.xml | 38 +++++++++++++++++++ .../disk-startuppolicy-optional-drop.xml | 23 +++++++++++ tests/qemuxmlconftest.c | 1 + tests/testutilsqemu.c | 4 ++ 6 files changed, 99 insertions(+), 3 deletions(-) create mode 100644 tests/qemuxmlconfdata/disk-startuppolicy-optional-drop.= x86_64-latest.args create mode 100644 tests/qemuxmlconfdata/disk-startuppolicy-optional-drop.= x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/disk-startuppolicy-optional-drop.= xml diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index d935ad58ed..f707121c47 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -501,9 +501,6 @@ mymain(void) =20 virEventRegisterDefaultImpl(); =20 - if (!(driver.domainEventState =3D virObjectEventStateNew())) - return EXIT_FAILURE; - driver.lockManager =3D virLockManagerPluginNew("nop", "qemu", driver.config->configBase= Dir, 0); diff --git a/tests/qemuxmlconfdata/disk-startuppolicy-optional-drop.x86_64-= latest.args b/tests/qemuxmlconfdata/disk-startuppolicy-optional-drop.x86_64= -latest.args new file mode 100644 index 0000000000..13ddbc1a5d --- /dev/null +++ b/tests/qemuxmlconfdata/disk-startuppolicy-optional-drop.x86_64-latest.= args @@ -0,0 +1,33 @@ +LC_ALL=3DC \ +PATH=3D/bin \ +HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGuest1 \ +USER=3Dtest \ +LOGNAME=3Dtest \ +XDG_DATA_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.local/share \ +XDG_CACHE_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.cache \ +XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ +/usr/bin/qemu-system-x86_64 \ +-name guest=3DQEMUGuest1,debug-threads=3Don \ +-S \ +-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes"}' \ +-machine pc,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Dpc.ram,acpi= =3Doff \ +-accel tcg \ +-cpu qemu64 \ +-m size=3D219136k \ +-object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}'= \ +-overcommit mem-lock=3Doff \ +-smp 1,sockets=3D1,cores=3D1,threads=3D1 \ +-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ +-display none \ +-no-user-config \ +-nodefaults \ +-chardev socket,id=3Dcharmonitor,fd=3D1729,server=3Don,wait=3Doff \ +-mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ +-rtc base=3Dutc \ +-no-shutdown \ +-boot strict=3Don \ +-device '{"driver":"piix3-usb-uhci","id":"usb","bus":"pci.0","addr":"0x1.0= x2"}' \ +-device '{"driver":"lsi","id":"scsi0","bus":"pci.0","addr":"0x2"}' \ +-audiodev '{"id":"audio1","driver":"none"}' \ +-sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ +-msg timestamp=3Don diff --git a/tests/qemuxmlconfdata/disk-startuppolicy-optional-drop.x86_64-= latest.xml b/tests/qemuxmlconfdata/disk-startuppolicy-optional-drop.x86_64-= latest.xml new file mode 100644 index 0000000000..27d0639109 --- /dev/null +++ b/tests/qemuxmlconfdata/disk-startuppolicy-optional-drop.x86_64-latest.= xml @@ -0,0 +1,38 @@ + + QEMUGuest1 + c7a5fdbd-edaf-9455-926a-d65c16db1809 + 219100 + 219100 + 1 + + hvm + + + + qemu64 + + + destroy + restart + destroy + + /usr/bin/qemu-system-x86_64 + + + + +
+ + +
+ + + +
+ + + +