From nobody Thu Sep 19 01:04:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1719559637531137.80712623128022; Fri, 28 Jun 2024 00:27:17 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 2E9DF1276; Fri, 28 Jun 2024 03:27:16 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 76EA7E91; Fri, 28 Jun 2024 03:26:55 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id B3F471085; Fri, 28 Jun 2024 03:26:51 -0400 (EDT) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lists.libvirt.org (Postfix) with ESMTP id 669B1E32 for ; Fri, 28 Jun 2024 03:26:50 -0400 (EDT) Received: from paekkaladevi-dev-u22.gi4irqh5pfqublruu4yyku2wof.phxx.internal.cloudapp.net (unknown [20.125.125.171]) by linux.microsoft.com (Postfix) with ESMTPSA id 6F2B220B700B; Fri, 28 Jun 2024 00:26:48 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6F2B220B700B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1719559608; bh=msig3PTlbFGBKbPDIBOXhKy2E03gVwfQCzSx0V43hMo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RS7XAXBJiYSslC3iTl4fpyAe8VKk5ttXZHndGPwQ0rWypEa5zHLKTmLwa7M6C9T8h DSFRuktn+AoCcV9O7qJTO2rmLpU4Kfedecl4VflRxJi6Vdsk+K2WrjhQDa02ameGU0 YM6rs+iRer5WIGQcikgO50hM4NrlucP6KpPlIHf8= From: Purna Pavan Chandra To: devel@lists.libvirt.org Subject: [PATCH 1/8] ch: report response message instead of just code Date: Fri, 28 Jun 2024 07:26:40 +0000 Message-Id: <20240628072647.2674-2-paekkaladevi@linux.microsoft.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240628072647.2674-1-paekkaladevi@linux.microsoft.com> References: <20240628072647.2674-1-paekkaladevi@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: GE2IYMY4JUTPFN66B6J6DAD6FM56AQKN X-Message-ID-Hash: GE2IYMY4JUTPFN66B6J6DAD6FM56AQKN X-MailFrom: paekkaladevi@linux.microsoft.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: paekkaladevi@microsoft.com, prapal@linux.microsoft.com, liuwe@microsoft.com, kumarpraveen@linux.microsoft.com, Purna Pavan Chandra X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Computed bodyhash is different from the expected one) X-ZM-MESSAGEID: 1719559637908100001 Content-Type: text/plain; charset="utf-8" The response message from CH for vm.add-net api will be more helpful in debugging. Hence, log the message instead of just response code. Signed-off-by: Purna Pavan Chandra --- src/ch/ch_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ch/ch_process.c b/src/ch/ch_process.c index 48190a1273..6f99fec900 100644 --- a/src/ch/ch_process.c +++ b/src/ch/ch_process.c @@ -665,7 +665,7 @@ chProcessAddNetworkDevices(virCHDriver *driver, } if (http_res !=3D 204 && http_res !=3D 200) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unexpected response from CH: %1$d"), http_re= s); + _("Unexpected response from CH: %1$s"), respons= e); return -1; } } --=20 2.34.1